Kaydet (Commit) eecb2b8d authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#735758 Unchecked dynamic_cast

Change-Id: I7d995f0f54034e1ab4927e1aaa3632b975b8d7fc
üst 69255b7c
...@@ -377,7 +377,7 @@ void LwpPara::RegisterStyle() ...@@ -377,7 +377,7 @@ void LwpPara::RegisterStyle()
pOverStyle->SetStyleName(""); pOverStyle->SetStyleName("");
LwpParaProperty* pProps = m_pProps; LwpParaProperty* pProps = m_pProps;
sal_uInt32 PropType; sal_uInt32 PropType;
LwpParaStyle* pParaStyle = dynamic_cast<LwpParaStyle*>(m_ParaStyle.obj()); LwpParaStyle& rParaStyle = dynamic_cast<LwpParaStyle&>(*m_ParaStyle.obj());
while (pProps) while (pProps)
{ {
PropType = pProps->GetType(); PropType = pProps->GetType();
...@@ -385,12 +385,12 @@ void LwpPara::RegisterStyle() ...@@ -385,12 +385,12 @@ void LwpPara::RegisterStyle()
{ {
case PP_LOCAL_ALIGN: case PP_LOCAL_ALIGN:
{ {
if (!pParaStyle->GetAlignment()) if (!rParaStyle.GetAlignment())
OverrideAlignment(NULL,static_cast<LwpParaAlignProperty*>(pProps)->GetAlignment(),pOverStyle); OverrideAlignment(NULL,static_cast<LwpParaAlignProperty*>(pProps)->GetAlignment(),pOverStyle);
else else
{ {
boost::scoped_ptr<LwpAlignmentOverride> const pAlign( boost::scoped_ptr<LwpAlignmentOverride> const pAlign(
pParaStyle->GetAlignment()->clone()); rParaStyle.GetAlignment()->clone());
OverrideAlignment(pAlign.get(), OverrideAlignment(pAlign.get(),
static_cast<LwpParaAlignProperty*>(pProps)->GetAlignment(), static_cast<LwpParaAlignProperty*>(pProps)->GetAlignment(),
pOverStyle); pOverStyle);
...@@ -400,7 +400,7 @@ void LwpPara::RegisterStyle() ...@@ -400,7 +400,7 @@ void LwpPara::RegisterStyle()
case PP_LOCAL_INDENT: case PP_LOCAL_INDENT:
{ {
noIndent = sal_False; noIndent = sal_False;
if (!pParaStyle->GetIndent()) if (!rParaStyle.GetIndent())
OverrideIndent(NULL,static_cast<LwpParaIndentProperty*>(pProps)->GetIndent(),pOverStyle); OverrideIndent(NULL,static_cast<LwpParaIndentProperty*>(pProps)->GetIndent(),pOverStyle);
else else
...@@ -412,12 +412,12 @@ void LwpPara::RegisterStyle() ...@@ -412,12 +412,12 @@ void LwpPara::RegisterStyle()
case PP_LOCAL_SPACING: case PP_LOCAL_SPACING:
{ {
noSpacing = sal_False; noSpacing = sal_False;
if (!pParaStyle->GetSpacing()) if (!rParaStyle.GetSpacing())
OverrideSpacing(NULL,static_cast<LwpParaSpacingProperty*>(pProps)->GetSpacing(),pOverStyle); OverrideSpacing(NULL,static_cast<LwpParaSpacingProperty*>(pProps)->GetSpacing(),pOverStyle);
else else
{ {
boost::scoped_ptr<LwpSpacingOverride> const boost::scoped_ptr<LwpSpacingOverride> const
pSpacing(pParaStyle->GetSpacing()->clone()); pSpacing(rParaStyle.GetSpacing()->clone());
OverrideSpacing(pSpacing.get(), OverrideSpacing(pSpacing.get(),
static_cast<LwpParaSpacingProperty*>(pProps)->GetSpacing(), static_cast<LwpParaSpacingProperty*>(pProps)->GetSpacing(),
pOverStyle); pOverStyle);
...@@ -450,7 +450,7 @@ void LwpPara::RegisterStyle() ...@@ -450,7 +450,7 @@ void LwpPara::RegisterStyle()
case PP_LOCAL_TABRACK: case PP_LOCAL_TABRACK:
{ {
//, 01/28/05 //, 01/28/05
/*LwpTabOverride* pTabOverride=pParaStyle->GetTabOverride(); /*LwpTabOverride* pTabOverride=rParaStyle.GetTabOverride();
if(!pTabOverride) if(!pTabOverride)
{ {
OverrideTab(NULL,static_cast<LwpParaTabRackProperty*>(pProps)->GetTab(),pOverStyle); OverrideTab(NULL,static_cast<LwpParaTabRackProperty*>(pProps)->GetTab(),pOverStyle);
...@@ -464,11 +464,11 @@ void LwpPara::RegisterStyle() ...@@ -464,11 +464,11 @@ void LwpPara::RegisterStyle()
case PP_LOCAL_BACKGROUND: case PP_LOCAL_BACKGROUND:
{ {
/* LwpBackgroundOverride aBackground; /* LwpBackgroundOverride aBackground;
if (!pParaStyle->GetBackground()) if (!rParaStyle.GetBackground())
OverrideBackground(NULL,static_cast<LwpParaBackGroundProperty*>(pProps)->GetBackground(),pOverStyle); OverrideBackground(NULL,static_cast<LwpParaBackGroundProperty*>(pProps)->GetBackground(),pOverStyle);
else else
{ {
aBackground = *(pParaStyle->GetaBackground()); aBackground = *(rParaStyle.GetaBackground());
OverrideBackground(&aBackground,static_cast<LwpParaBackGroundProperty*>(pProps)->GetBackground(),pOverStyle); OverrideBackground(&aBackground,static_cast<LwpParaBackGroundProperty*>(pProps)->GetBackground(),pOverStyle);
} }
*/ */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment