Related tdf#103421: disposeAndClear m_aColorSet (reportdesign)
m_aColorSet has been declared as VclPtr<ValueSet> then initialized with VclPtr<ValueSet>::Create(this, WinBits( WB_ITEMBORDER | WB_NAMEFIELD | WB_3DLOOK | WB_NO_DIRECTSELECT)) Following vcl/README.lifecycle, we're on the case 2 of "Who owns & disposes what ?" so we should use disposeAndClear Change-Id: I5809b54b8a15c365362c05c35a7499d8f4f69ed2 Reviewed-on: https://gerrit.libreoffice.org/30176Tested-by:Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
Showing
Please
register
or
sign in
to comment