Kaydet (Commit) efebf518 authored tarafından Kohei Yoshida's avatar Kohei Yoshida

These don't have to be member functions.

üst 52f56d24
...@@ -151,9 +151,7 @@ public: ...@@ -151,9 +151,7 @@ public:
//ods filter tests //ods filter tests
void testRangeName(); void testRangeName();
void testRangeNameImpl(ScDocument* pDoc);
void testContent(); void testContent();
void testContentImpl(ScDocument* pDoc); //same code for ods, xls, xlsx
void testFunctions(); void testFunctions();
void testBugFixesODS(); void testBugFixesODS();
void testBugFixesXLS(); void testBugFixesXLS();
...@@ -291,7 +289,9 @@ void FiltersTest::testCVEs() ...@@ -291,7 +289,9 @@ void FiltersTest::testCVEs()
} }
void FiltersTest::testRangeNameImpl(ScDocument* pDoc) namespace {
void testRangeNameImpl(ScDocument* pDoc)
{ {
//check one range data per sheet and one global more detailed //check one range data per sheet and one global more detailed
//add some more checks here //add some more checks here
...@@ -319,6 +319,8 @@ void FiltersTest::testRangeNameImpl(ScDocument* pDoc) ...@@ -319,6 +319,8 @@ void FiltersTest::testRangeNameImpl(ScDocument* pDoc)
CPPUNIT_ASSERT_MESSAGE("range name Sheet2.local1 should reference Sheet1.A5", aValue == 5); CPPUNIT_ASSERT_MESSAGE("range name Sheet2.local1 should reference Sheet1.A5", aValue == 5);
} }
}
void FiltersTest::testRangeName() void FiltersTest::testRangeName()
{ {
const rtl::OUString aFileNameBase(RTL_CONSTASCII_USTRINGPARAM("named-ranges-global.")); const rtl::OUString aFileNameBase(RTL_CONSTASCII_USTRINGPARAM("named-ranges-global."));
...@@ -339,7 +341,9 @@ void FiltersTest::testRangeName() ...@@ -339,7 +341,9 @@ void FiltersTest::testRangeName()
} }
} }
void FiltersTest::testContentImpl(ScDocument* pDoc) namespace {
void testContentImpl(ScDocument* pDoc) //same code for ods, xls, xlsx
{ {
double aValue; double aValue;
//check value import //check value import
...@@ -375,6 +379,8 @@ void FiltersTest::testContentImpl(ScDocument* pDoc) ...@@ -375,6 +379,8 @@ void FiltersTest::testContentImpl(ScDocument* pDoc)
//add additional checks here //add additional checks here
} }
}
void FiltersTest::testContent() void FiltersTest::testContent()
{ {
const rtl::OUString aFileNameBase(RTL_CONSTASCII_USTRINGPARAM("universal-content.")); const rtl::OUString aFileNameBase(RTL_CONSTASCII_USTRINGPARAM("universal-content."));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment