loplugin:unusedfields,can-be-const in xmlscript

Change-Id: Ibd733b822bb2eee9de6319b5ea9e4d8dd3641cdc
Reviewed-on: https://gerrit.libreoffice.org/57850
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/xmlscript/xml_helper.hxx

@@ -91,7 +91,7 @@ protected:
     ::std::vector< css::uno::Reference<
                       css::xml::sax::XAttributeList > > _subElems;
 private:
-    OUString _name;
+    OUString const _name;
     ::std::vector< OUString > _attrNames;
     ::std::vector< OUString > _attrValues;
 

xmlscript/source/xml_helper/xml_impctx.cxx

@@ -105,8 +105,8 @@ class DocumentHandlerImpl :
     t_OUString2LongMap m_URI2Uid;
     sal_Int32 m_uid_count;
 
-    OUString m_sXMLNS_PREFIX_UNKNOWN;
-    OUString m_sXMLNS;
+    OUString const m_sXMLNS_PREFIX_UNKNOWN;
+    OUString const m_sXMLNS;
 
     sal_Int32 m_nLastURI_lookup;
     OUString m_aLastURI_lookup;
@@ -301,7 +301,7 @@ inline void DocumentHandlerImpl::getElementName(
 class ExtendedAttributes :
     public ::cppu::WeakImplHelper< xml::input::XAttributes >
 {
-    sal_Int32 m_nAttributes;
+    sal_Int32 const m_nAttributes;
     std::unique_ptr<sal_Int32[]> m_pUids;
     std::unique_ptr<OUString[]>  m_pLocalNames;
     std::unique_ptr<OUString[]>  m_pQNames;

xmlscript/source/xmldlg_imexp/xmldlg_addfunc.cxx

@@ -36,7 +36,7 @@ namespace xmlscript
 class InputStreamProvider
     : public ::cppu::WeakImplHelper< io::XInputStreamProvider >
 {
-    std::vector<sal_Int8> _bytes;
+    std::vector<sal_Int8> const _bytes;
 
 public:
     explicit InputStreamProvider( std::vector<sal_Int8> const & rBytes )

xmlscript/source/xmlflat_imexp/xmlbas_export.hxx

@@ -45,7 +45,7 @@ namespace xmlscript
         ::osl::Mutex                                              m_aMutex;
         css::uno::Reference< css::xml::sax::XDocumentHandler >    m_xHandler;
         css::uno::Reference< css::frame::XModel >                 m_xModel;
-        bool                                                      m_bOasis;
+        bool const                                                m_bOasis;
 
     public:
         explicit XMLBasicExporterBase(bool bOasis);

xmlscript/source/xmlflat_imexp/xmlbas_import.hxx

@@ -47,7 +47,7 @@ namespace xmlscript
         rtl::Reference<BasicImport> m_xImport;
     private:
         rtl::Reference<BasicElementBase> m_xParent;
-        OUString m_aLocalName;
+        OUString const m_aLocalName;
         css::uno::Reference< css::xml::input::XAttributes > m_xAttributes;
 
     protected:
@@ -104,8 +104,8 @@ namespace xmlscript
     private:
         css::uno::Reference< css::script::XLibraryContainer2 > m_xLibContainer;
         css::uno::Reference< css::container::XNameContainer > m_xLib;
-        OUString m_aLibName;
-        bool m_bReadOnly;
+        OUString const m_aLibName;
+        bool const m_bReadOnly;
 
     public:
         BasicEmbeddedLibraryElement( const OUString& rLocalName,
@@ -127,7 +127,7 @@ namespace xmlscript
     {
     private:
         css::uno::Reference< css::container::XNameContainer > m_xLib;
-        OUString m_aName;
+        OUString const m_aName;
 
     public:
         BasicModuleElement( const OUString& rLocalName,
@@ -149,7 +149,7 @@ namespace xmlscript
     {
     private:
         css::uno::Reference< css::container::XNameContainer > m_xLib;
-        OUString m_aName;
+        OUString const m_aName;
         OUStringBuffer m_aBuffer;
 
     public:
@@ -180,7 +180,7 @@ namespace xmlscript
         sal_Int32 XMLNS_UID;
         sal_Int32 XMLNS_XLINK_UID;
         css::uno::Reference< css::frame::XModel > m_xModel;
-        bool m_bOasis;
+        bool const m_bOasis;
 
     public:
         BasicImport( const css::uno::Reference< css::frame::XModel >& rxModel, bool bOasis );
@@ -212,7 +212,7 @@ namespace xmlscript
         css::uno::Reference< css::uno::XComponentContext >        m_xContext;
         css::uno::Reference< css::xml::sax::XDocumentHandler >    m_xHandler;
         css::uno::Reference< css::frame::XModel >                 m_xModel;
-        bool                                                      m_bOasis;
+        bool const                                                m_bOasis;
 
     public:
         XMLBasicImporterBase(

xmlscript/source/xmllib_imexp/imp_share.hxx

@@ -110,7 +110,7 @@ struct LibraryImport
     friend class LibraryElement;
 
     LibDescriptorArray* mpLibArray;
-    LibDescriptor*      mpLibDesc;      // Single library mode
+    LibDescriptor* const mpLibDesc;      // Single library mode
 
     sal_Int32 XMLNS_LIBRARY_UID;
     sal_Int32 XMLNS_XLINK_UID;
@@ -155,7 +155,7 @@ protected:
     rtl::Reference<LibraryImport>  mxImport;
     rtl::Reference<LibElementBase> mxParent;
 private:
-    OUString _aLocalName;
+    OUString const _aLocalName;
     css::uno::Reference< css::xml::input::XAttributes > _xAttributes;
 
 public:

xmlscript/source/xmlmod_imexp/imp_share.hxx

@@ -78,7 +78,7 @@ class ModuleElement
 {
     rtl::Reference<ModuleImport> mxImport;
 
-    OUString _aLocalName;
+    OUString const _aLocalName;
     css::uno::Reference< css::xml::input::XAttributes > _xAttributes;
     OUStringBuffer _strBuffer;