Kaydet (Commit) f162b156 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#736036 Missing break in switch

someone's odd ": ;" habit

Change-Id: I4a3e3b89bb31764056c844286561e31ae4621036
üst f829d088
...@@ -963,9 +963,9 @@ bool SVGFilter::implGenerateMetaData() ...@@ -963,9 +963,9 @@ bool SVGFilter::implGenerateMetaData()
sNumberingType = "roman-lower"; sNumberingType = "roman-lower";
break; break;
// arabic numbering type is the default, so we do not append any attribute for it // arabic numbering type is the default, so we do not append any attribute for it
case SVX_ARABIC: ; case SVX_ARABIC:
// in case the numbering type is not handled we fall back on arabic numbering // in case the numbering type is not handled we fall back on arabic numbering
default: ; default:
break; break;
} }
if( !sNumberingType.isEmpty() ) if( !sNumberingType.isEmpty() )
...@@ -2231,8 +2231,8 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo ) ...@@ -2231,8 +2231,8 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo )
sDate += SvxDateField::GetFormatted( aDate, SVXDATEFORMAT_B, *pNumberFormatter, eLang ); sDate += SvxDateField::GetFormatted( aDate, SVXDATEFORMAT_B, *pNumberFormatter, eLang );
switch( eDateFormat ) switch( eDateFormat )
{ {
case SVXDATEFORMAT_E: ; // Tue, 13.February 1996 case SVXDATEFORMAT_E: // Tue, 13.February 1996
case SVXDATEFORMAT_STDBIG: ; case SVXDATEFORMAT_STDBIG:
case SVXDATEFORMAT_F: // Tuesday, 13.February 1996 case SVXDATEFORMAT_F: // Tuesday, 13.February 1996
for( sal_uInt16 i = 1; i <= 7; ++i ) // we get all days in a week for( sal_uInt16 i = 1; i <= 7; ++i ) // we get all days in a week
{ {
...@@ -2240,7 +2240,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo ) ...@@ -2240,7 +2240,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo )
sDate += SvxDateField::GetFormatted( aDate, eDateFormat, *pNumberFormatter, eLang ); sDate += SvxDateField::GetFormatted( aDate, eDateFormat, *pNumberFormatter, eLang );
} }
// No break here! We need months too! // No break here! We need months too!
case SVXDATEFORMAT_C: ; // 13.Feb 1996 case SVXDATEFORMAT_C: // 13.Feb 1996
case SVXDATEFORMAT_D: // 13.February 1996 case SVXDATEFORMAT_D: // 13.February 1996
for( sal_uInt16 i = 1; i <= 12; ++i ) // we get all months in a year for( sal_uInt16 i = 1; i <= 12; ++i ) // we get all months in a year
{ {
...@@ -2248,9 +2248,9 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo ) ...@@ -2248,9 +2248,9 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo )
sDate += SvxDateField::GetFormatted( aDate, eDateFormat, *pNumberFormatter, eLang ); sDate += SvxDateField::GetFormatted( aDate, eDateFormat, *pNumberFormatter, eLang );
} }
break; break;
case SVXDATEFORMAT_STDSMALL: ; case SVXDATEFORMAT_STDSMALL:
case SVXDATEFORMAT_A: ; // 13.02.96 case SVXDATEFORMAT_A: // 13.02.96
case SVXDATEFORMAT_B: ; // 13.02.1996 case SVXDATEFORMAT_B: // 13.02.1996
default: default:
// nothing to do here, we always collect the characters needed for these cases. // nothing to do here, we always collect the characters needed for these cases.
break; break;
...@@ -2276,7 +2276,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo ) ...@@ -2276,7 +2276,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo )
aRepresentation += "ivxlcdm"; aRepresentation += "ivxlcdm";
break; break;
// arabic numbering type is the default // arabic numbering type is the default
case SVX_ARABIC: ; case SVX_ARABIC:
// in case the numbering type is not handled we fall back on arabic numbering // in case the numbering type is not handled we fall back on arabic numbering
default: default:
aRepresentation += "0123456789"; aRepresentation += "0123456789";
...@@ -2341,7 +2341,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo ) ...@@ -2341,7 +2341,7 @@ IMPL_LINK( SVGFilter, CalcFieldHdl, EditFieldInfo*, pInfo )
aRepresentation += SvxNumberFormat::CreateRomanString( nPageNumber, false /* lower */ ); aRepresentation += SvxNumberFormat::CreateRomanString( nPageNumber, false /* lower */ );
break; break;
// arabic numbering type is the default // arabic numbering type is the default
case SVX_ARABIC: ; case SVX_ARABIC:
// in case the numbering type is not handled we fall back on arabic numbering // in case the numbering type is not handled we fall back on arabic numbering
default: default:
aRepresentation += OUString::number( nPageNumber ); aRepresentation += OUString::number( nPageNumber );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment