qadevOOo: use String.length()==0 instead of String.equals(empty string)

Change-Id: I5cdd1fb4fe77c7fc9614f2a6de8995d98d60b551
Reviewed-on: https://gerrit.libreoffice.org/11368Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

qadevOOo/runner/convwatch/GraphicalDifferenceCheck.java

@@ -320,7 +320,7 @@ public class GraphicalDifferenceCheck
 
     private static String ensureEndingFileSep(String s)
         {
-        if(s != null && !s.equals("") && !s.endsWith(File.separator))
+        if(s != null && s.length() != 0 && !s.endsWith(File.separator))
             {
                 s = s.trim() + File.separator;
             }

qadevOOo/runner/helper/CfgParser.java

@@ -48,7 +48,7 @@ public class CfgParser
     {
         debug = param.getBool(PropertyName.DEBUG_IS_ACTIVE);
         Properties cfg = null;
-        if (iniFile.equals(""))
+        if (iniFile.length() == 0)
         {
             //no iniFile given, search one in the users home directory
             cfg = getProperties(getDefaultFileName(true));

qadevOOo/runner/helper/OfficeProvider.java

@@ -183,7 +183,7 @@ public class OfficeProvider implements AppProvider
             Exception exConnectFailed = null;
             boolean isExecutable = false;
             boolean isAppKnown = ((cncstr.indexOf("host=localhost") > 0) || (cncstr.indexOf("pipe,name=") > 0));
-            isAppKnown &= !((String) param.get("AppExecutionCommand")).equals("");
+            isAppKnown &= ((String) param.get("AppExecutionCommand")).length() != 0;
 
             if (isAppKnown)
             {

qadevOOo/runner/util/XMLTools.java

@@ -377,7 +377,7 @@ public class XMLTools {
             super.startElement(name, attrs) ;
             if (tags.containsKey(name)) {
                 String outerTag = tags.get(name);
-                if (!outerTag.equals("")) {
+                if (outerTag.length() != 0) {
                     boolean isInTag = false ;
                     for (int i = 0; i < tagStack.size(); i++) {
                         if (outerTag.equals(tagStack.get(i))) {
@@ -401,7 +401,7 @@ public class XMLTools {
 
             if (chars.containsKey(ch)) {
                 String outerTag = chars.get(ch);
-                if (!outerTag.equals("")) {
+                if (outerTag.length() != 0) {
                     boolean isInTag = false ;
                     for (int i = 0; i < tagStack.size(); i++) {
                         if (outerTag.equals(tagStack.get(i))) {