loplugin:datamembershadow in StyleSheetUndoAction

Change-Id: Ic4de30f7e9582078562b661545ac23fe9927f83d
Reviewed-on: https://gerrit.libreoffice.org/30903Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

sd/source/ui/dlg/unchss.cxx

@@ -51,7 +51,7 @@ StyleSheetUndoAction::StyleSheetUndoAction(SdDrawDocument* pTheDoc,
     mpOldSet = o3tl::make_unique<SfxItemSet>(static_cast<SfxItemPool&>(SdrObject::GetGlobalDrawObjectItemPool()), mpStyleSheet->GetItemSet().GetRanges());
     SdrModel::MigrateItemSet( &mpStyleSheet->GetItemSet(), mpOldSet.get(), pTheDoc );
 
-    maComment = SD_RESSTR(STR_UNDO_CHANGE_PRES_OBJECT);
+    OUString aComment(SD_RESSTR(STR_UNDO_CHANGE_PRES_OBJECT));
     OUString aName(mpStyleSheet->GetName());
 
     // delete layout name and separator
@@ -91,7 +91,7 @@ StyleSheetUndoAction::StyleSheetUndoAction(SdDrawDocument* pTheDoc,
     }
 
     // replace placeholder with template name
-    maComment = maComment.replaceFirst("$", aName);
+    SetComment(aComment.replaceFirst("$", aName));
 }
 
 void StyleSheetUndoAction::Undo()
@@ -118,9 +118,4 @@ void StyleSheetUndoAction::Redo()
         mpStyleSheet->Broadcast(SfxHint(SFX_HINT_DATACHANGED));
 }
 
-OUString StyleSheetUndoAction::GetComment() const
-{
-    return maComment;
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sd/source/ui/inc/unchss.hxx

@@ -34,7 +34,6 @@ class StyleSheetUndoAction : public SdUndoAction
 
     std::unique_ptr<SfxItemSet> mpNewSet;
     std::unique_ptr<SfxItemSet> mpOldSet;
-    OUString        maComment;
 
 public:
     StyleSheetUndoAction(SdDrawDocument* pTheDoc,
@@ -43,8 +42,6 @@ public:
 
     virtual void Undo() override;
     virtual void Redo() override;
-
-    virtual OUString GetComment() const override;
 };
 
 #endif // INCLUDED_SD_SOURCE_UI_INC_UNCHSS_HXX