cppcheck: knownConditionTrueFalse 'bValid' is always true

Change-Id: I3f73641286020a06a605867726d54376c47a06dc
Reviewed-on: https://gerrit.libreoffice.org/42134Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

cui/source/dialogs/scriptdlg.cxx

@@ -1002,23 +1002,10 @@ void SvxScriptOrgDialog::renameEntry( SvTreeListEntry* pEntry )
         ScopedVclPtrInstance< CuiInputDialog > xNewDlg( static_cast<vcl::Window*>(this), InputDialogMode::RENAME );
         xNewDlg->SetObjectName( aNewName );
 
-        bool bValid;
-        do
-        {
-            if ( xNewDlg->Execute() && !xNewDlg->GetObjectName().isEmpty() )
-            {
-                OUString aUserSuppliedName = xNewDlg->GetObjectName();
-                bValid = true;
-                if( bValid )
-                    aNewName = aUserSuppliedName;
-            }
-            else
-            {
-                // user hit cancel or hit OK with nothing in the editbox
-                return;
-            }
-        }
-        while ( !bValid );
+        if ( !xNewDlg->Execute() || xNewDlg->GetObjectName().isEmpty() )
+            return; // user hit cancel or hit OK with nothing in the editbox
+
+        aNewName = xNewDlg->GetObjectName();
 
         Sequence< Any > args( 1 );
         args[ 0 ] <<= aNewName;