reportdesign: Use appropriate OUString functions on string constants

Change-Id: I4baeb6ed5a3f16c3c1f0a2715cb011ef2555fc90

reportdesign/source/filter/xml/xmlGroup.cxx

@@ -138,7 +138,7 @@ OXMLGroup::OXMLGroup( ORptFilter& _rImport
                                     nGroupOn = report::GroupOn::MONTH;
                                 }
                                 else if ( sCompleteFormula.matchIgnoreAsciiCase("rpt:INT((MONTH",0)
-                                       && sCompleteFormula.endsWithIgnoreAsciiCaseAsciiL("-1)/3)+1",8) )
+                                       && sCompleteFormula.endsWithIgnoreAsciiCase("-1)/3)+1") )
                                 {
                                     nGroupOn = report::GroupOn::QUARTAL;
                                 }

reportdesign/source/ui/inspection/DataProviderHandler.cxx

@@ -263,7 +263,7 @@ inspection::LineDescriptor SAL_CALL DataProviderHandler::describePropertyLine(co
     switch(nId)
     {
         case PROPERTY_ID_CHARTTYPE:
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_PROP_CHARTTYPE_DLG);
+            aOut.PrimaryButtonId = UID_RPT_PROP_CHARTTYPE_DLG;
             aOut.Control = _xControlFactory->createPropertyControl(inspection::PropertyControlType::TextField , sal_True);
             aOut.HasPrimaryButton = sal_True;
             break;
@@ -273,7 +273,7 @@ inspection::LineDescriptor SAL_CALL DataProviderHandler::describePropertyLine(co
         case PROPERTY_ID_MASTERFIELDS:
         case PROPERTY_ID_DETAILFIELDS:
             aOut.Control = _xControlFactory->createPropertyControl(inspection::PropertyControlType::StringListField , sal_False);
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_PROP_DLG_LINKFIELDS);
+            aOut.PrimaryButtonId = UID_RPT_PROP_DLG_LINKFIELDS;
             aOut.HasPrimaryButton = sal_True;
             break;
         default:

reportdesign/source/ui/inspection/GeometryHandler.cxx

@@ -773,12 +773,12 @@ inspection::LineDescriptor SAL_CALL GeometryHandler::describePropertyLine(const
             break;
         case PROPERTY_ID_INITIALFORMULA:
         case PROPERTY_ID_FORMULA:
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_PROP_FORMULA);
+            aOut.PrimaryButtonId = UID_RPT_PROP_FORMULA;
             aOut.HasPrimaryButton = sal_True;
             aOut.Control = _xControlFactory->createPropertyControl(inspection::PropertyControlType::MultiLineTextField , sal_False);
             break;
         case PROPERTY_ID_CONDITIONALPRINTEXPRESSION:
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_PROP_FORMULA);
+            aOut.PrimaryButtonId = UID_RPT_PROP_FORMULA;
             aOut.HasPrimaryButton = sal_True;
             aOut.Control = _xControlFactory->createPropertyControl(inspection::PropertyControlType::MultiLineTextField , sal_False);
             break;
@@ -793,7 +793,7 @@ inspection::LineDescriptor SAL_CALL GeometryHandler::describePropertyLine(const
 
                 if ( m_nDataFieldType == DATA_OR_FORMULA )
                 {
-                    aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_PROP_FORMULA);
+                    aOut.PrimaryButtonId = UID_RPT_PROP_FORMULA;
                     aOut.HasPrimaryButton = sal_True;
                 }
 
@@ -820,12 +820,12 @@ inspection::LineDescriptor SAL_CALL GeometryHandler::describePropertyLine(const
             aOut.Control = _xControlFactory->createPropertyControl( inspection::PropertyControlType::ColorListBox, sal_False );
             break;
         case PROPERTY_ID_FONT:
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_RPT_PROP_DLG_FONT_TYPE);
+            aOut.PrimaryButtonId = UID_RPT_RPT_PROP_DLG_FONT_TYPE;
             aOut.Control = _xControlFactory->createPropertyControl( inspection::PropertyControlType::TextField, sal_True );
             aOut.HasPrimaryButton = sal_True;
             break;
         case PROPERTY_ID_AREA:
-            aOut.PrimaryButtonId = OUString::createFromAscii(UID_RPT_RPT_PROP_DLG_AREA);
+            aOut.PrimaryButtonId = UID_RPT_RPT_PROP_DLG_AREA;
             aOut.Control = _xControlFactory->createPropertyControl( inspection::PropertyControlType::TextField, sal_True );
             aOut.HasPrimaryButton = sal_True;
             break;