Kaydet (Commit) f41cbea9 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

More -Werror=redundant-move

...similar to dc06c8f4 "-Werror=redundant-move
(GCC 9), take two"

Change-Id: I53c181887e254aa3d924c134c77d7d0230717d5c
Reviewed-on: https://gerrit.libreoffice.org/59750
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
üst 5288887d
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include <memory> #include <memory>
#include <com/sun/star/i18n/UnicodeType.hpp> #include <com/sun/star/i18n/UnicodeType.hpp>
#include <config_global.h>
#include <i18nlangtag/lang.h> #include <i18nlangtag/lang.h>
#include <tools/lineend.hxx> #include <tools/lineend.hxx>
#include <unotools/configmgr.hxx> #include <unotools/configmgr.hxx>
...@@ -995,7 +996,11 @@ std::unique_ptr<SmNode> SmParser::DoAlign(bool bUseExtraSpaces) ...@@ -995,7 +996,11 @@ std::unique_ptr<SmNode> SmParser::DoAlign(bool bUseExtraSpaces)
if (xSNode) if (xSNode)
{ {
xSNode->SetSubNode(0, pNode.release()); xSNode->SetSubNode(0, pNode.release());
return std::move(xSNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return xSNode;
#else
return std::move(xSNode);
#endif
} }
return pNode; return pNode;
} }
...@@ -1030,7 +1035,11 @@ std::unique_ptr<SmNode> SmParser::DoLine() ...@@ -1030,7 +1035,11 @@ std::unique_ptr<SmNode> SmParser::DoLine()
auto xSNode = o3tl::make_unique<SmLineNode>(m_aCurToken); auto xSNode = o3tl::make_unique<SmLineNode>(m_aCurToken);
xSNode->SetSubNodes(buildNodeArray(ExpressionArray)); xSNode->SetSubNodes(buildNodeArray(ExpressionArray));
return std::move(xSNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return xSNode;
#else
return std::move(xSNode);
#endif
} }
std::unique_ptr<SmNode> SmParser::DoExpression(bool bUseExtraSpaces) std::unique_ptr<SmNode> SmParser::DoExpression(bool bUseExtraSpaces)
...@@ -1049,9 +1058,11 @@ std::unique_ptr<SmNode> SmParser::DoExpression(bool bUseExtraSpaces) ...@@ -1049,9 +1058,11 @@ std::unique_ptr<SmNode> SmParser::DoExpression(bool bUseExtraSpaces)
std::unique_ptr<SmExpressionNode> xSNode(new SmExpressionNode(m_aCurToken)); std::unique_ptr<SmExpressionNode> xSNode(new SmExpressionNode(m_aCurToken));
xSNode->SetSubNodes(buildNodeArray(RelationArray)); xSNode->SetSubNodes(buildNodeArray(RelationArray));
xSNode->SetUseExtraSpaces(bUseExtraSpaces); xSNode->SetUseExtraSpaces(bUseExtraSpaces);
// the following explicit move can be omitted since C++14: #if HAVE_CXX_CWG1579_FIX
// https://stackoverflow.com/questions/22018115/converting-stdunique-ptrderived-to-stdunique-ptrbase return xSNode;
#else
return std::move(xSNode); return std::move(xSNode);
#endif
} }
else else
{ {
...@@ -1256,7 +1267,11 @@ std::unique_ptr<SmNode> SmParser::DoSubSup(TG nActiveGroup, SmNode *pGivenNode) ...@@ -1256,7 +1267,11 @@ std::unique_ptr<SmNode> SmParser::DoSubSup(TG nActiveGroup, SmNode *pGivenNode)
} }
pNode->SetSubNodes(buildNodeArray(aSubNodes)); pNode->SetSubNodes(buildNodeArray(aSubNodes));
return std::move(pNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return pNode;
#else
return std::move(pNode);
#endif
} }
std::unique_ptr<SmNode> SmParser::DoOpSubSup() std::unique_ptr<SmNode> SmParser::DoOpSubSup()
...@@ -1272,7 +1287,11 @@ std::unique_ptr<SmNode> SmParser::DoOpSubSup() ...@@ -1272,7 +1287,11 @@ std::unique_ptr<SmNode> SmParser::DoOpSubSup()
// get sub- supscripts if any // get sub- supscripts if any
if (m_aCurToken.nGroup == TG::Power) if (m_aCurToken.nGroup == TG::Power)
return DoSubSup(TG::Power, pNode.release()); return DoSubSup(TG::Power, pNode.release());
return std::move(pNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return pNode;
#else
return std::move(pNode);
#endif
} }
std::unique_ptr<SmNode> SmParser::DoPower() std::unique_ptr<SmNode> SmParser::DoPower()
...@@ -1776,7 +1795,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoAttribut() ...@@ -1776,7 +1795,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoAttribut()
xSNode->SetSubNodes(xAttr.release(), nullptr); // the body will be filled later xSNode->SetSubNodes(xAttr.release(), nullptr); // the body will be filled later
xSNode->SetScaleMode(eScaleMode); xSNode->SetScaleMode(eScaleMode);
return std::move(xSNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return xSNode;
#else
return std::move(xSNode);
#endif
} }
std::unique_ptr<SmStructureNode> SmParser::DoFontAttribut() std::unique_ptr<SmStructureNode> SmParser::DoFontAttribut()
...@@ -1797,7 +1820,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoFontAttribut() ...@@ -1797,7 +1820,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoFontAttribut()
{ {
auto pNode = o3tl::make_unique<SmFontNode>(m_aCurToken); auto pNode = o3tl::make_unique<SmFontNode>(m_aCurToken);
NextToken(); NextToken();
return std::move(pNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return pNode;
#else
return std::move(pNode);
#endif
} }
case TSIZE : case TSIZE :
...@@ -1959,7 +1986,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoFontSize() ...@@ -1959,7 +1986,11 @@ std::unique_ptr<SmStructureNode> SmParser::DoFontSize()
NextToken(); NextToken();
pFontNode->SetSizeParameter(aValue, Type); pFontNode->SetSizeParameter(aValue, Type);
return std::move(pFontNode); // this explicit move can be omitted since C++14 #if HAVE_CXX_CWG1579_FIX
return pFontNode;
#else
return std::move(pFontNode);
#endif
} }
SmStructureNode *SmParser::DoBrace() SmStructureNode *SmParser::DoBrace()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment