fdo#57950: Remove chained append and simplify strings

No need to two strings here, since just destFolder is used.

Change-Id: Ie1bfd5744113764caaec11d9fb9c771f9c67e1c4
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: Luboš Luňák <l.lunak@suse.cz>

basctl/source/basicide/moduldl2.cxx

@@ -1314,14 +1314,12 @@ void LibPage::ExportAsPackage( const String& aLibName )
 
         ::ucbhelper::Content sourceContent( aSourcePath, xCmdEnv, comphelper::getProcessComponentContext() );
 
-        OUStringBuffer buf;
-        buf.appendAscii( "vnd.sun.star.zip://" );
-        buf.append( ::rtl::Uri::encode( aPackageURL,
-                                        rtl_UriCharClassRegName,
-                                        rtl_UriEncodeIgnoreEscapes,
-                                        RTL_TEXTENCODING_UTF8 ) );
-        buf.append( static_cast<sal_Unicode>('/') );
-        OUString destFolder( buf.makeStringAndClear() );
+        OUString destFolder = "vnd.sun.star.zip://" +
+                              ::rtl::Uri::encode( aPackageURL,
+                                                  rtl_UriCharClassRegName,
+                                                  rtl_UriEncodeIgnoreEscapes,
+                                                  RTL_TEXTENCODING_UTF8 ) +
+                              "/";
 
         if( xSFA->exists( aPackageURL ) )
             xSFA->kill( aPackageURL );