Kaydet (Commit) f77302d7 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:useuniqueptr in OQueryDescriptor_Base

Change-Id: I9cea18df52bc0a35f94c2a42dfbe3edb61e1e8c0
Reviewed-on: https://gerrit.libreoffice.org/50699Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 4b44ab2f
...@@ -130,7 +130,7 @@ void OQuery::rebuildColumns() ...@@ -130,7 +130,7 @@ void OQuery::rebuildColumns()
{ {
xColumnDefinitions = xColSup->getColumns(); xColumnDefinitions = xColSup->getColumns();
if ( xColumnDefinitions.is() ) if ( xColumnDefinitions.is() )
m_pColumnMediator = new OContainerMediator( m_pColumns, xColumnDefinitions ); m_pColumnMediator = new OContainerMediator( m_pColumns.get(), xColumnDefinitions );
} }
// fill the columns with columns from the statement // fill the columns with columns from the statement
......
...@@ -120,14 +120,14 @@ OQueryDescriptor_Base::OQueryDescriptor_Base(::osl::Mutex& _rMutex,::cppu::OWea ...@@ -120,14 +120,14 @@ OQueryDescriptor_Base::OQueryDescriptor_Base(::osl::Mutex& _rMutex,::cppu::OWea
:m_bColumnsOutOfDate(true) :m_bColumnsOutOfDate(true)
,m_rMutex(_rMutex) ,m_rMutex(_rMutex)
{ {
m_pColumns = new OColumns(_rMySelf, m_rMutex, true,std::vector< OUString>(), this,this); m_pColumns.reset( new OColumns(_rMySelf, m_rMutex, true,std::vector< OUString>(), this,this) );
} }
OQueryDescriptor_Base::OQueryDescriptor_Base(const OQueryDescriptor_Base& _rSource,::cppu::OWeakObject& _rMySelf) OQueryDescriptor_Base::OQueryDescriptor_Base(const OQueryDescriptor_Base& _rSource,::cppu::OWeakObject& _rMySelf)
:m_bColumnsOutOfDate(true) :m_bColumnsOutOfDate(true)
,m_rMutex(_rSource.m_rMutex) ,m_rMutex(_rSource.m_rMutex)
{ {
m_pColumns = new OColumns(_rMySelf, m_rMutex, true,std::vector< OUString>(), this,this); m_pColumns.reset( new OColumns(_rMySelf, m_rMutex, true,std::vector< OUString>(), this,this) );
m_sCommand = _rSource.m_sCommand; m_sCommand = _rSource.m_sCommand;
m_bEscapeProcessing = _rSource.m_bEscapeProcessing; m_bEscapeProcessing = _rSource.m_bEscapeProcessing;
...@@ -141,8 +141,6 @@ OQueryDescriptor_Base::~OQueryDescriptor_Base() ...@@ -141,8 +141,6 @@ OQueryDescriptor_Base::~OQueryDescriptor_Base()
{ {
m_pColumns->acquire(); m_pColumns->acquire();
m_pColumns->disposing(); m_pColumns->disposing();
delete m_pColumns;
} }
sal_Int64 SAL_CALL OQueryDescriptor_Base::getSomething( const Sequence< sal_Int8 >& _rIdentifier ) sal_Int64 SAL_CALL OQueryDescriptor_Base::getSomething( const Sequence< sal_Int8 >& _rIdentifier )
...@@ -204,7 +202,7 @@ Reference< XNameAccess > SAL_CALL OQueryDescriptor_Base::getColumns( ) ...@@ -204,7 +202,7 @@ Reference< XNameAccess > SAL_CALL OQueryDescriptor_Base::getColumns( )
} }
} }
return m_pColumns; return m_pColumns.get();
} }
OUString SAL_CALL OQueryDescriptor_Base::getImplementationName( ) OUString SAL_CALL OQueryDescriptor_Base::getImplementationName( )
......
...@@ -55,7 +55,7 @@ private: ...@@ -55,7 +55,7 @@ private:
::osl::Mutex& m_rMutex; ::osl::Mutex& m_rMutex;
protected: protected:
OColumns* m_pColumns; // our column descriptions std::unique_ptr<OColumns> m_pColumns; // our column descriptions
OUString m_sElementName; OUString m_sElementName;
virtual ~OQueryDescriptor_Base(); virtual ~OQueryDescriptor_Base();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment