Kaydet (Commit) f875364d authored tarafından Aditya's avatar Aditya Kaydeden (comit) Mike Kaganski

tdf#119812: Hide "Windows Share" server type in Windows OS.

The "Windows Share" server type is non-functional in Windows OS but
still shown in the File Services (PlaceEditDialog) dialog.
This patch removes its entry from dialog on Windows only so that no more 
non-functional service can be created.

Change-Id: I440c637dd2a566f820a6e8fac826f35cabb9c05f
Reviewed-on: https://gerrit.libreoffice.org/66055
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
üst 28570ba8
...@@ -223,10 +223,17 @@ void PlaceEditDialog::InitDetails( ) ...@@ -223,10 +223,17 @@ void PlaceEditDialog::InitDetails( )
xSshDetails->setChangeHdl( LINK( this, PlaceEditDialog, EditHdl ) ); xSshDetails->setChangeHdl( LINK( this, PlaceEditDialog, EditHdl ) );
m_aDetailsContainers.push_back(xSshDetails); m_aDetailsContainers.push_back(xSshDetails);
// Remove Windows Share entry from dialog on Windows OS, where it's non-functional
#if defined(_WIN32)
// nPos is the position of first item that is pre-defined in svtools/uiconfig/ui/placeedit.ui,
// after other CMIS types were inserted
m_xLBServerType->remove(nPos + 3);
#else
// Create Windows Share control // Create Windows Share control
std::shared_ptr<DetailsContainer> xSmbDetails(std::make_shared<SmbDetailsContainer>(this)); std::shared_ptr<DetailsContainer> xSmbDetails(std::make_shared<SmbDetailsContainer>(this));
xSmbDetails->setChangeHdl( LINK( this, PlaceEditDialog, EditHdl ) ); xSmbDetails->setChangeHdl( LINK( this, PlaceEditDialog, EditHdl ) );
m_aDetailsContainers.push_back(xSmbDetails); m_aDetailsContainers.push_back(xSmbDetails);
#endif
// Set default to first value // Set default to first value
m_xLBServerType->set_active(0); m_xLBServerType->set_active(0);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment