clang-cl loplugin: unotools

Change-Id: I1bbdae6b27a04321b232851f5f45ac2248b55835
Reviewed-on: https://gerrit.libreoffice.org/29843Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

include/unotools/fltrcfg.hxx

@@ -29,8 +29,6 @@ class UNOTOOLS_DLLPUBLIC SvtFilterOptions : public utl::ConfigItem
 private:
     std::unique_ptr<SvtFilterOptions_Impl> pImpl;
 
-    const css::uno::Sequence<OUString>& GetPropertyNames();
-
     virtual void            ImplCommit() override;
 
 public:

unotools/source/config/fltrcfg.cxx

@@ -292,19 +292,9 @@ bool SvtFilterOptions_Impl::IsFlag( sal_uLong nFlag ) const
     return bRet;
 }
 
-SvtFilterOptions::SvtFilterOptions() :
-    ConfigItem( "Office.Common/Filter/Microsoft" ),
-    pImpl(new SvtFilterOptions_Impl)
-{
-    EnableNotification(GetPropertyNames());
-    Load();
-}
+namespace {
 
-SvtFilterOptions::~SvtFilterOptions()
-{
-}
-
-const Sequence<OUString>& SvtFilterOptions::GetPropertyNames()
+const Sequence<OUString>& GetPropertyNames()
 {
     static Sequence<OUString> aNames;
     if(!aNames.getLength())
@@ -335,6 +325,20 @@ const Sequence<OUString>& SvtFilterOptions::GetPropertyNames()
     return aNames;
 }
 
+}
+
+SvtFilterOptions::SvtFilterOptions() :
+    ConfigItem( "Office.Common/Filter/Microsoft" ),
+    pImpl(new SvtFilterOptions_Impl)
+{
+    EnableNotification(GetPropertyNames());
+    Load();
+}
+
+SvtFilterOptions::~SvtFilterOptions()
+{
+}
+
 static sal_uLong lcl_GetFlag(sal_Int32 nProp)
 {
     sal_uLong nFlag = 0;