KDE5: minor Qt5Menu cleanup

Remove unnecessary destructor

Move MenuBar clearing out of DoFullMenuUpdate function

Change-Id: I0fb916c6935b2f8a675e75adf696d99203a2c016
Reviewed-on: https://gerrit.libreoffice.org/66386
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

vcl/inc/qt5/Qt5Menu.hxx

@@ -43,7 +43,6 @@ private:
 
 public:
     Qt5Menu(bool bMenuBar);
-    virtual ~Qt5Menu() override;
 
     virtual bool VisibleMenuBar() override; // must return TRUE to actually DISPLAY native menu bars
 

vcl/qt5/Qt5Menu.cxx

@@ -32,8 +32,6 @@ Qt5Menu::Qt5Menu(bool bMenuBar)
     connect(this, &Qt5Menu::setFrameSignal, this, &Qt5Menu::SetFrame, Qt::BlockingQueuedConnection);
 }
 
-Qt5Menu::~Qt5Menu() { maItems.clear(); }
-
 bool Qt5Menu::VisibleMenuBar() { return true; }
 
 QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, unsigned nPos)
@@ -227,6 +225,9 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
     if (pMainWindow)
     {
         mpQMenuBar = pMainWindow->menuBar();
+        if (mpQMenuBar)
+            mpQMenuBar->clear();
+
         mpQMenu = nullptr;
         mpQActionGroup = nullptr;
 
@@ -236,9 +237,6 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
 
 void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar)
 {
-    if (mbMenuBar && mpQMenuBar)
-        mpQMenuBar->clear();
-
     for (sal_Int32 nItem = 0; nItem < static_cast<sal_Int32>(GetItemCount()); nItem++)
     {
         Qt5MenuItem* pSalMenuItem = GetItemAtPos(nItem);