clang-tidy performance-unnecessary-value-param in unotools

Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5

include/unotools/ucbhelper.hxx

@@ -61,8 +61,8 @@ UNOTOOLS_DLLPUBLIC bool MakeFolder(
 
 /// like mkdir -p
 UNOTOOLS_DLLPUBLIC bool ensureFolder(
-    css::uno::Reference< css::uno::XComponentContext > xCtx,
-    css::uno::Reference< css::ucb::XCommandEnvironment > xEnv,
+    const css::uno::Reference< css::uno::XComponentContext >& xCtx,
+    const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
     const OUString& rFolder, ucbhelper::Content & result) throw();
 
 /// @return the value of the "Size" property of the given content, or zero if

include/unotools/ucbstreamhelper.hxx

@@ -54,13 +54,13 @@ namespace utl
     public:
         static SvStream*    CreateStream( const OUString& rFileName, StreamMode eOpenMode );
         static SvStream*    CreateStream( const OUString& rFileName, StreamMode eOpenMode,
-                                          css::uno::Reference < css::task::XInteractionHandler > );
+                                          const css::uno::Reference < css::task::XInteractionHandler >& );
         static SvStream*    CreateStream( const OUString& rFileName, StreamMode eOpenMode,
                                           bool bFileExists );
-        static SvStream*    CreateStream( css::uno::Reference < css::io::XInputStream > xStream );
-        static SvStream*    CreateStream( css::uno::Reference < css::io::XStream > xStream );
-        static SvStream*    CreateStream( css::uno::Reference < css::io::XInputStream > xStream, bool bCloseStream );
-        static SvStream*    CreateStream( css::uno::Reference < css::io::XStream > xStream, bool bCloseStream );
+        static SvStream*    CreateStream( const css::uno::Reference < css::io::XInputStream >& xStream );
+        static SvStream*    CreateStream( const css::uno::Reference < css::io::XStream >& xStream );
+        static SvStream*    CreateStream( const css::uno::Reference < css::io::XInputStream >& xStream, bool bCloseStream );
+        static SvStream*    CreateStream( const css::uno::Reference < css::io::XStream >& xStream, bool bCloseStream );
     };
 }
 

unotools/source/ucbhelper/ucbhelper.cxx

@@ -449,8 +449,8 @@ bool utl::UCBContentHelper::EqualURLs(
 }
 
 bool utl::UCBContentHelper::ensureFolder(
-    css::uno::Reference< css::uno::XComponentContext > xCtx,
-    css::uno::Reference< css::ucb::XCommandEnvironment > xEnv,
+    const css::uno::Reference< css::uno::XComponentContext >& xCtx,
+    const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
     const OUString& rFolder, ucbhelper::Content & result) throw()
 {
     try

unotools/source/ucbhelper/ucblockbytes.cxx

@@ -712,17 +712,17 @@ void SAL_CALL Moderator::onTerminated()
    but with handled timeout;
 */
 static bool UCBOpenContentSync_(
-    UcbLockBytesRef xLockBytes,
-    Reference < XContent > xContent,
+    const UcbLockBytesRef& xLockBytes,
+    const Reference < XContent >& xContent,
     const Command& rArg,
-    Reference < XInterface > xSink,
-    Reference < XInteractionHandler > xInteract );
+    const Reference < XInterface >& xSink,
+    const Reference < XInteractionHandler >& xInteract );
 
 static bool UCBOpenContentSync(
-    UcbLockBytesRef xLockBytes,
+    const UcbLockBytesRef& xLockBytes,
     Reference < XContent > xContent,
     const Command& rArg,
-    Reference < XInterface > xSink,
+    const Reference < XInterface >& xSink,
     Reference < XInteractionHandler > xInteract )
 {
     // http protocol must be handled in a special way:
@@ -957,11 +957,11 @@ static bool UCBOpenContentSync(
     Function for opening UCB contents synchronously
  */
 static bool UCBOpenContentSync_(
-    UcbLockBytesRef xLockBytes,
-    Reference < XContent > xContent,
+    const UcbLockBytesRef& xLockBytes,
+    const Reference < XContent >& xContent,
     const Command& rArg,
-    Reference < XInterface > xSink,
-    Reference < XInteractionHandler > xInteract )
+    const Reference < XInterface >& xSink,
+    const Reference < XInteractionHandler >& xInteract )
 {
     ::ucbhelper::Content aContent(
         xContent, new UcbTaskEnvironment( xInteract, nullptr ),

unotools/source/ucbhelper/ucbstreamhelper.cxx

@@ -41,7 +41,7 @@ namespace utl
 {
 
 static SvStream* lcl_CreateStream( const OUString& rFileName, StreamMode eOpenMode,
-                                   Reference < XInteractionHandler > xInteractionHandler,
+                                   const Reference < XInteractionHandler >& xInteractionHandler,
                                    UcbLockBytesHandler* pHandler, bool bEnsureFileExists )
 {
     SvStream* pStream = nullptr;
@@ -144,7 +144,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode e
 }
 
 SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode eOpenMode,
-                                         Reference < XInteractionHandler > xInteractionHandler )
+                                         const Reference < XInteractionHandler >& xInteractionHandler )
 {
     return lcl_CreateStream( rFileName, eOpenMode, xInteractionHandler, nullptr, true /* bEnsureFileExists */ );
 }
@@ -155,7 +155,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode e
     return lcl_CreateStream( rFileName, eOpenMode, Reference < XInteractionHandler >(), nullptr, !bFileExists );
 }
 
-SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >& xStream )
 {
     SvStream* pStream = nullptr;
     UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -169,7 +169,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream )
     return pStream;
 }
 
-SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream )
 {
     SvStream* pStream = nullptr;
     if ( xStream->getOutputStream().is() )
@@ -188,7 +188,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream )
     return pStream;
 }
 
-SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream, bool bCloseStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >& xStream, bool bCloseStream )
 {
     SvStream* pStream = nullptr;
     UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -205,7 +205,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream, boo
     return pStream;
 };
 
-SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream, bool bCloseStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream, bool bCloseStream )
 {
     SvStream* pStream = nullptr;
     if ( xStream->getOutputStream().is() )