Kaydet (Commit) fbb3f88d authored tarafından Stephan Bergmann's avatar Stephan Bergmann

loplugin:unnecessaryoverride (dtors) in slideshow

Change-Id: I5c4bc26bc51347e453ce69913edc52cf1f1aa821
üst 96918103
...@@ -43,7 +43,7 @@ class RewinderEventHandler : public EventHandler ...@@ -43,7 +43,7 @@ class RewinderEventHandler : public EventHandler
public: public:
typedef ::std::function<bool ()> Action; typedef ::std::function<bool ()> Action;
explicit RewinderEventHandler (const Action& rAction) : maAction(rAction) {} explicit RewinderEventHandler (const Action& rAction) : maAction(rAction) {}
virtual ~RewinderEventHandler() override {}
private: private:
const Action maAction; const Action maAction;
virtual bool handleEvent() override { return maAction(); } virtual bool handleEvent() override { return maAction(); }
...@@ -55,7 +55,7 @@ class RewinderAnimationEventHandler : public AnimationEventHandler ...@@ -55,7 +55,7 @@ class RewinderAnimationEventHandler : public AnimationEventHandler
public: public:
typedef ::std::function<bool (const AnimationNodeSharedPtr& rpNode)> Action; typedef ::std::function<bool (const AnimationNodeSharedPtr& rpNode)> Action;
explicit RewinderAnimationEventHandler (const Action& rAction) : maAction(rAction) {} explicit RewinderAnimationEventHandler (const Action& rAction) : maAction(rAction) {}
virtual ~RewinderAnimationEventHandler() override {}
private: private:
const Action maAction; const Action maAction;
virtual bool handleAnimationEvent (const AnimationNodeSharedPtr& rpNode) override virtual bool handleAnimationEvent (const AnimationNodeSharedPtr& rpNode) override
......
...@@ -131,8 +131,6 @@ double ScrollTextAnimNode::GetStateAtRelativeTime( ...@@ -131,8 +131,6 @@ double ScrollTextAnimNode::GetStateAtRelativeTime(
class ActivityImpl : public Activity class ActivityImpl : public Activity
{ {
public: public:
virtual ~ActivityImpl() override;
ActivityImpl( ActivityImpl(
SlideShowContext const& rContext, SlideShowContext const& rContext,
std::shared_ptr<WakeupEvent> const& pWakeupEvent, std::shared_ptr<WakeupEvent> const& pWakeupEvent,
...@@ -849,10 +847,6 @@ bool ActivityImpl::enableAnimations() ...@@ -849,10 +847,6 @@ bool ActivityImpl::enableAnimations()
return maContext.mrActivitiesQueue.addActivity( std::dynamic_pointer_cast<Activity>(shared_from_this()) ); return maContext.mrActivitiesQueue.addActivity( std::dynamic_pointer_cast<Activity>(shared_from_this()) );
} }
ActivityImpl::~ActivityImpl()
{
}
void ActivityImpl::dispose() void ActivityImpl::dispose()
{ {
if( !mbIsDisposed ) if( !mbIsDisposed )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment