Kaydet (Commit) fcbdef30 authored tarafından Justin Luth's avatar Justin Luth Kaydeden (comit) Noel Grandin

writerfilter : remove dead code with m_sFootnoteFontName

The string variable is never initialized or set,
and the only use is if it is not empty.

In 2007, author Oliver Specht 2007-06-12 04:41:16 in
range fe8e4e77
introduced m_sFootnoteFontName in a pair of commits.

The call to SetFootnoteFontname() was removed in 2008
with commit 009e3f48

The SetFootnoteFontName() function was removed as unused in
commit 6ea66657

Since the footnote name is never set, it is always
empty, and thus this code is useless.

Change-Id: I64898ce9fa6673fbef0106054b5aa5a817c145d5
Reviewed-on: https://gerrit.libreoffice.org/38257Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 92be65d3
......@@ -1693,12 +1693,6 @@ void DomainMapper_Impl::PushFootOrEndnote( bool bIsFootnote )
pTopContext->SetFootnote( xFootnote );
FontTablePtr pFontTable = GetFontTable();
uno::Sequence< beans::PropertyValue > aFontProperties;
if(!pTopContext->GetFootnoteFontName().isEmpty())
{
PropertyMapPtr aFontProps( new PropertyMap );
aFontProps->Insert(PROP_CHAR_FONT_NAME, uno::makeAny( pTopContext->GetFootnoteFontName() ));
aFontProperties = aFontProps->GetPropertyValues();
}
appendTextContent( uno::Reference< text::XTextContent >( xFootnoteText, uno::UNO_QUERY_THROW ), aFontProperties );
m_aTextAppendStack.push(TextAppendContext(uno::Reference< text::XTextAppend >( xFootnoteText, uno::UNO_QUERY_THROW ),
xFootnoteText->createTextCursorByRange(xFootnoteText->getStart())));
......
......@@ -122,7 +122,6 @@ private:
// marks context as footnote context - ::text( ) events contain either the footnote character or can be ignored
// depending on sprmCSymbol
OUString m_sFootnoteFontName;
css::uno::Reference< css::text::XFootnote > m_xFootnote;
std::map< PropertyIds, PropValue > m_vMap;
std::vector< RedlineParamsPtr > m_aRedlines;
......@@ -156,8 +155,6 @@ public:
void SetFootnote( const css::uno::Reference< css::text::XFootnote >& xF ) { m_xFootnote = xF; }
const OUString& GetFootnoteFontName() const { return m_sFootnoteFontName; }
virtual void insertTableProperties( const PropertyMap* );
const std::vector< RedlineParamsPtr >& Redlines() const { return m_aRedlines; }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment