New loplugin:externvar: i18npool

Change-Id: Id38d1fde0e0f6e08899e83697f586d513b635aad

i18npool/source/collator/chaptercollator.cxx

@@ -73,12 +73,12 @@ ChapterCollator::compareSubstring( const OUString& str1, sal_Int32 off1, sal_Int
     return res1.Value == res2.Value ? 0 : res1.Value > res2.Value ? 1 : -1;
 }
 
-const sal_Char *cChapCollator = "com.sun.star.i18n.ChapterCollator";
+const sal_Char cChapCollator[] = "com.sun.star.i18n.ChapterCollator";
 
 OUString SAL_CALL
 ChapterCollator::getImplementationName() throw( RuntimeException, std::exception )
 {
-    return OUString::createFromAscii(cChapCollator);
+    return OUString(cChapCollator);
 }
 
 sal_Bool SAL_CALL
@@ -90,7 +90,7 @@ ChapterCollator::supportsService(const OUString& rServiceName) throw( RuntimeExc
 Sequence< OUString > SAL_CALL
 ChapterCollator::getSupportedServiceNames() throw( RuntimeException, std::exception )
 {
-    Sequence< OUString > aRet { OUString::createFromAscii(cChapCollator) };
+    Sequence< OUString > aRet { cChapCollator };
     return aRet;
 }
 

i18npool/source/inputchecker/inputsequencechecker_hi.cxx

@@ -99,7 +99,7 @@ static const sal_uInt16 dev_cell_check[14][14] = {
   /* 13 */ { 0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0 }  /* HD */
 };
 
-bool DEV_Composible[2][2] = {
+bool const DEV_Composible[2][2] = {
 /* Mode 0 */    {true, true }, // PASSTHROUGH = 0
 /* Mode 1 */    {false, true}  // STRICT = 1
 };

i18npool/source/inputchecker/inputsequencechecker_th.cxx

@@ -34,7 +34,7 @@ InputSequenceChecker_th::~InputSequenceChecker_th()
 }
 
 /* Table for Thai Cell Manipulation */
-sal_Char TAC_celltype_inputcheck[17][17] = {
+sal_Char const TAC_celltype_inputcheck[17][17] = {
 /* Cn */ /*  0,   1,   2,   3,   4,   5,   6,   7,   8,   9,   A,   B,   C,   D,   E,   F       */
 /* Cn-1 00 */{  'X', 'A', 'A', 'A', 'A', 'A', 'A', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R' },
      /* 10 */{  'X', 'A', 'A', 'A', 'S', 'S', 'A', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R' },
@@ -55,7 +55,7 @@ sal_Char TAC_celltype_inputcheck[17][17] = {
          { 'X', 'A', 'A', 'A', 'S', 'S', 'A', 'R', 'R', 'R', 'C', 'R', 'C', 'R', 'R', 'R', 'R' }
 };
 
-bool TAC_Composible[3][5] = {
+bool const TAC_Composible[3][5] = {
         /*  'A',    'C',        'S',        'R',        'X'   */
 /* Mode 0 */    {true,  true,   true,   true,   true}, // PASSTHROUGH = 0
 /* Mode 1 */    {true,  true,   true,   false,      true}, // BASIC = 1

i18npool/source/nativenumber/nativenumbersupplier.cxx

@@ -813,7 +813,7 @@ sal_Int16 SAL_CALL NativeNumberSupplierService::convertFromXmlAttributes( const
 struct HebrewNumberChar {
     sal_Unicode code;
     sal_Int16 value;
-} HebrewNumberCharArray[] = {
+} const HebrewNumberCharArray[] = {
     { 0x05ea, 400 },
     { 0x05ea, 400 },
     { 0x05e9, 300 },
@@ -920,7 +920,7 @@ static sal_Unicode cyrillicTen = 0x0456;
 struct CyrillicNumberChar {
     sal_Unicode code;
     sal_Int16 value;
-} CyrillicNumberCharArray[] = {
+} const CyrillicNumberCharArray[] = {
     { 0x0446, 900 },
     { 0x047f, 800 },
     { 0x0471, 700 },

i18npool/source/transliteration/ignoreIandEfollowedByYa_ja_JP.cxx

@@ -26,7 +26,7 @@ using namespace com::sun::star::lang;
 
 namespace com { namespace sun { namespace star { namespace i18n {
 
-OneToOneMappingTable_t IandE[] = {
+OneToOneMappingTable_t const IandE[] = {
     { 0x30A3, 0x0000 },  // KATAKANA LETTER SMALL I
     { 0x30A4, 0x0000 },  // KATAKANA LETTER I
     { 0x30A7, 0x0000 },  // KATAKANA LETTER SMALL E

i18npool/source/transliteration/ignoreIterationMark_ja_JP.cxx

@@ -27,7 +27,7 @@ using namespace com::sun::star::lang;
 
 namespace com { namespace sun { namespace star { namespace i18n {
 
-OneToOneMappingTable_t ignoreIterationMark_ja_JP_mappingTable[] = {
+OneToOneMappingTable_t const ignoreIterationMark_ja_JP_mappingTable[] = {
     { 0x3046, 0x3094 },  // HIRAGANA LETTER U --> HIRAGANA LETTER VU
     { 0x304B, 0x304C },  // HIRAGANA LETTER KA --> HIRAGANA LETTER GA
     { 0x304D, 0x304E },  // HIRAGANA LETTER KI --> HIRAGANA LETTER GI

i18npool/source/transliteration/ignoreSeparator_ja_JP.cxx

@@ -21,7 +21,7 @@
 
 namespace com { namespace sun { namespace star { namespace i18n {
 
-OneToOneMappingTable_t ignoreSeparatorTable[] = {
+OneToOneMappingTable_t const ignoreSeparatorTable[] = {
     { 0x0021, 0xFFFF },  // EXCLAMATION MARK
     { 0x0023, 0xFFFF },  // NUMBER SIGN
     { 0x0024, 0xFFFF },  // DOLLAR SIGN

i18npool/source/transliteration/ignoreSpace_ja_JP.cxx

@@ -21,7 +21,7 @@
 
 namespace com { namespace sun { namespace star { namespace i18n {
 
-OneToOneMappingTable_t ignoreSpace_ja_JP_mappingTable[] = {
+OneToOneMappingTable_t const ignoreSpace_ja_JP_mappingTable[] = {
     { 0x0020, 0xffff },  // SPACE
     { 0x00A0, 0xffff },  // NO-BREAK SPACE
     { 0x2002, 0xffff },  // EN SPACE

i18npool/source/transliteration/ignoreTraditionalKanji_ja_JP.cxx

@@ -22,7 +22,7 @@
 namespace com { namespace sun { namespace star { namespace i18n {
 
 // traditional Kanji characters --> modern Kanji characters
-OneToOneMappingTable_t traditionalKanji2updateKanji[] = {
+OneToOneMappingTable_t const traditionalKanji2updateKanji[] = {
     { 0x4E17, 0x4E16 },
     { 0x4E55, 0x864E },
     { 0x4E58, 0x4E57 },

i18npool/source/transliteration/largeToSmall_ja_JP.cxx

@@ -32,7 +32,7 @@ namespace com { namespace sun { namespace star { namespace i18n {
 // http://charts.unicode.org/Web/U30A0.html Katakana (U+30A0..U+30FF)
 // http://charts.unicode.org/Web/UFF00.html
 
-OneToOneMappingTable_t large2small[] = {
+OneToOneMappingTable_t const large2small[] = {
     { 0x3041, 0x3042 },  // HIRAGANA LETTER SMALL A --> HIRAGANA LETTER A
     { 0x3043, 0x3044 },  // HIRAGANA LETTER SMALL I --> HIRAGANA LETTER I
     { 0x3045, 0x3046 },  // HIRAGANA LETTER SMALL U --> HIRAGANA LETTER U

i18npool/source/transliteration/smallToLarge_ja_JP.cxx

@@ -32,7 +32,7 @@ namespace com { namespace sun { namespace star { namespace i18n {
 // http://charts.unicode.org/Web/U30A0.html Katakana (U+30A0..U+30FF)
 // http://charts.unicode.org/Web/UFF00.html
 
-OneToOneMappingTable_t small2large[] = {
+OneToOneMappingTable_t const small2large[] = {
     { 0x3041, 0x3042 },  // HIRAGANA LETTER SMALL A --> HIRAGANA LETTER A
     { 0x3043, 0x3044 },  // HIRAGANA LETTER SMALL I --> HIRAGANA LETTER I
     { 0x3045, 0x3046 },  // HIRAGANA LETTER SMALL U --> HIRAGANA LETTER U

i18nutil/source/utility/oneToOneMapping.cxx

@@ -21,7 +21,7 @@
 
 namespace com { namespace sun { namespace star { namespace i18n {
 
-oneToOneMapping::oneToOneMapping( OneToOneMappingTable_t *rpTable, const size_t rnBytes, const size_t rnUnitSize )
+oneToOneMapping::oneToOneMapping( OneToOneMappingTable_t const *rpTable, const size_t rnBytes, const size_t rnUnitSize )
     : mpTable( rpTable ),
       mnSize( rnBytes / rnUnitSize )
 {

include/i18nutil/oneToOneMapping.hxx

@@ -46,7 +46,7 @@ private:
     oneToOneMapping(const oneToOneMapping&) = delete;
     oneToOneMapping& operator=(const oneToOneMapping&) = delete;
 public:
-    oneToOneMapping( OneToOneMappingTable_t *rpTable, const size_t rnSize, const size_t rnUnitSize = sizeof(OneToOneMappingTable_t) );
+    oneToOneMapping( OneToOneMappingTable_t const *rpTable, const size_t rnSize, const size_t rnUnitSize = sizeof(OneToOneMappingTable_t) );
     virtual ~oneToOneMapping();
 
     // binary search
@@ -56,7 +56,7 @@ public:
     sal_Unicode operator[] ( const sal_Unicode nKey ) const { return find( nKey ); };
 
 protected:
-    OneToOneMappingTable_t *mpTable;
+    OneToOneMappingTable_t const *mpTable;
     size_t                  mnSize;
 };