1. 01 Kas, 2012 20 kayıt (commit)
    • Riccardo Magliocchetti's avatar
      vcl/headless: [HACK] workaround solarMutexx splat with headless mode · 002f8b27
      Riccardo Magliocchetti yazdı
      Apply mmeeks temporary solution until a proper fix is found. With the patch
      applied unoconv testsuite runs fine.
      
      mmeeks analysis of the problem:
      
          It looks really interesting :-) it's hard to tell (from valgrind) where
      the threads were pre-empted [ actually logging that might be quite a
      nice feature to add to for valgrind ;-], but there is already the
      SolarMutex guard to try to stop this from happening.
      
          I append the odd trace with some thoughts.
      
          It is -possible- that we never get around to taking the solar mutex in
      the first instance in 'main' - such that by the time we come to release
      and re-take it in vcl/headless/svpinst.cxx:
      
      void SvpSalInstance::Yield( bool bWait, bool bHandleAllCurrentEvents )
      
          the count is zero - could you add some fprintf debugging to check that
      - just dump nAcquireCount
      
      ==28574== Thread 1:
      ==28574== Invalid read of size 8
      ==28574==    at 0x739C702: SfxStateCache::SetState_Impl(unsigned short, SfxPoolItem const*, unsigned char) (statcach.cxx:454)
      ==28574==    by 0x738042E: SfxBindings::UpdateControllers_Impl(SfxInterface const*, SfxFoundCache_Impl const*, SfxPoolItem const*, unsigned short) (bindings.cxx:1500)
      ==28574==    by 0x7383C5B: SfxBindings::Update_Impl(SfxStateCache*) (bindings.cxx:437)
      ==28574==    by 0x7383FD7: SfxBindings::NextJob_Impl(Timer*) (bindings.cxx:1646)
      ==28574==    by 0x92BF4AD: Timer::ImplTimerCallbackProc() (timer.cxx:142)
      
          The YieldMutex -should- be held at this point excluding this other thread (?).
      
      ==28574==    by 0x95D152D: SvpSalInstance::CheckTimeout(bool) (saltimer.hxx:57)
      ==28574==    by 0x95D17D7: SvpSalInstance::Yield(bool, bool) (svpinst.cxx:288)
      ==28574==    by 0x92B4530: Application::Yield(bool) (svapp.cxx:434)
      ==28574==    by 0x92B45E6: Application::Execute() (svapp.cxx:413)
      ==28574==    by 0x50AED58: desktop::Desktop::Main() (app.cxx:1711)
      ==28574==    by 0x92BDFB8: ImplSVMain() (svmain.cxx:173)
      ==28574==    by 0x92BE8E4: SVMain() (svmain.cxx:210)
      ==28574==    by 0x50E1CF4: soffice_main (sofficemain.cxx:83)
      ==28574==    by 0x40069A: main (main.c:25)
      
      ==28574==  Address 0x1466bdc8 is 56 bytes inside a block of size 72 free'd
      ==28574==    at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387)
      ==28574==    by 0x737F479: SfxBindings::DeleteControllers_Impl() (bindings.cxx:325)
      ==28574==    by 0x7380572: SfxBindings::~SfxBindings() (bindings.cxx:264)
      ==28574==    by 0x7380718: SfxBindings::~SfxBindings() (bindings.cxx:275)
      ==28574==    by 0x758B91E: SfxFrame::DoClose_Impl() (frame.cxx:178)
      ==28574==    by 0x75AAFC1: SfxBaseController::dispose() (sfxbasecontroller.cxx:1041)
      
      sfx2/source/view/sfxbasecontroller.cxx:
      
          This method has a live:
      
                  SolarMutexGuard aGuard;
      
      ==28574==    by 0x16B8E785: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow>  const&, com::sun::star::uno::Reference<com::sun::star::frame::XController>  const&) (frame.cxx:1380)
      ==28574==    by 0x16B8E1CF: framework::Frame::close(unsigned char) (frame.cxx:1633)
      ==28574==    by 0x758BE87: SfxFrame::DoClose() (frame.cxx:140)
      ==28574==    by 0x797F51C: SfxBroadcaster::Broadcast(SfxHint const&) (brdcst.cxx:49)
      ==28574==    by 0x7511211: SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (objxtor.cxx:173)
      ==28574==    by 0x7534972: SfxBaseModel::close(unsigned char) (sfxbasemodel.cxx:1491)
      ==28574==    by 0x1E776909: SwXTextDocument::close(unsigned char) (unotxdoc.cxx:578)
      ==28574==    by 0x7537FB0: SfxBaseModel::dispose() (sfxbasemodel.cxx:788)
      ==28574==    by 0x1211D6E7: gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, unsigned int, double*, unsigned int) (callvirtualmethod.cxx:128)
      ==28574==    by 0x12120FEE: cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (uno2cpp.cxx:246)
      ==28574==    by 0x12121ACD: bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (uno2cpp.cxx:440)
      ==28574==    by 0x15D5CE5E: binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny>  >*) const (incomingrequest.cxx:251)
      ==28574==    by 0x15D5D8AB: binaryurp::IncomingRequest::execute() const (incomingrequest.cxx:80)
      ==28574==    by 0x15D61B4C: request (reader.cxx:89)
      ==28574==    by 0x663A506: cppu_threadpool::JobQueue::enter(long, unsigned char) (jobqueue.cxx:115)
      ==28574==    by 0x663B00D: cppu_threadpool::ORequestThread::run() (thread.cxx:179)
      ==28574==    by 0x663B4E9: threadFunc (thread.hxx:196)
      ==28574==    by 0x4E467AE: osl_thread_start_Impl (thread.c:261)
      ==28574==    by 0x5E53EFB: start_thread (pthread_create.c:304)
      ==28574==    by 0x5B8E89C: clone (clone.S:112)
      
      Change-Id: I84aea49aff1dbc6c0d34e522d57d5af90eebfc62
      002f8b27
    • Caolán McNamara's avatar
      Resolves: fdo#54466 right-aligned label text slightly clipped on right · e217fc45
      Caolán McNamara yazdı
      aae8a0c8 with rather unhelpful
      "#99188# enlarge textrect to get rid of rounding problems" comment
      appears to be the root. Lets assume that commit is necessary and
      just adjust alternatively for right align
      
      Change-Id: I0b60c12199226ca757596c034599b81c1a4db433
      e217fc45
    • Kohei Yoshida's avatar
      Unit test for cache filtering, to secure the recent bug fix I did. · 10742e6e
      Kohei Yoshida yazdı
      Change-Id: Ie5068b45520b6c82af41062d97ec65d006b4b3ba
      10742e6e
    • Julien Nabet's avatar
      Revert cf0453d9 · 5bc36d13
      Julien Nabet yazdı
      After having talked about on IRC with Michael Meeks, it seems UX team prefers that way.
      In brief, it was on purpose. Thank you Michael for your time
      
      Change-Id: Ib99425a212ac5463b0465e1e755e2537bb4d51b8
      5bc36d13
    • Marcos Paulo de Souza's avatar
      Remove unused method in formula module · 4e0b79b5
      Marcos Paulo de Souza yazdı
      Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921
      Signed-off-by: 's avatarMarcos Paulo de Souza <marcos.souza.org@gmail.com>
      4e0b79b5
    • Caolán McNamara's avatar
      another some more regression tests · cd11b9f2
      Caolán McNamara yazdı
      Change-Id: Ic13269fcf55b4e51a8124da6d2de75fb5bec23e0
      cd11b9f2
    • Caolán McNamara's avatar
      add .odg regression load test · a6e4a841
      Caolán McNamara yazdı
      Change-Id: I5f7dc2a389c020a90b8087aefc90c054a809ef25
      a6e4a841
    • Caolán McNamara's avatar
      rework filters test to squeeze through extra flags · c2913591
      Caolán McNamara yazdı
      that are needed to load .odt, .sxw etc files, and
      add a regression test for CVE-2012-4233
      
      Change-Id: Ie178725ded3d76942030d12f23074de519cf62de
      c2913591
    • Caolán McNamara's avatar
      XubString->OUString · 2ffd82c3
      Caolán McNamara yazdı
      Change-Id: Iea7d8681cdcd45d545826af63fc689640dfe29f0
      2ffd82c3
    • Caolán McNamara's avatar
      valgrind: Conditional jump or move depends on uninitialised value · 5346394e
      Caolán McNamara yazdı
      Change-Id: I7b59ddc4f9170c33e948f30194a662f27b871fcc
      5346394e
    • Tor Lillqvist's avatar
      Don't let NSS use the MSVC debugging runtime in an --enable-debug build · 57fb462c
      Tor Lillqvist yazdı
      In an MSVC build, not exporting BUILD_OPT to the Mozilla build
      machinery causes the produced DLLs to use the debug CRT. The exact
      mechanism is a bit of a mystery, and I didn't feel like spending too
      much time trying to understand it.
      
      Using the debug CRT is confusing and wrong. Nothing in LO otherwise
      uses it. It also makes testing a build much harder for me at least, as
      I do that in a fairly pristine virtual machine with no MSVC debugging
      runtime available. (The normal CRT is bundled in the LO installer.)
      
      Change-Id: I27f774d92a3986d40162c870202bcdddd94aa7c6
      57fb462c
    • Caolán McNamara's avatar
      add test for EBD-22330 · 33781373
      Caolán McNamara yazdı
      Change-Id: Ifd59198a2d09e26377267c8b509c5340d83240e3
      33781373
    • Kohei Yoshida's avatar
      Rename the files to reflect the class name change. · 507cf0c4
      Kohei Yoshida yazdı
      Change-Id: I6223cd12ab539cd19555c0b23f2bce73f519a31f
      507cf0c4
    • Kohei Yoshida's avatar
      Rename ScDPCacheTable to ScDPFilteredCache. · 2a2a2c42
      Kohei Yoshida yazdı
      I always wanted to do this.  The new name reflects what it really does
      better than the old one.
      
      Change-Id: I3c90cce06d482f1453936ff3916eef9663bb417b
      2a2a2c42
    • Kohei Yoshida's avatar
      Since the cache there is never NULL, let's take a reference instead. · 6a06befd
      Kohei Yoshida yazdı
      Change-Id: Idd3ca250ea51c9e17b4566febf13d9c8ca9c6a8f
      6a06befd
    • Kohei Yoshida's avatar
      The cache inside ScDPCacheTable (I should rename this) is never NULL. · 8617c5a2
      Kohei Yoshida yazdı
      There is no point of having hasCache() method which always returns true.
      
      Change-Id: I309d3c33899cdab2049af5199ae8d41f7cbd5f99
      8617c5a2
    • Kohei Yoshida's avatar
      These comments are no longer correct. · 6c2c3553
      Kohei Yoshida yazdı
      They were correct up until IBM re-worked a whole bunch of stuff during
      the OOo 3.2 (?) development cycle.
      
      Change-Id: Ia9a9e30287f6c8451a6cfa98f3515d703e3c67cc
      6c2c3553
    • Takeshi Abe's avatar
      sal_Bool to bool · 30342660
      Takeshi Abe yazdı
      Change-Id: I10f8d534d664c5f27a32214c00aeee890d993d18
      30342660
    • Kohei Yoshida's avatar
      fdo#56627: Handle empty cell values separately in filters test. · a05cfc07
      Kohei Yoshida yazdı
      Perhaps this will make valgrind happy?
      
      Change-Id: I11f965d13f8d71b2ab9f9624367fd70713644f10
      a05cfc07
    • Kohei Yoshida's avatar
      Use 'e' prefix for enum values. · 117e87ff
      Kohei Yoshida yazdı
      Change-Id: Iae3eceb38a6f9bc53805445799534ec8ee44a9a9
      117e87ff
  2. 31 Eki, 2012 20 kayıt (commit)