1. 07 May, 2014 34 kayıt (commit)
  2. 06 May, 2014 6 kayıt (commit)
    • Chris Sherlock's avatar
      VCL: make it more clear that this is a static function we are calling on · 87f33f6f
      Chris Sherlock yazdı
      Change-Id: Ic7ac1a1bc3ac3901c844ee6e1c59a1518043f761
      87f33f6f
    • Chris Sherlock's avatar
      Move ImplInitAppFontData from Window to Application (take 2) · 081a0854
      Chris Sherlock yazdı
      I have renamed ImplInitAppFontData to InitAppFontData and moved it from
      Window to Application. This is because this is something that sets
      *application* global variables, it just so happens it gets it from a
      Window parameter. But it should be set when the application starts, so I
      have moved it to Main().
      
      This was previously reverted, but I have since located what was causing
      unit tests to fail and the font dropdowns to stop loading in writer:
      see commit c6d7ba5f33c3 where Application::SetSettings() was setting
      pImplSVData->maGDIData.mnAppFontX to zero.
      
      Change-Id: I5da7073b0d8541f1a71a09b0a8337d012fc4134b
      081a0854
    • Chris Sherlock's avatar
      VCL: Application::SetSettings should not set mnAppFontX to 0 · ef31acfd
      Chris Sherlock yazdı
      pImplSVData->maGDIData.mnAppFontX is *not* a flag to determine if
      application font dimensions should be reset. The way it currently works
      is:
      
      1. Application::SetSettings() is called to reset Window settings,
      etc.
      
      2. Settings are updated on all windows - but at the same time
      pImplSVData->maGDIData.mnAppFontX is set to zero as a way of indicating
      to the global function ImplCalMapResolution that we need to get the font
      from the first window, or if this isn't available then create a new dummy
      WorkWindow and use this to get the font data, and set the application
      font to this.
      
      This is very odd. What we really should be doing is calling on
      ImplInitAppFontData directly from within SetSettings() instead of making
      ImplCalcMapResolution detect that mnAppFontX is zero and there is a
      valid first frame window.
      
      Ultimately, this was found when I commited f76026a4 to move
      ImplInitAppFontData from Window to Application. Somehow I entirely missed
      that the font and style dropdowns in writer died, and I also somehow
      a whole bunch of tests failed but I again didn't notice this either. With
      this fix, I should be able to recommit the previous change.
      
      Change-Id: Ib526954962fdc397fb3ddd3c21ae947d939db9e5
      ef31acfd
    • Chris Sherlock's avatar
      Use css alias in svapp.hxx · 20144988
      Chris Sherlock yazdı
      Change-Id: Ifffcf30f68aa4486e22211d9dfc5ad6d77346a85
      20144988
    • Chris Sherlock's avatar
      Indent svapp.hxx functions · deba6ec8
      Chris Sherlock yazdı
      Change-Id: Ibc7262921173036297c670fda3c68c6d77b9853e
      deba6ec8
    • Kohei Yoshida's avatar
      fdo#77990: Write test for this, using the 2nd test document submitted. · 740dac4d
      Kohei Yoshida yazdı
      Change-Id: I70d71bb21ff43aeb49339ff1f1d9e73c923e0201
      740dac4d