Change-Id: I4606e5a3717c3717d105dd2e63c9fd7d2e1abf83

* Update helpcontent2 from branch 'master'
  - Improve scripts legibility for Python newbies
    
    Change-Id: I6adee2c58d4030c433a9fdf0c070069264564742
    Reviewed-on: https://gerrit.libreoffice.org/67439
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

fixes CVE-2018-16890 and CVE-2019-3822

Change-Id: I4c0021a5002590659cbfbdf642a7704a05309bf2
Reviewed-on: https://gerrit.libreoffice.org/67444
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

The userformscontainers is required property to pass checks in
getter/setter, but returning true instead of actual type is
not a best idea. So let's return actually expected dummy empty
container.

Change-Id: I5cc3e5462ed82f6f2f8e5a45d9fc2d9f9ce1c76f
Reviewed-on: https://gerrit.libreoffice.org/67431
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...where <hostname> matches whatever osl_getLocalHostname reports.  (And, for
simplicity, don't support variations where e.g. one of the two FQDNs has an
optional final dot while the other has not.)

(It is not clear to me whether a similar change should also be done for the
Windows-specific code in sal/osl/w32/file_url.cxx.  On Windows, file URLs with a
host component are generally interpreted as UNC pathnames, and in some local
test on a Windows 8 machine whose hostname is reported as "win8", passing a URL
like <file://win8/Users/me/Documents/...> (i.e., without a C: drive letter) to
LO already worked to access files on the default drive C: at least.)

Change-Id: I7a69b6d4ca76a71223def7b90d7c3b8b731ee86d
Reviewed-on: https://gerrit.libreoffice.org/67437
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I61c2ee1e8363a022239d5572e3506df9da0d5e1d
Reviewed-on: https://gerrit.libreoffice.org/67433Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins

Change-Id: I2faa8c971dc7f4642353dceafa25b9022a0dfd2a
Reviewed-on: https://gerrit.libreoffice.org/67436
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id58f692168274a942d2b976f10885341dfe63ac3
Reviewed-on: https://gerrit.libreoffice.org/67434
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5fd636ce03b5ff47ff5e9263203a882bff7f21f5
Reviewed-on: https://gerrit.libreoffice.org/67430
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I5c63c28ba4c63e17b74e656d5382d45c9fcc6baa
Reviewed-on: https://gerrit.libreoffice.org/67428
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I7e2fd41f8c4359374af143aaf7544bb61a8878c7
Reviewed-on: https://gerrit.libreoffice.org/67189Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I26959d3604a581f1528e575239970ab364c7fd50
Reviewed-on: https://gerrit.libreoffice.org/67413
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3df754c58c90978ef5fccc90518ad1af92516a9e
Reviewed-on: https://gerrit.libreoffice.org/67404
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1ba3434d13b8976ee80a8c45c137dccf27cecac7
Reviewed-on: https://gerrit.libreoffice.org/67432
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

settings to keep interoperability, use only cell
properties, as MSO.

Change-Id: I167eb0e8732fa7dc7f890c2a21d59a15299be8ba
Reviewed-on: https://gerrit.libreoffice.org/67429
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: Idff8a0589075c8b7c774f187f5082fd954251d77
Reviewed-on: https://gerrit.libreoffice.org/67420
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Follow-up of a7da5945

Change-Id: I7e252f9a881b2ac1098bc21bd193f66d32404056
Reviewed-on: https://gerrit.libreoffice.org/67423
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

The Linux-only conversion of file URLs with a non-empty (other than "localhost")
authority to smb URLs had been added in 2010 with
0b9ef81b "tools-urlobj-smb-scheme-patch.diff:
migrated" (applying a Go-oo patch?) but giving no rationale beyond "process
relative SMB paths (in hyperlinks) correctly".  That makes it hard to tell
whether that patch is (still) actively useful for anything, or was just a
misguided hack from the beginning:

* Why make this Linux only?  What about other non-Windows OSs?  (On Windows,
  such URLs can be resolved as UNC pathnames.)  If the reason for Linux-only was
  that it is the only OS where LO can handle smb URLs via GIO, why not make it
  conditional on ENABLE_GIO?

* Why map to smb?  There are various remote file access protocols.  Hardcoding
  smb looks arbitrary here.

Anyway, INetURLObject is arguably at a wrong level for such a patch.  To not
drop the hack wholesale, reimplement it in the file UCP, forwarding to a
potential other UCP that can handle smb URLs any file://<host>/... URLs
(rewritten as smb URLs) that the file UCP cannot handle itself.
(file://localhost/... URLs will already have been normalized to file:///... by
INetURLObject when they reach the file UCP, and even if they were not, the
osl/file.hxx functionality underlying fileaccess::TaskManager::getUnqFromUrl
knows how to handle them, so they will not take the forward-to-smb code branch.)

(The corresponding #ifdef WIN code from 0b9ef81b
has already been removed with 82034b04
"tdf#119326 crash when adding "Windows Share" File resource".)

(I came across that 2010 patch while looking into
<https://bugs.documentfoundation.org/show_bug.cgi?id=107461> "Does not support
'file://' scheme with actual hostname".  A next step would be to make the file
UCP actually handle any file://<host>/... URLs that denote the local host.)

Change-Id: I77242705dc4c6c1e9cb3a4f32253224ac6cb13cb
Reviewed-on: https://gerrit.libreoffice.org/67372
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ia706cce2a3eaba597f0d8b9cd3cf9ca2e9e8e49f
Reviewed-on: https://gerrit.libreoffice.org/67421
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Partially revert commit 36aa3f4d

Change-Id: Ia554d3e64da2ee620c69bc66b33a6cd305502c64
Reviewed-on: https://gerrit.libreoffice.org/67418
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I73c5aa3694d2580b707c2ce769e3e9ffbc076ec8
Reviewed-on: https://gerrit.libreoffice.org/67406
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This is similar to commit f1e77547
(framework: allow storeSelf() on the main thread, 2019-01-30), just this
handles "save as" instead of "save".

The result is that combining this commit with the previous OnMainThread
ones allows all of document load/save/save-as/command-dispatch on the
main thread even when the action is invoked via remote UNO, which would
run on a non-main thread by default.

Change-Id: I7d50cceb66ecc6619fe25734107a2524ca872c2a
Reviewed-on: https://gerrit.libreoffice.org/67412Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I7defc08f6ce2a25f33839c5e8f76548d78443410

Change-Id: I8e0f4e2042901b8f6bbc6e1358ca8ab5dae446ce

Store the file extension associated with the named
filters in a map, and use that information to
set the default file extension in QFileDialog
accordingly if the corresponding checkbox in the dialog
is enabled.

Change-Id: I66f4f35da5d4378ac6337429e39260a4ed710a24
Reviewed-on: https://gerrit.libreoffice.org/67392
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

This patch removes the check for a footer node,
intoduced by
23f698ec
preserving the behaviour for the connected bug reports
i13832 and i24135.

Without this check, the wraping becomes enabled for footer
objects, too.

With this enhencement, the commits
7df33caa
d3db6ff4
are directly affected and therefore the unit test is edited.

Change-Id: I093add9e251ac97859a66cb8b8563010ef734c2d
Reviewed-on: https://gerrit.libreoffice.org/67069
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I66ca5113054862f1549a3d7c27da70cf4f5fc308
Reviewed-on: https://gerrit.libreoffice.org/67403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I826a43b36e35f9145c971b3608b6f56d27ff5f81
Reviewed-on: https://gerrit.libreoffice.org/67405
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Commit 11a2809e follow-up

Change-Id: Id70a95f46655ade3b867e0377ddd5bee13993187
Reviewed-on: https://gerrit.libreoffice.org/67402
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Includes unit tests for correctness of the new functionality.

Change-Id: I35f7449006d973de006a756664ae468b9a0dcb31
Reviewed-on: https://gerrit.libreoffice.org/66841
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

since...

commit 18bb85aa
Date:   Sat Jan 12 12:04:04 2019 +0100

    make SwFormat a ::sw::BroadcastingModify

    - clean up SwSection..Hint: Lazily reusing the Dying HintId is evil
    - switch the SwChartDataSequence to SvtListener
    - add some description to RuntimeException

Change-Id: I1a83c3d11b8b05699f05e812bc021daa6fadb76a
Reviewed-on: https://gerrit.libreoffice.org/67394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1e23f382e343d73a0d28ad0b88b0dc31fb75008d

no need to store elements of vector on the heap

Change-Id: I314372b8f81b117c07676263c0c3481b51374f33
Reviewed-on: https://gerrit.libreoffice.org/67397
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...returning a non-dotted result obtained from gethostname in case trying via
osl_createHostAddrByName doesn't work either.  The code had been like this ever
since its introduction with 74f3ed51 "made
socket and pipe refcounted, added blocking read write methods, added direct
access methods for struct sockaddr", but there appears to be no good reason not
to return the non-dotted gethostname value as a fallback (and it may just have
been an oversight not to do so; and on e.g. Linux we simply return whatever a
successful call to gethostname provides, be it dotted or not, ever since at
least ebd00f5c "socket.cxx -> socket.c", too).

(Calls to osl_getLocalHostname are few across the code base, so this change in
behavior is unlikely to cause any regressions.  I came across this wile looking
into <https://bugs.documentfoundation.org/show_bug.cgi?id=107461> "Does not
support 'file://' scheme with actual hostname", but this change is unrelated to
any potential fix for that issue.  It just felt right to get this fixed in
passing.)

Change-Id: I78e59140579b9d37ee435a8f121e58544d2235eb
Reviewed-on: https://gerrit.libreoffice.org/67390
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

No "PRIMARY KEY" keyword is needed, when composing a parsed sql which
did not contain any primary key definition.

Change-Id: Ife8b898806edba41a52d47dc04b1170606ea8aae
Reviewed-on: https://gerrit.libreoffice.org/67379
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

This takes over the fix from the KDE5FilePicker
from commit 1af4ab72
for the qt5 one.

Change-Id: Ibe34ecff9913fc91df2b9bd25b559375bab0ff83
Reviewed-on: https://gerrit.libreoffice.org/67385
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Change-Id: I0abe538f37ffe6bb9b3fe0873abbf636ed0a4974
Reviewed-on: https://gerrit.libreoffice.org/67377
Tested-by: Jenkins
Reviewed-by: Oliver Specht <oliver.specht@cib.de>

This was added in commit 2fcf3a87
(ooxml: preserve gradient shape fill, 2014-01-31), and assumes that the
theme colors can be preserved, as the theme definition is grab-bagged as
well.

But the theme is grab-bagged only for DOCX, not for PPTX, so skip
gradient grab-bag for PPTX, otherwise the gradient would refer to
incorrect colors in the theme.

Change-Id: I98e1c67d4b10e68916f81dd7fc508eb4146d506b
Reviewed-on: https://gerrit.libreoffice.org/67386Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

This reverts commit 3d8c1598, and
instead, checks if the MtaOleReq window is not destroyed yet, in
addition to the wait for the condition. This allows to avoid wait
forever for condition which never gets signalled, and process the
sent messages when waiting.

The window's WM_DESTROY handler sets the event signalling that.
The Win32Condition's wait() is changed to take the abort event,
and return true if its own event fired, and false if abort event
fired.

Change-Id: I1861dd3dabb39329976a3ccf2a5392c9ddbf9613
Reviewed-on: https://gerrit.libreoffice.org/67383
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Iae3f4f1acfca02daa66726da3434ffb4406ff71d
Reviewed-on: https://gerrit.libreoffice.org/67380
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>