Change-Id: Ib48999c7fe532b2a8bf5222ef27d8d4929937e3b

Change-Id: I65499ac299fb474e581245c5237a0b184f1f2b60

Change-Id: I268f6d2577b727c6aa072ee766b3f5f41bdb131b

Change-Id: I259bf6012684e393765cfd73e813bcf2875abd5f

Ideally now all testcases handle both cases during DOCX import:

- current situation, when shape with text is imported as a Writer
  TextFrame
- future situation, when shape with text will be imported as shape with
  an assicated TextBox

Change-Id: I5b95ff4672cecf39eb744f8557f967ade73404c0

Change-Id: Ic2799c029c26dcd18a482b51f53248ef1c4b569a

In general Writer supports having objects inside a TextFrame, Word does
not. It turns out that Word allows having certain shapes inside other
shapes, as long as they are VML-only. So do that for now: if we receive
a shape when we're already inside a shape, then just export it as VML,
not the usual drawingml+VML pair.

Also, blacklist one more VML shape type, where the shape text is already
exported inside <v:textpath>, so no dedicated <v:textbox> is needed.

Change-Id: I5786bd6827eae9756e7c179bb2ef5a5741a91878

Change-Id: Icadf4b44377684e40334c52887883320805a8e89

Change-Id: I987f727ec1cd3927239a9339144274f2eea63e36

These are all dependent on the active \lrtch \rtlch \loch \hich \dbch.

There does not appear to be a SPRM Id for CJK bold / italic / fontsize.

Change-Id: I055ac29700ccd3b32b02c3f7685629254a6c3fd6

Change-Id: I445303e52fbfaa58e68c01970e21941537484506

Change-Id: If5e53ca72fc3b90435d95b50c5c796ec0ff04869
Reviewed-on: https://gerrit.libreoffice.org/9790Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5af0b84ff4a85e72f5068d450a04d01df0592d3b

Project: help  750ac4767a4aede59d119fc57d3c5a934398b1aa

Change-Id: I8e19c29c47dea2f7cff754e81ef51fc9898fdee8

Change-Id: I6967a3c871338d1801d913d9bb54eba50a7660ca

it's not handling resizing and redrawing well, so just drop
it in favour of a read-only edit

Change-Id: I5e6f85cf9326b908bf1bf835d8da0c49ca9209c9

Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8
Reviewed-on: https://gerrit.libreoffice.org/9797Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iaf4e34007d7822705a278a94138572b0379b2779

It would certainly be immediately obvious to any reader of the RTF spec
that \sN will apply the style with index N to the current paragraph.

But actually, that is not what Word does when it reads \sN...
what it really does is to apply the style with index N, and then for
every attribute in that style, apply the same attribute with a default
value to the paragraph, effectively overriding what's in the style.

If that doesn't make any sense to you, well, have you heard the joke
about how many Microsoft engineers it takes to change a light bulb?

Also, \pard apparently implies \s0.

To implement that, change RTFSprms::deduplicate() to recursively
look for style SPRMs that are missing in the properties, and put
in default ones, currently just for 2 keywords \sa and \sb.

This requires changing deduplicate() to be const and return a new value,
since it is no longer idempotent, as the erased SPRMs would get
defaulted on the next run.

While at it, fix RTFValue::equals() which did not compare m_sValue.

This fixes the testParaBottomMargin test that was broken by the fix
for fdo#70578.

Change-Id: I4ced38628d76f6c41b488d608a804883493ff00b

quoth the spec:

"For <style>, both <styledef> and <stylename> are optional; the default
is paragraph style 0."

Of course in order to do that we need to add support for at least
recognizing the \dsN and \tsN keywords to override the default, so that
table styles don't become paragraph styles.

Change-Id: Ic100768581f9e8c327063ff776fbd61ac4242483

Change-Id: I2b6f33eaf12343c7da1328a932eb703bb4e4ef6f

CppunitTest_sw_ooxmlsdrexport's testAnchorIdForWP14AndW14 would fail
without this, when "shape with text" is imported as "shape with
textbox".

Change-Id: I8705aee16270aa68416f0c830c429880fc76d85d

Change-Id: Ic63372285fecb6f1be22e92c36cdb6f94733f5c1

For large documents we create and destroy a large number of non-poolable
SfxPoolItems, which get inserted into and removed from a vector.
Unfortunately the performance of this (depending on pattern) is O(N) and
this insert/remove/extend pattern can happen per text span we insert.
This patch makes this O(const) via a hash. This gives a 5x speedup for
the above bug; 176s to 34s or so, and moves the remaining performance
issues elsewhere.

Unfortunately, we have to retain the ordered array to keep the binary
file format code (used for editeng cut-and-paste) in place, so have to
keep both a hash, and an array, and a list around for free slots. cf.
fdo#79851 where there is a start at removing that.

This wastes space; but not that much - for a large open document
collection we have O(100's) of SfxItemPools, and O(1000's) of
SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this.

Add skeletal unit test; translate several German comments; remove
un-necessary include.

Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531

...no reason to not have it enabled for URE C include files and what
little real C code is still left.  (But note that Clang ignores that
warning.)

Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6

Change-Id: I1bfdd865429cc6fa89ea3b6b4fc132b5d5b57b0d

Change-Id: I80fd6b112134ab2b0e4a592f60a21c7c177b4b01

Change-Id: Id0a13af0c0d1aa0b6a21edde0ec7f97730a1c912

Change-Id: Icb1ba7f7068f60c4bd5eda7002415214b3d885f3

  
Change-Id: I2b932c9f09a010a4f999707fb6299c392a89550a
Reviewed-on: https://gerrit.libreoffice.org/9806Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>

Change-Id: I2590bd8b0d0c1d853caead60cf3af1b865d7fed7
Reviewed-on: https://gerrit.libreoffice.org/9805Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>

... which should be freed even if GetError() != 0

Change-Id: Ifbf72aa17f8bcbdcc3b1504a105aa32e94397ee3
Reviewed-on: https://gerrit.libreoffice.org/9807Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

also

coverity#983450

Change-Id: I43f88005ab130f74df2316f51ab898b112002044

also

coverity#736888
coverity#736889
coverity#736890

Change-Id: I3e0d11d12c7da17297ba827f8125b9d99680121b

Change-Id: I8e6a81b6c1605bd1be33f5f8d75d2472a39361d4

Change-Id: I69df0aa6091263cbb6e500a5015915c6678764ec

Change-Id: Idb9c4aa6475fcd9edd0d76c06509df182bd2111c

also

coverity#706048

Change-Id: I93caf413db4582c8b2cdfbcf2358027c03ed113a

also

coverity#706042
coverity#706045
coverity#706046

Change-Id: I173603a638ef3e2d9ca358a4d4ba111910fac05f