Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 03 Ara, 2018 18 kayıt (commit)
    • Arkadiy Illarionov's avatar
      Simplify containers iterations in sdext · 05684540
      Arkadiy Illarionov yazdı 
      Use range-based loop or replace with STL functions

Change-Id: I760c1aaeae9afc99effee6a2645bb77439260ddf
Reviewed-on: https://gerrit.libreoffice.org/64435
Tested-by: Jenkins
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      05684540
    • Ashod Nakashian's avatar
      sw: paragraph-sign: formatting · 83a72f46
      Ashod Nakashian yazdı 
      Change-Id: I9bf1b58aa6e18202a5f7eba010cc5b914e1d33d4
Reviewed-on: https://gerrit.libreoffice.org/63005
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      83a72f46
    • Ashod Nakashian's avatar
      sw: paragraph-sign: validate current SwTextNode directly · 6ad096ae
      Ashod Nakashian yazdı 
      When invoking undo, it turns out that the cursor position
is updated after the text modification, which triggers the
paragraph signature validation. Relying on the cursor
position, then, results in the wrong (previous) paragraph
to be validated (if the undo is in a different paragraph).

Since we have the correct SwTextNode when it's modified
(due to undo or otherwise), there is no reason why
we shouldn't use it and try to deduce it from the cursor.

Change-Id: I4c3283d59738988dcc1c592a9f3ef2c818ce675d
Reviewed-on: https://gerrit.libreoffice.org/63004
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      6ad096ae
    • Ashod Nakashian's avatar
      sw: paragraph-sign: get graph-names only once · 3750d053
      Ashod Nakashian yazdı 
      And reduce other overheads to make the paragraph
signature validation significantly faster.

Change-Id: I631bd0f15200bb8f0b85b40c0d4819a7bc4d562e
Reviewed-on: https://gerrit.libreoffice.org/63003
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      3750d053
    • Ashod Nakashian's avatar
      paragraph-sign: exception-safe metadata graph enumeration · 1c17aa50
      Ashod Nakashian yazdı 
      Metadata graph enumeration can throw from a number
functions and break things in horrible ways.
Here we sanitize against the most egregious offenders,
but not all possible sources.

Change-Id: I40e006ea433dd7274d4fa08f3e8f8507680ef2f4
Reviewed-on: https://gerrit.libreoffice.org/63009
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      1c17aa50
    • Ashod Nakashian's avatar
      sw: rdf: Split graph-name lookup from getStatement · 7ddfd67e
      Ashod Nakashian yazdı 
      The graph-name lookup is significantly costly (compared
to the statement lookup, esp. when no statements exist).
Luckily, the graph-names do not change often and in the
course of enumerating all paragraphs (as happens for
paragraph-signature validation) it doesn't change at all.

This split allows for doing the graph-name lookup only
once and also allows for passing custom graph-names
directly, if we know them already.

Change-Id: I75425df201becb41105ba1fa6ba580af202d035c
Reviewed-on: https://gerrit.libreoffice.org/63002
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      7ddfd67e
    • Ashod Nakashian's avatar
      sfx2: Combine metadata graph lookup and filtering · 8c84672e
      Ashod Nakashian yazdı 
      The graph lookup is suprisingly costly and so is
filtering. By specializing the lookup with filtering
the logic is more readable and slightly faster (~35%
in debug build).

Change-Id: Id35a562c76a84a81362f47b61ed67fb74d0a6dc7
Reviewed-on: https://gerrit.libreoffice.org/63001
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      8c84672e
    • Ashod Nakashian's avatar
      sw: paragraph-sign: erase metafields from copied text correctly · b402d011
      Ashod Nakashian yazdı 
      This is relevant for paragraph signatures where the
metadata is not yet copied and so we exclude it.
The issue was that in some cases we didn't use
the proper range of text and an assertion was
triggered in debug builds.

Otherwise there should be no change of behavior
in release builds with this patch.

Change-Id: I90bc2ca56d586b96d39f34c68de53d3dac6099d7
Reviewed-on: https://gerrit.libreoffice.org/63000
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      b402d011
    • Ashod Nakashian's avatar
      sw lok: delay processing idle jobs to let LOK finish initialization · 349748e6
      Ashod Nakashian yazdı 
      When loading document, LOK needs to setup the client view, register
callbacks, get document size and type, etc. All of these need
to take SolarMutex, which is taken by the idle jobs immediately
after loading, blocking LOK from finishing initialization
and rendering the first tiles for the user. This gives the
user the impression that the document is loading for far
longer than it actually is, due to lack of interactivity
(or indeed any activity on the screen besides the spinning wheel).

By delaying the idle jobs, we allow time for LOK to finish
initialization and render the first tiles before the idle
jobs kick in and hog SolarMutex.

Reviewed-on: https://gerrit.libreoffice.org/56572Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
Tested-by: 's avatarJan Holesovsky <kendy@collabora.com>
(cherry picked from commit 1056640a)

Reviewed-on: https://gerrit.libreoffice.org/58157Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
Tested-by: 's avatarJan Holesovsky <kendy@collabora.com>
(cherry picked from commit e5225f15)

Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae
Reviewed-on: https://gerrit.libreoffice.org/64013
Tested-by: Jenkins
Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
      349748e6
    • Stephan Bergmann's avatar
      Compute (un-)premultiply_table at compile time · 644188bf
      Stephan Bergmann yazdı 
      Change-Id: I34e624fcd5d11d02c26e775f5acdddec1fca9d87
Reviewed-on: https://gerrit.libreoffice.org/64428
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      644188bf
    • Andrea Gelmini's avatar
      Fix typo · 1ee8d4f6
      Andrea Gelmini yazdı 
      Change-Id: I69e4d471c806159d6748016a79f041c01b40b888
Reviewed-on: https://gerrit.libreoffice.org/64430
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      1ee8d4f6
    • Jens Carl's avatar
      tdf#45904 Move XElementAccess Java tests to C++ · cee3278a
      Jens Carl yazdı 
      Move XElementAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8
Reviewed-on: https://gerrit.libreoffice.org/64432
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      cee3278a
    • Jens Carl's avatar
      tdf#45904 Move XIndexAccess Java tests to C++ · 184d0c4b
      Jens Carl yazdı 
      Move XIndexAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: I448561be2395beb9448ffcfc29434a94468166cb
Reviewed-on: https://gerrit.libreoffice.org/64431
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      184d0c4b
    • Mike Kaganski's avatar
      Fix JunitTest_chart2_unoapi failing DBG_TESTSOLARMUTEX on Windows · a0ac944b
      Mike Kaganski yazdı 
      The failing call stack:

ucrtbased.dll!issue_debug_notification(const wchar_t * const message) 
Line 28
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
	at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const 
expression, const wchar_t * const file_name, const unsigned int 
line_number) Line 187
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(187)
ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, 
const wchar_t * const file_name, const unsigned int line_number, void * 
const return_address) Line 420
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(420)
ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * 
file_name, unsigned int line_number) Line 444
	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(444)
vcllo.dll!ImplDbgTestSolarMutex() Line 46
	at c:\lo\src\core\vcl\source\app\dbggui.cxx(46)
tllo.dll!DbgTestSolarMutex() Line 78
	at c:\lo\src\core\tools\source\debug\debug.cxx(78)
vcllo.dll!OpenGLSalBitmap::Create(const Size & rSize, unsigned short 
nBits, const BitmapPalette & rBitmapPalette) Line 164
	at c:\lo\src\core\vcl\opengl\salbmp.cxx(164)
vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, unsigned short 
nBitCount, const BitmapPalette * pPal) Line 108
	at c:\lo\src\core\vcl\source\bitmap\bitmap.cxx(108)
vcllo.dll!o3tl::make_unique<Bitmap,Size &,unsigned short &>(Size & 
<args_0>, unsigned short & <args_1>) Line 29
	at c:\lo\src\core\include\o3tl\make_unique.hxx(29)
vcllo.dll!vcl::PNGReaderImpl::ImplReadHeader(const Size & 
rPreviewSizeHint) Line 665
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(665)
vcllo.dll!vcl::PNGReaderImpl::GetBitmapEx(const Size & rPreviewSizeHint) 
Line 342
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(342)
vcllo.dll!vcl::PNGReader::Read(const Size & i_rPreviewSizeHint) Line 1732
	at c:\lo\src\core\vcl\source\gdi\pngread.cxx(1732)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const 
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, 
unsigned short * pDeterminedFormat, GraphicFilterImportFlags 
nImportFlags, 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> * 
pFilterData, const WmfExternal * pExtHeader) Line 1813
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1813)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const 
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, 
unsigned short * pDeterminedFormat, GraphicFilterImportFlags 
nImportFlags, const WmfExternal * pExtHeader) Line 1281
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1281)
vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 2509
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2509)
vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance, 
ConvertData & data) Line 2481
	at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2481)
sofficeapp.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84
	at c:\lo\src\core\include\tools\link.hxx(84)
sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop * 
__formal, ConvertData & rData) Line 1752
	at c:\lo\src\core\desktop\source\app\app.cxx(1752)
sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void * 
instance, ConvertData & data) Line 1749
	at c:\lo\src\core\desktop\source\app\app.cxx(1749)
vcllo.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84
	at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic, 
ConvertDataFormat nFormat) Line 44
	at c:\lo\src\core\vcl\source\gdi\cvtgrf.cxx(44)
chartcorelo.dll!chart::ChartModel::impl_loadGraphics(const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & 
xStorage) Line 621
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(621)
chartcorelo.dll!chart::ChartModel::impl_load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor, const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & 
xStorage) Line 576
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(576)
chartcorelo.dll!chart::ChartModel::load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor) Line 543
	at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(543)
chartcontrollerlo.dll!chart::ChartFrameLoader::load(const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
rMediaDescriptor, const 
com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) 
Line 170
	at c:\lo\src\core\chart2\source\controller\main\chartframeloader.cxx(170)
fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1149
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(1149)
fwklo.dll!framework::LoadEnv::startLoading() Line 383
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(383)
fwklo.dll!framework::LoadEnv::loadComponentFromURL(const 
com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> 
& xLoader, const 
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & 
xContext, const rtl::OUString & sURL, const rtl::OUString & sTarget, 
long nSearchFlags, const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
lArgs) Line 170
	at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(170)
fwklo.dll!framework::Desktop::loadComponentFromURL(const rtl::OUString & 
sURL, const rtl::OUString & sTargetFrameName, long nSearchFlags, const 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & 
lArguments) Line 619
	at c:\lo\src\core\framework\source\services\desktop.cxx(619)
mscx_uno.dll!`anonymous 
namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * 
pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, 
_typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, 
_typelib_MethodParameter * pParams, void * pUnoReturn, void * * 
pUnoArgs, _uno_Any * * ppUnoExc) Line 214
	at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(214)
mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const 
_typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, 
_uno_Any * * ppException) Line 429
	at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(429)
binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny 
* returnValue, 
std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny> > 
* outArguments) Line 239
	at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(239)
binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
	at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(79)
binaryurplo.dll!request(void * pThreadSpecificData) Line 83
	at c:\lo\src\core\binaryurp\source\reader.cxx(83)
cppu3.dll!cppu_threadpool::JobQueue::enter(__int64 nDisposeId, bool 
bReturnWhenNoJob) Line 108
	at c:\lo\src\core\cppu\source\threadpool\jobqueue.cxx(108)
cppu3.dll!cppu_threadpool::ORequestThread::run() Line 170
	at c:\lo\src\core\cppu\source\threadpool\thread.cxx(170)
cppu3.dll!threadFunc(void * param) Line 186
	at c:\lo\src\core\include\osl\thread.hxx(186)
sal3.dll!oslWorkerWrapperFunction(void * pData) Line 58
	at c:\lo\src\core\sal\osl\w32\thread.cxx(58)
ucrtbased.dll!invoke_thread_procedure(unsigned int(*)(void *) procedure, 
void * const context) Line 92
	at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(92)
ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void 
* const parameter) Line 115
	at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(115)
kernel32.dll!BaseThreadInitThunk()
ntdll.dll!RtlUserThreadStart()

Change-Id: Ia22ebb2361192c30549b0f01ac0b709295e1dbdc
Reviewed-on: https://gerrit.libreoffice.org/63700
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      a0ac944b
    • Jens Carl's avatar
      test: enable clang-format for xindexaccess · 06b1e244
      Jens Carl yazdı 
      Accidentally formatted the files with commit
d0a6f8a8. Might just enable them.

Change-Id: I2f017a17d29f63721be10eb3bff388ed1a5a49bb
Reviewed-on: https://gerrit.libreoffice.org/64418
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      06b1e244
    • Mike Kaganski's avatar
      Let so_activex learn to work with Win32 errors and HRESULT properly · aa4427f3
      Mike Kaganski yazdı 
      Previous code made ~no sense from error handling PoV. Closing registry
keys could be skipped because of prior errors; booleans were cast to
HRESULT to be checked later using SUCCEEDED macro.

Change-Id: I0735ab7e2f3b29682ab19adb0e96a581e997b8b5
Reviewed-on: https://gerrit.libreoffice.org/64425
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      aa4427f3
    • Mike Kaganski's avatar
      tdf#120703 PVS: V560 A part of conditional expression is always true/false · eddee22b
      Mike Kaganski yazdı 
      Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11
Reviewed-on: https://gerrit.libreoffice.org/64429
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      eddee22b
    • Mike Kaganski's avatar
      tdf#120703 PVS: V560 A part of conditional expression is always true/false · 6ed52ecf
      Mike Kaganski yazdı 
      Change-Id: Ieff0dde4faee209200b8f4e809e8bb4eb1b8f4a6
Reviewed-on: https://gerrit.libreoffice.org/64433
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      6ed52ecf
  3. 02 Ara, 2018 13 kayıt (commit)
  5. 01 Ara, 2018 9 kayıt (commit)