Change-Id: Ib2bc309966e802eb584fa3c6e37458b840710e81
Reviewed-on: https://gerrit.libreoffice.org/43111Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I90a59bfdaec0e78d93888e5cc30d1c7fa147a7e7
Reviewed-on: https://gerrit.libreoffice.org/43162Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

this bug was introduced in

    commit a754294a
    use rtl::Reference in SwDocFac instead of manual acquire/release

fix it by using automatic ref-counting (i.e. rtl::Reference) everywhere.

Note that the logic in SwViewShell::~SwViewShell is somewhat
interesting.
From my reading of it, it was previously potentially calling
getIDocumentLayoutAccess on an SwDoc that had just been deleted.

So if there is a problem with this commit I would look there first.

Change-Id: I95b6b7e7523689c8b56063af642c3a84cbdcd331
Reviewed-on: https://gerrit.libreoffice.org/43131Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I842f90b655ccf195185bf8bae2d93b5b187954aa
Reviewed-on: https://gerrit.libreoffice.org/43137Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I985ec0f2107d9c0f0dede163e64a2de902102334
Reviewed-on: https://gerrit.libreoffice.org/43154Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

When compiling for the simulator, we should not
cross compile, since it is only using another sdk.

setting cross-compile when the architecture is the same
causes problems with several third party libs.

The unsolved problem is how to build cmdline tools.

Change-Id: Ida0b31bb12f6eadca413eb6e1874553adb8be6cd

Need to get the right string representation of error cells.

Based on the code it seems a regression from:
d4cd8677

Change-Id: I30001e63cd17ae68ba4988d5825de479a4496326
Reviewed-on: https://gerrit.libreoffice.org/43146Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

After commit 2e8a95d1 this doesn't
anymore generate false positives in the constparams clang plugin:

vcl/unx/gtk/gtkdata.cxx:817:39: error: ...
        ... this parameter can be const [loplugin:constparams]
    static gboolean call_userEventFn( void *data )
                                      ^~~~~~~~~~
1 error generated.

/vcl/unx/gtk3/gtk3gtkdata.cxx:782:39: error: ...
        ... this parameter can be const [loplugin:constparams]
    static gboolean call_userEventFn( void *data )
                                      ^~~~~~~~~~
1 error generated.

Change-Id: Id8d42a0c14bfcc887ec1ecbf70f4c41c26e26efb
Reviewed-on: https://gerrit.libreoffice.org/42912Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

..."nonstandard extension used: redefined extern to static", after the 'static'
in the friend declaration had to be removed for clang-cl with
e5d943d9 "'static' is invalid in friend
declarations"

Change-Id: I14524ec0a5d8e7e12c5b506cbf7ac43508ae26ae

so to keep tdf#112063 working as with...

commit e66c9aa3
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Sep 1 16:23:20 2017 +0100

    Related: tdf#112063 unsetting and resetting gtk modality is a problem

    for gtk3, so just set it on execute and no need to unset and reset it
    for whatever vcl nuttiness the existing code is doing

then let the proper calls to SetModalInputMode call the frame modality switch
and the hackery vcl calls the underlying vcl-specific body as ImplSetModalInputMode

Change-Id: I853ca50e0d9830ca7ba3077e243ccdee6e84e696
Reviewed-on: https://gerrit.libreoffice.org/43142Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ied0a5218b4f95a300d09483315d577b5bdf01bae
Reviewed-on: https://gerrit.libreoffice.org/43135Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7de9cd6c5569217aa8d379c6d112cd1874bca8e2
Reviewed-on: https://gerrit.libreoffice.org/43151Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I993e4dd219e247ca33022010da350f565c5e0dcf

Change-Id: I8cf1092bb2a5718b90fda8925eeb5dd281842b70

Change-Id: I210c322ab44057e45e2b75b3ce3d13529fb62d13

Change-Id: Ic870347b3dc0ce6b7ad223c47a36b54843a26613

...invovling preprocessing conditionals, to actually make the unhelpful warning
on Windows about OleEmbeddedObject::changeState go away.  And while at it, make
the check for preprocessing conditionals more targeted (similar to
1084e8be "More targeted check for preprocessing
conditionals in loplugin:blockblock").

Change-Id: I0300e0a547e969520a90cd126ea8f788cc17560f
Reviewed-on: https://gerrit.libreoffice.org/42975Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

By substituting a (valid matching the type) format using these
special LCID modifier values with the current system locale's
format.

See ECMA-376-1:2016 18.8.31 numFmts (Number Formats) and
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.numberingformats.aspx
which seems to be the only documentation available.

Change-Id: Ieca048a77d4ef473ae475e202557d1353ff5387d
Reviewed-on: https://gerrit.libreoffice.org/43148Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ic5f94197577659bb5ec9017d6967316c699cb93a
Reviewed-on: https://gerrit.libreoffice.org/43087Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I5dfa7689eb219548bde7ce181a0a453c84b0f066
Reviewed-on: https://gerrit.libreoffice.org/43136Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

SfxPoolItems are not assignable, you have to Clone them.

The assignments copied only the item values.
In case of SwElemItem and SwDocDisplayItem those item fields were
overriden in next steps.
Member values of SwShadowCursorItem are used, so pass them to local
variables.

Assignment operators are still used in copy constructors, but will
be removed soon.

Change-Id: I9f493b580f09f6e921c228183212c4fde66adf2b
Reviewed-on: https://gerrit.libreoffice.org/42939Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The only user of StoragePath was
TemplateFolderCacheImpl::openCacheStream which uses TempPath for
the cache file now.

Change-Id: Ia21b5aa804222f28a3af3779a0ecc4789c1860b3
Reviewed-on: https://gerrit.libreoffice.org/41087Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

SfxPoolItem has a copy constructor and its copy assignment
operator is deleted. Derived classes have a implicit defined
copy constructor too, if all members are copy constructible.

This patch removes default-able copy constructors and destructors
on such items.

Also removing copy constructors of pool item members
SvxClipboardFormatItem_Impl and SvxColumnItem.

Change-Id: Ic0f39c992d1fd7b667cb56134fd7c953681a3131
Reviewed-on: https://gerrit.libreoffice.org/43143Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If4b8b24908eecc8267d7b74810f5afe4b1f79e4d
Reviewed-on: https://gerrit.libreoffice.org/43139Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

+ avoid macSpell var
I'm not sure to retrieve [NSSpellChecker sharedSpellChecker] in a pointer
is a good idea.
Most of the examples using sharedSpellChecker just call [NSSpellChecker sharedSpellChecker]
each time. If there's a bit more code, at least we're sure we won't leak because of this.

Change-Id: I9818bd3d51f26b50849e1a5e69cc705acd92ad29
Reviewed-on: https://gerrit.libreoffice.org/43140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Look at NDEBUG, not OSL_DEBUG_LEVEL, to see whether asserts are active
or not.

Change-Id: I772d27da4bcc73c8c5a50ab4b72f50caddcf7273

[cpp.include] tells that includes in <> are searched in implementation-defined
places; includes in "" are searched in other implementation-defined places,
and is unsuccessful, then as if they were in <>.

MS VisualStudio IDE uses paths configured for the project for includes
in <>, and starts with current file paths for includes in "". So, using
<> for includes in current source file's directory missing from configured
project paths makes IDE show unsuccessful includes and unknown identifiers.

This fixes includes in writerfilter source directory.

Change-Id: I0bc1147aa68c305afd0c119418f07b655783a466
Reviewed-on: https://gerrit.libreoffice.org/43138Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ic379135f2d12023b1d50d70e72b640e2380483b7

Change-Id: I4892da38182295ca474e89bb061f713039cfd8e1

Change-Id: I7f6dbb170b88cc1717d08651d4ddd3aace0a7933
Reviewed-on: https://gerrit.libreoffice.org/43141Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I3ece92c5fe40da8a6bc6ace009dc9f651713aabf

Make simulator (and especially third party libraries) compile as OSX host,
but with iPhonesimulator SDK.

Change-Id: I2b282d1e84c5c6544dcb98413fec5c6e811efda6

Change-Id: I03eb1ad3b25cab5e2d8cf9b91d13bb5d97cfdfa2

Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

The check for -userid switch has never worked - its condition was
broken since initial commit 9399c662

Since this wasn't caught earlier, the functionality is unused
(and was deprecated anyway - see
https://wiki.openoffice.org/wiki/Framework/Article/Command_Line_Arguments),
this commit just drops the code.

Change-Id: Iae79f9cb7db454d72b11fb3954ebc456c7207d96
Reviewed-on: https://gerrit.libreoffice.org/43123Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I6d400540c878db4504f6830aa9a3a6a381162520
Reviewed-on: https://gerrit.libreoffice.org/43127Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Instead of storing the system ticks in the timer event message
simply store a version.

Moves the version handling code into a VersionedEvent class,
inherited by WinSalTimer and AquaSalTimer.

Change-Id: I5add85031d36b3424a26a9ef798294cbfb00b2e4
Reviewed-on: https://gerrit.libreoffice.org/42959Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Idbf1bf08f89f0fd1e92ad8f0d93d325267d19416
Reviewed-on: https://gerrit.libreoffice.org/43120Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I402ebea3acf6ca7f4d61785944c933663b35e1f3
Reviewed-on: https://gerrit.libreoffice.org/43125Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This was needed on 10.9, current build baseline is 10.12.

Change-Id: Ide1ddc9ea918676ab9363b7aeefd9b5606351e8d
Reviewed-on: https://gerrit.libreoffice.org/43114Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>