...that fails for me on at least one macOS and Windows machine each (with 180
and 230, resp., instead of 116), and where it is unclear why only a value of 116
would be correct (and where that specific check was not present before
95307f2c "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++", cf. my comment from 2018-01-17 at
<https://gerrit.libreoffice.org/#/c/47625/> "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++")

Change-Id: I16475ecaa853220ffe9e1d6dcf403302b04f4572
Reviewed-on: https://gerrit.libreoffice.org/48215Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...so no need to do that again in the body of the BPixelRaster ctor (which had
needlessly been done ever since the code's introduction with
6f769fb8 "INTEGRATION: CWS aw033").  And
BPixelRaster::reset appears to have otherwise been unused, so can be removed.

Change-Id: Icd8e09bfe225be2c6695d8a137c271dca5a70de7
Reviewed-on: https://gerrit.libreoffice.org/48184Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Project: help  237f881e17efb3091d93430fa287eab9b9d6b915

Some copyediting

• Fixing usage of phrasal verbs “check in” and “check out”
• Adding some missing prepositions
• Removing some pointless abbreviations
• Avoiding a reference to a “timer” that’s more precisely a stopwatch
  but not quite…

Change-Id: I37828f85065f17a16365caa45fd5913b771c4bec

Change-Id: I764edf0c1fb093bf64ea3ea91f98f8586d9549f5
Reviewed-on: https://gerrit.libreoffice.org/47017Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Title is not special in any way, showing author/language/date has the
same benefits.

Change-Id: Ie05071b88d7fa53ad0e39927904ea5e122a66c9a
Reviewed-on: https://gerrit.libreoffice.org/48183Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I7a57be7e241883adac4417baa699a97d6304a631
Reviewed-on: https://gerrit.libreoffice.org/48188Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986
Reviewed-on: https://gerrit.libreoffice.org/48185Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iaa133fa7f3b4bc4adea1c1568015327b1694161b
Reviewed-on: https://gerrit.libreoffice.org/48169Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

A row frame may not belong to a table frame, when it is being cut, e.g., in
lcl_PostprocessRowsInCells().
Its SwRowFrame::Cut() has been called; it in turn called SwLayoutFrame::Cut(),
which nullified row's upper in RemoveFromLayout(), and then called Shrink()
for its former upper.
Regardless of whether it will be pasted back, or destroyed, currently it's not
part of layout, and its height does not count.

See bt https://bugs.documentfoundation.org/attachment.cgi?id=139171

Change-Id: I4010e1f246a3ebb89b3f972a03619a2775146da4
Reviewed-on: https://gerrit.libreoffice.org/48089Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Currently we use arrays allocated on heap for initializing
available locales and dictionaries.

This patch encapsulates all the different objects
related to a dictionary into a strcut dictItem.

unique_ptr is used for hunspell, also uses o3tl::make_unique for creating them.
Used 'reserve' for better memory allocation of vector.
Removed unused member and local variables.

Change-Id: I6309c681790cfec4ee9b11119937063bc414cf1f
Reviewed-on: https://gerrit.libreoffice.org/48109Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

These two words is switched for some unknown reason. It looks like it was done
by mistake.

Change-Id: I723e91bb93eed054969a09170d8307017187586d
Reviewed-on: https://gerrit.libreoffice.org/48228Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Ife73b464b39c1556f4549226d835d6c8f2b50c1a
Reviewed-on: https://gerrit.libreoffice.org/48191Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Project: help  f8887d3de3a414cd677126484a56f7a29d88af67

Nope, that’s not what the button does

See core commit b1a6a99b.

Change-Id: I70456817e1956d6e213468583e0e16b06a69b303

Apparently the MSMs have been renamed in Visual Studio 2017.3 but only
configure was adapted, not scp2.

Not sure if these MSMs are still relevant given the new
gid_File_Vcredist_Exe thing.

Change-Id: I4fe27c8298b3a2024acc62d12ce8ea67e2eca80d

Change-Id: Ic526bc3babfd342fd2ebb10003639d600a668ae5

liblangtag build runs a "reg2xml.exe" which requires the ICU dlls in
instdir.

Change-Id: Icf44c51e802636de613f76a25fb16a567a8d982d

The Cygwin terminal swallows colorful error messages, which is unhelpful.

Change-Id: I2005994eb76fdba1dc49efc2988e38ac460d6724

Change-Id: I11d706c544698d57b75231e33e3d49f1ac1d4d73
Reviewed-on: https://gerrit.libreoffice.org/48159Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I183e1377747f662da1204e90a24fb4f8f2268699
Reviewed-on: https://gerrit.libreoffice.org/48156Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4b40f768ec6b0e42e91d7a6af6d5c23a94ab9e9d
Reviewed-on: https://gerrit.libreoffice.org/48192Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie4ae8459c0afbeac0cad1b8a30dad02535d558dd
Reviewed-on: https://gerrit.libreoffice.org/48190Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic5b13b2d21b7c429782a8c6cbb2be65be3a94aea
Reviewed-on: https://gerrit.libreoffice.org/47405Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aron Budea <aron.budea@collabora.com>

Regression from commit 46b3202b

Change-Id: If8e0b309274ea14e996e0dde2d1ee9b49ff0f737
Reviewed-on: https://gerrit.libreoffice.org/48173Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ia7f98a84bd42289ef0673b52e5e74a6a24554402
Reviewed-on: https://gerrit.libreoffice.org/48168Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

No harm was done as the stack is cleaned up afterwards, but it's wrong
anyway and having to push the result downwards during cleanup is
unnecessary.

Change-Id: I0b2c153c9791ce5c287d340bac466c19cd6a5703

This is prep work for tdf#95377. I need this function to
run when there is no TopContext. This function doesn't do anything
with the context, so in that regard I wonder if it is even
necessary? My guess would be that it is a leftover piece from
discovering the fix for n75883.

However, to avoid causing a regression, I'm just pulling this test
into the calling functions. (Of the three instances
calling this function, two need to be contextless..)

This is not truly NFC because if the followup patch is reverted,
then this one will cause a change. But that is actually OK, because
if my follow-up patch breaks because of these two functions changing
to become contextless, then I'll be better able to pin-point the
reason for the regression.

Original commit adding this function was
commit 2123ede0

Change-Id: I471aa852aa48527d69e0343a2ac28fa6e8acb209
Reviewed-on: https://gerrit.libreoffice.org/48062Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1
Reviewed-on: https://gerrit.libreoffice.org/48136Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3bf7ce76516f7c930e564791109ff72fb5b87d52

Change-Id: I9d4beccfa7ca8953360d67d08a3b2f04d2ccfed9
Reviewed-on: https://gerrit.libreoffice.org/48178Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If364a961f5e144cc0f3572108020c99db6febfb8
Reviewed-on: https://gerrit.libreoffice.org/48177Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I21663a7eef846244f330b3236a2ff1a2efae15bb
Reviewed-on: https://gerrit.libreoffice.org/48174Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Regression from:
e68b6e34

AppendTextNode might be sufficient for import (when there is no
content in the document), but for clipboard operations better to
use the original SplitNode method.

Change-Id: I7de3e9bc9c5356acb0b4cc43927a0d39079522b2
Reviewed-on: https://gerrit.libreoffice.org/48124Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I1bcfe0dabd61a2157bc4a48ea54413882ecaaabc

Change-Id: I349eb6c3c2408729799d35316ab75bb05920021f

HTMLTable::FixFillerFrameFormat is unused now.

Change-Id: Ic09d9585368ead7317325068eabb0171b76b6a9b

which don't add any value anymore

Change-Id: I45977d972d4d02926630b749d3ec736416138cf5

we were previously excluding them

Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  d860405baeffb4cb6b1a32274d2c2b609ef8deea

Correct Catalan spelling

Typo introduced in 01879555450189381cc02517433807056b193af8

Change-Id: I9978ec8b238493a501981e192aa92547f2c1fe5d

Project: help  02e87fe2b0027c725075154f9172e9fb99ef9589

Add more localized strings for new Help

Change-Id: I8c0cdcf8cf1ce64a407c98f4619a46b08c259b7d
Reviewed-on: https://gerrit.libreoffice.org/48186Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>