Change-Id: Ie6aeff552b13d2b9abe38c178a4f467d47fc0ca5
Reviewed-on: https://gerrit.libreoffice.org/71520
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...from Content::getPropertyValues.  ca030879
"tdf#121337: Fail on GIO error in GIO UCP getPropertyValue" had made
Content::getPropertyValues fail for every getGFileInfo failure.  However, when
saving to a not-yet exisiting file, SfxMedium::Transfer_Impl
(sfx2/source/doc/docfile.cxx) requests the properties "Title" and "ObjectId"
from the Content representing the not-yet existing file, and apparently expects
those requests not to fail.  So restructure Content::getPropertyValues to only
call getGFileInfo when actually needed (that covers not failing for the unknown-
anyway "ObjecdtId" property), and handle "Title" specially by not failing for
a non-existing file.  (The documentation at offapi/com/sun/star/ucb/Content.idl
says for the "getPropertyValues" command that: "The execution will not be
aborted, if there are properties requested, that are unknown to the content."
But that leaves it somewhat unclear whether failure to obtain a known property
should be propagated.  It apparently should be in the context of tfd#121337
fixed previously, but apparently not for "Title" here.)

Change-Id: I12a9a5bd93d661922ea3b7b19a84a7e73e7e4b50
Reviewed-on: https://gerrit.libreoffice.org/71515
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

All hxx cleaned except the ones in
xmlsecurity/source/xmlsec/mscrypt

Change-Id: I651f53c9d339208b3132f9078a5c3829ff9c5dc8
Reviewed-on: https://gerrit.libreoffice.org/71448
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

The crash affects Windows, not Linux where an error popup appears instead (MacOs?)
It seems the fact the url was empty triggers an exception in ucbhelper::Content ctr
So let's put the lines in the try catch and log the exception.
See comments of bugtracker for slight more details.

Change-Id: I60e55be488632ff6e0106fde832a818c6431f58e
Reviewed-on: https://gerrit.libreoffice.org/71321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I465627958ef7a18c0e80361ae4a1c6ba27ec735d
Reviewed-on: https://gerrit.libreoffice.org/71513
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

(had caused a "patch unexpectedly ends in middle of line" warning)

Change-Id: I10860a25266d1672f1fdd0ce89f3de37b260a5fb
Reviewed-on: https://gerrit.libreoffice.org/71509
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

... giving this error:

   In file included from
   /home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:50:
   /home/android/lo/master-android-arm/include/comphelper/scopeguard.hxx:36:14:
   error: function 'comphelper::<deduction guide for ScopeGuard><(lambda at
   /home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:34)>'
   has internal linkage but is not defined [-Werror,-Wundefined-internal]
       explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {}
                ^
   /home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:28:
   note: used here
       comphelper::ScopeGuard guard([&]() {
                              ^

See https://lists.freedesktop.org/archives/libreoffice/2019-April/082599.html

Change-Id: If719d183d2ce15fa4877cd8bbf457d79097765be
Reviewed-on: https://gerrit.libreoffice.org/71510Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

also with the paragraph mark, not leaving an empty
paragraph at the original place of the moved text.

Note: as desktop version of MSO does, but its
online version leaves empty paragraphs interestingly.

Change-Id: I03dda8997df3efbc82e936bd31a3813323e6b5ab
Reviewed-on: https://gerrit.libreoffice.org/71382Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Added Tooltip labels to icons.

Change-Id: Idace4947f98c0a03214e3feffe692711063543e1
Reviewed-on: https://gerrit.libreoffice.org/70981Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins

Change-Id: I5f0cd0884b6490ae3018de13e3508b76e201d55f
Reviewed-on: https://gerrit.libreoffice.org/71507
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Some OpenCL implementations may be broken, e.g. pocl simply
asserts and aborts if it can't find Clang. In order to protect
against crashes caused by faulty OpenCL drivers, when testing OpenCL
functionality on OpenCL setup change, first do a simple test
in a separate helper.

Change-Id: I1cf328e731c48f47745b27c7130e7521254209f5
Reviewed-on: https://gerrit.libreoffice.org/71080
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I6598d81b166486f3c48b119cc136b9f6e6c2a12c
Reviewed-on: https://gerrit.libreoffice.org/71336
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Regression from commit 8c73b16f (DOCX
import: declare wpg as a supported feature, 2013-12-05), the problem was
that <wpg:graphicFrame> did not forward to to the relevant oox context,
and also Writer had no idea how to create a
com.sun.star.drawing.OLE2Shape. Fix the later by using the same service
name that's in use for the non-groupshape case.

Change-Id: Id3536854da7c1f01525bb38d801496ecebd4c161
Reviewed-on: https://gerrit.libreoffice.org/71505Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Use a function to consistently check if gImpl is valid before assigning last
exception message.

V595 The 'gImpl' pointer was utilized before it was verified against nullptr.
     Check lines: 2673, 2683.

Change-Id: I18fc0d632c84f37b05e9d1c3c83689e6eaa6f66c
Reviewed-on: https://gerrit.libreoffice.org/71488
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

It also affects gcc 8.3

Change-Id: I896e84d5e1e96abfe81294e921cfcc060e44fb6f
Reviewed-on: https://gerrit.libreoffice.org/71474
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I742881a631bbf60b8b2808554304ba6f75bb8151
Reviewed-on: https://gerrit.libreoffice.org/71501
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I36d9717afe1aeebdba7680f6efcae5335fd0f9b3
Reviewed-on: https://gerrit.libreoffice.org/71502
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

cache the XMLTokenMap data in static const vars, so we only need to
initialise them once

Change-Id: Ib63bedc5af5d5927fed189a6b1a86a5db6865c72
Reviewed-on: https://gerrit.libreoffice.org/71466
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Reduce time spent constructing strings from char arrays just to do a
comparison

Change-Id: I7af99747530d91d57e1a5b789ca9989a616428fc
Reviewed-on: https://gerrit.libreoffice.org/71464
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia28b1f0281485691e3b4188d23947014c1eff385
Reviewed-on: https://gerrit.libreoffice.org/71465
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I48cb0a1b5dfcf6471c1cdf9d79445281f9f33020
Reviewed-on: https://gerrit.libreoffice.org/71463
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cache the reading of the source scan line, and use sal_Int32 for pixels
and counts (long is 64-bit on 64-bit linux)

Change-Id: Iaa0abc3ed3316d3137184b0c051612874885ddf4
Reviewed-on: https://gerrit.libreoffice.org/71462
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Make CntUnencodedStringItem sortable, implementing operator<.
This takes the load time from 4s to 3.3s

Change-Id: I532cdf65149a733d41d2caf367675800d2ba4d41
Reviewed-on: https://gerrit.libreoffice.org/71460
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

SIFR icon update "currencyfield"

Change-Id: Ied78cf1edc7a03239300db10461275ecc75ad4ae
Reviewed-on: https://gerrit.libreoffice.org/71490
Tested-by: Jenkins
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>

Change-Id: I881b23341ee1fc8d1ff3443e8ab52f51e07c3646
Reviewed-on: https://gerrit.libreoffice.org/71499Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I6e04287504cc8d4c0e3d09632ee1c7355157e5ee
Reviewed-on: https://gerrit.libreoffice.org/71500
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia927070883e5647b61876e31d6a0a085e2456f8a
Reviewed-on: https://gerrit.libreoffice.org/71498
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I58b7bb114864a9fdf901a92d54717964c6f1b68e
Reviewed-on: https://gerrit.libreoffice.org/71497
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Id130dd7739b9662541b50b7792da170da70a6a9b
Reviewed-on: https://gerrit.libreoffice.org/71496
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I51bd172cdd22d55a6800d1e74e38149874629f85
Reviewed-on: https://gerrit.libreoffice.org/71495
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Icce9c3c5fa826b6f5237d2d0e28fc51555a3e267
Reviewed-on: https://gerrit.libreoffice.org/71494
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I96113168d4ae8289cec3a5b0bbd6aa79faf97c48
Reviewed-on: https://gerrit.libreoffice.org/71493Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ib851156da20528e7df5197ba96c35727af7bdbb6
Reviewed-on: https://gerrit.libreoffice.org/71492
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - Rename some menu-related help files for Impress and Draw
    
    The renamed files are in the process of heavy editing, so might
    as well move from obfuscated names to human-readable ones.
    
    Change-Id: I2df6470eefc3b8bb381de77471c688d9498854cf
    Reviewed-on: https://gerrit.libreoffice.org/71436
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Ic0f143ea6871965a5d1e9db4b35db88f8adb5181
Reviewed-on: https://gerrit.libreoffice.org/71491
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

so use toggle and ignore toggle offs

Change-Id: Id6a9f3a7a9cf02d62ede00e4c246629406f9a64b
Reviewed-on: https://gerrit.libreoffice.org/71481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7aeca38c62c986041aab438e5d28bc8e6f0ccf2a
Reviewed-on: https://gerrit.libreoffice.org/71486
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Iacaf5e19bb20dee471ebdc53977170312cf0fc5f
Reviewed-on: https://gerrit.libreoffice.org/71485
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Ife3e99e0cf00d7d320eb8e403743d42fb8274df8
Reviewed-on: https://gerrit.libreoffice.org/71483
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Otherwise it can happen that the file is locked by someone
else during the saving method is running.
I just extended the scope of the existing DisableUnlockWebDAV()
calls a bit. In case of webdav it does not cause an issue to
avoid unlocking the file before locking it again with an other
SfxMedium.

Change-Id: I6ac4e3326c63c9e184a7710ce8994cac1ed79449
Reviewed-on: https://gerrit.libreoffice.org/71484
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>