Kayıtlar (commit) · 0e5d5389428accb397594229f173a9b95aef4433 · LibreOffice / core

01 Şub, 2018 40 kayıt (commit)

ofz#5872 Direct-leak · 0e5d5389
Caolán McNamara Şub 01, 2018 yazdı
```
Change-Id: Id792ecc80dd3367f070c9a613f3999a8c3e386a1
```
0e5d5389

tdf#42949 Remove unneeded helpids.h headers (3/3) · f38c49cd

Gabor Kelemen Ara 20, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directory sw.

Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I100fd818b0e68eaaecbfaf7c7b58e95dea489aeb
Reviewed-on: https://gerrit.libreoffice.org/46870Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

f38c49cd

tdf#42949 Remove unneeded helpids.h headers (2/3) · 73bfe83a

Gabor Kelemen Ara 15, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories r* - svx*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I81bdb80161b0207f5df651eb17c58caef44250d3
Reviewed-on: https://gerrit.libreoffice.org/46869Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

73bfe83a

tdf#42949 Remove unneeded helpids.h headers (1/3) · 4fae455f

Gabor Kelemen Ara 14, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories b* - e*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I221d22f68584115d71660a97c4f108595625d12c
Reviewed-on: https://gerrit.libreoffice.org/46868Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

4fae455f

Use std::max · c35d44ff

Stephan Bergmann Şub 01, 2018 yazdı

(with the nice side-effect of removing one more false -Wsign-compare from
Android builds where USHRT_MAX is erroneously of type unsigned int)

(the original cast of rMax (of some unsigned type) to (signed) long had
probably originally been added to silence some signed-vs.-unsigned comparison
warning, so would no longer be necessary when using std::max)

Change-Id: I26212e731e26d885b848c7351a9ca5f9735e1f78
Reviewed-on: https://gerrit.libreoffice.org/49081Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

c35d44ff

sw: convert DELETEZ to std::unique_ptr in SwXFrame · 2a94fddc
Michael Stahl Şub 01, 2018 yazdı
```
Change-Id: I1aa9d0fc8712773ea87ea8419c384f6f23258387
```
2a94fddc

deps w/ hardlinks: don't create it as foo_ only to move it to foo · 23961ff6

Christian Lohmaier Eyl 21, 2017 yazdı

this breaks with CCACHE_HARDLINK=1 on close-enough rebuilds, as there
will be "foo" from previous run (hardlinked to ccache-dir), and foo_
will be hardlink to the same file, resulting in mv to barf out since
foo_ and foo are the same file (and -f/force doesn't help in this case)

Change-Id: Iaefcec05b34dad88f49477693e2157c1ca0623ac
Reviewed-on: https://gerrit.libreoffice.org/42586Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

23961ff6

sd: Remove unused keywords · b52275dd

Takeshi Abe Ock 11, 2018 yazdı

Change-Id: I1a180aaca32cabc56a6d5a6a3f0b23680d60aaf3
Reviewed-on: https://gerrit.libreoffice.org/47760Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

b52275dd

sw: convert DELETEZ to std::unique_ptr in SwUndoTableNumFormat · 69656809

Michael Stahl Şub 01, 2018 yazdı

Change-Id: Ia1123e2b5f4b3bb2d827d2cdbeff485c3c2a56da
Reviewed-on: https://gerrit.libreoffice.org/49080Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

69656809

sw: convert DELETEZ to std::unique_ptr in unodraw.cxx · e2d0e559

Michael Stahl Şub 01, 2018 yazdı

Change-Id: I89aaf157ded42ea3e968c706e4431f03d8f19ed7
Reviewed-on: https://gerrit.libreoffice.org/49078Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

e2d0e559

apparmor: fix @{HOME}/.mozilla/firefox access for XML signing · b6176bde

Rene Engelhard Ock 21, 2018 yazdı

the #include <abstractions/private-files-strict> bringing
"audit deny @{HOME}/.mozilla/** mrwkl," in actually denies everything here.
Use just <abstractions/private-files> and allow profiles.ini, secmod.db
and cert8.db.

At least opening the Digital Signatures dialog doesn't log apparmor DENIED
now...

Change-Id: Id557626fc26745841f0cca005d483fd1e6ac922d
Reviewed-on: https://gerrit.libreoffice.org/48264Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

b6176bde

Pass also webdavs:// URLs directly to soffice binary · 25214012

Katarina Behrens Ock 30, 2018 yazdı

instead of going via kioexec & temp file

Change-Id: I48ed5de97a2914025f01884f5ed0d0edce452112
Reviewed-on: https://gerrit.libreoffice.org/48900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

25214012

Support for webdav:// and webdavs:// schemes from command line · 65abd11d

Vasily Melenchuk Ock 25, 2018 yazdı

We have currently support for WebDAV schemes as vnd.sun.star.webdav://
but it is not user and tools friendly.

Some related refactoring in ucb to reuse existing code instead of
manual parsing of URLs.

Change-Id: Ib14411796d6cf11afd80d5132abe67d4e46a42e1
Reviewed-on: https://gerrit.libreoffice.org/48585Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

65abd11d

split out SFX_METRIC_ITEM into separate field · ae5f89fd

Noel Grandin Ock 31, 2018 yazdı

instead of overloading the nMemberId field
and thus fix various places that were effectively setting the METRIC
flag and causing a warning in SvxUnoConvertToMM

And fix bug in
    sw/source/core/unocore/unomap.cxx
where the PropertyAttribute::READONLY was in the wrong place,
ever since
    commit 84a3db80
    Date:   Mon Sep 18 23:08:29 2000 +0000
    initial import

Change-Id: Ifc2bf56709f19aea75300b2fda62ce551efc26af
Reviewed-on: https://gerrit.libreoffice.org/48950Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

ae5f89fd

Change bitmap table to store XBitmap instead of GraphicObject URL · e02efb62

Tomaž Vajngerl Şub 01, 2018 yazdı

As we want to get rid of GraphicObject URLs for the more robust
image life-cycle handling, it was necessary to change the way
bitmap table stores and handles images, so that they always
store a Graphic object (wrapped in UNO object that provides the
XGraphic and XBitmap interface).

In addition this changes loading and saving from ODF (xmloff) and
OOXML (oox) filters so they don't depend on GraphicObject URL
anymore, but load or save directly to / from  XGraphic or XBitmap.

Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21
Reviewed-on: https://gerrit.libreoffice.org/49074Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

e02efb62

add XGraphicStorageHandler interface · a61747c2

Tomaž Vajngerl Şub 01, 2018 yazdı

This is a XGraphicObjectResolver (future) replacement as it will
not be needed anymore. All resolving from URL to URL will be
replaced by loading, saving and serialization of XGraphic objects
(when appropriate), which is covered by this interface and
implementation by XmlGraphicHelper - the same that implements the
XGraphicObjectResolver.

Change-Id: I227634e443ce336218c2a2effaf34f9ef3576382
Reviewed-on: https://gerrit.libreoffice.org/49073Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

a61747c2

hash implementation for Graphic objects, for set/map use · 3195fce9

Tomaž Vajngerl Şub 01, 2018 yazdı

Change-Id: I58547ad90d1aba6b1734a547c8138d1476c4b813
Reviewed-on: https://gerrit.libreoffice.org/49072Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

3195fce9

these TODOs have been done · 62222b40

Noel Grandin Ock 31, 2018 yazdı

Change-Id: I5457f38f4668175a8f3e1b0f24a90963ee9d585f
Reviewed-on: https://gerrit.libreoffice.org/49076Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

62222b40

Fix typos · 5acfb93c

Andrea Gelmini Ock 31, 2018 yazdı

Change-Id: Icb4f4d9039278318d5f7f6302d57957b2c02bdb8
Reviewed-on: https://gerrit.libreoffice.org/49069Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

5acfb93c

Fix typos · 01c43770

Andrea Gelmini Ock 31, 2018 yazdı

Change-Id: I455efa82de60b764a500e1cc092ae08e800ec824
Reviewed-on: https://gerrit.libreoffice.org/49068Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

01c43770

embedserv: MSVC: pragma warning: make more specific, remove obsolete · 2c9904f3

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0abd5662648b09f31164d919688e17a651bf78c8
Reviewed-on: https://gerrit.libreoffice.org/48976Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2c9904f3

extensions: MSVC: pragma warning: make more specific, remove obsolete · dc4dae12

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I7bbb280810af51adc25595667f1c40aca0a8ae26
Reviewed-on: https://gerrit.libreoffice.org/48977Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

dc4dae12

external: MSVC: pragma warning: make more specific, remove obsolete · 98e9e033

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ic17ffd6fc34504cf848d963e787e685ed2142080
Reviewed-on: https://gerrit.libreoffice.org/48978Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

98e9e033

fpicker: MSVC: pragma warning: make more specific, remove obsolete · f7d1081a

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ifb05da6cf6d2084e80372440118883278738ea87
Reviewed-on: https://gerrit.libreoffice.org/48979Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

f7d1081a

helpcompiler: MSVC: pragma warning: make more specific, remove obsolete · f0f43e0c

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I56298ee1962a4989bcc5446df2766d7aa30c28cd
Reviewed-on: https://gerrit.libreoffice.org/48980Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

f0f43e0c

i18nlangtag: MSVC: pragma warning: make more specific, remove obsolete · d3870fc7

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I88e2b2e68fbbc86639db986e8f430a90bd4b94f0
Reviewed-on: https://gerrit.libreoffice.org/48982Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

d3870fc7

i18npool: MSVC: pragma warning: make more specific, remove obsolete · bc5f5630

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Iacb0c1fba331aa76ea341bc21690f09109b14a0a
Reviewed-on: https://gerrit.libreoffice.org/48990Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

bc5f5630

EPUB export: can use std::move() here · bf79168d

Miklos Vajna Ock 31, 2018 yazdı

And get rid of an easy to avoid include if we are at it.

Change-Id: I63cb4628a3a7038aab91c66f592920923a31d7a6
Reviewed-on: https://gerrit.libreoffice.org/49060Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

bf79168d

USHRT_MAX -> SAL_MAX_UINT16 · 3171066a

Stephan Bergmann Ock 31, 2018 yazdı

...as nH needs to fit into the following SwPosSize::Height call's parameter of
type sal_uInt16.  And whatever the reason to check for < instead of
<= USHRT_MAX...

Change-Id: I0377d51e7411eef7913d951eb972214a8d8d5768
Reviewed-on: https://gerrit.libreoffice.org/49065Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

3171066a

loplugin:datamembershadow in XFCellStyle · 0913b2af

Noel Grandin Ock 31, 2018 yazdı

looks like the subclass member is never written to, so I'm going to
assume this was a bug

Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514
Reviewed-on: https://gerrit.libreoffice.org/49001Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

0913b2af

loplugin:useuniqueptr in SfxModule_Impl · a0c2d1be

Noel Grandin Ock 16, 2018 yazdı

Change-Id: I218cd34aefcf8bfbc8a52379fb1e15ec2ef3ac31
Reviewed-on: https://gerrit.libreoffice.org/48700Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

a0c2d1be

embeddedobj: MSVC: pragma warning: make more specific, remove obsolete · dad539c0

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Iefcaf1f5ae73050300879fff0855f709c5f8a30d
Reviewed-on: https://gerrit.libreoffice.org/48975Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

dad539c0

dtrans: MSVC: pragma warning: make more specific, remove obsolete · f901bc5a

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958
Reviewed-on: https://gerrit.libreoffice.org/48974Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

f901bc5a

desktop: MSVC: pragma warning: make more specific, remove obsolete · be13e756

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I61ed9700c904b7499166d32e4ffda69811d64a8b
Reviewed-on: https://gerrit.libreoffice.org/48973Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

be13e756

cppuhelper: MSVC: pragma warning: make more specific, remove obsolete · b23e4d2b

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ib097ea1764d275a3123d0dccf05d52315b4858a1
Reviewed-on: https://gerrit.libreoffice.org/48971Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

b23e4d2b

canvas: MSVC: pragma warning: make more specific, remove obsolete · 3c879be2

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0d23c789dd3cbb21a18383988dd6b24318fda225
Reviewed-on: https://gerrit.libreoffice.org/48959Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

3c879be2

dbaccess: MSVC: pragma warning: make more specific, remove obsolete · 6b33a41f

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0066b2de769a412cb04bcec7cdd8401f42b9dcf3
Reviewed-on: https://gerrit.libreoffice.org/48972Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

6b33a41f

configmgr: MSVC: pragma warning: make more specific, remove obsolete · 8f43170f

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I7f98fa855ff521db42bf9b379bfac3d430791ae0
Reviewed-on: https://gerrit.libreoffice.org/48968Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

8f43170f

cli_ure: MSVC: pragma warning: make more specific, remove obsolete · acb3eeb6

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I63e12a22a46de27a8bd010e4d21bf36d3a7e9178
Reviewed-on: https://gerrit.libreoffice.org/48967Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

acb3eeb6

Remove shared mxComponent in scdatapilottableobj · e587def2

Jens Carl Ock 31, 2018 yazdı

Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331
Reviewed-on: https://gerrit.libreoffice.org/49061Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

e587def2