Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Cleaned directories are:
accessibility, drawinglayer, itemsetwrapper, main, sidebar

Change-Id: I612eae9dec636d57a3a3a00102d74b964da5b54c
Reviewed-on: https://gerrit.libreoffice.org/64307
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I09775c92f7c5b5e0f554a2822d243a230a06f626
Reviewed-on: https://gerrit.libreoffice.org/65136
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Martin Hosken thinks all patches are redundant now, so drop them.

Change-Id: I062168416a1289b7f4dd42d8ae58b7df56a37712
Reviewed-on: https://gerrit.libreoffice.org/65074
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Id00bcd45faa3d9e82d3ed23843f5c4320bfa8f79
Reviewed-on: https://gerrit.libreoffice.org/65135
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2d6c6d975a3047c879a87a1cee0305772c6b5d49
Reviewed-on: https://gerrit.libreoffice.org/65134
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

* Update helpcontent2 from branch 'master'
  - Correct "Print black" as "Print text in black"
    
    Change-Id: Ia6832472ac9b3c636e5880293794500601b5c010
    Reviewed-on: https://gerrit.libreoffice.org/65131
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Since 'QObject' and the 'Q_OBJECT' macro are used,
the corresponding header needs to be included.

Without the include and forward-declaration given here,
the compiler doesn't know about 'QObject' and 'QAction'
which are used further below, unless another header that
takes care of this is included before 'QtMenu.hxx'.

The error could be provoked e.g. by moving the
'#include <Qt5Menu.hxx>' in front of all other includes
in 'vcl/qt5/Qt5Frame.cxx'.

Change-Id: I76c15eb445cbe26774d6e4177e12c93658daf0ad
Reviewed-on: https://gerrit.libreoffice.org/65130
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

... to squeeze some memory and later use this as a mass object
during consolidation.

Change-Id: I3f0aa03ec0bbbb4c64a4854b55a451dd3cacfa90
Reviewed-on: https://gerrit.libreoffice.org/65124
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I9ddb8f70b53600c02addeaf44a8cd1978e1ba5d0
Reviewed-on: https://gerrit.libreoffice.org/65128
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Take system includes ('-isystem') into account
when generating the '*.pro' files for Qt Creator
using the 'qtcreator-ide-integration' make target.

Without this, Qt Creator is unable to find the
corresponding included files.

This also makes Qt Creator's ClangCodeModel
able to properly process files and display
actual problems, rather than always showing
a multitude of errors due to missing includes
while parsing the source/header files.

Change-Id: Ie513341e1074ceab9304ae9df73fac9a79329db8
Reviewed-on: https://gerrit.libreoffice.org/65129
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

ScMarkData is passed since long.

Change-Id: I7bf66d1f66d66287206ba4ef69c89f9b020103c6
Reviewed-on: https://gerrit.libreoffice.org/65123
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

So we can start to bundle everything in one place.

Change-Id: I5df76bfae0e1bd5e8923b0012c1337e3a7f14db8
Reviewed-on: https://gerrit.libreoffice.org/65122
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

(Exactly the same thing as the old name NSAnyEventMask. The naming
convention just has changed to use a common prefix: NSEventMask*
instead of NS*EventMask.)

Change-Id: I18a1ae0a2b399ac38567a0171b0d211dcc9faec1

Change-Id: Iee8305f581533dedcb94d75af15d7178792947ff
Reviewed-on: https://gerrit.libreoffice.org/65114
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

commit fec8c14e changed the default value
of InputRequired as read from the file; that is the value InputRequired
has when it is set to neither false nor true in the file

This is to mitigate the fact that InputRequired was not property
enforced and now suddenly is, but its default value was "true"! So
lots of past forms have InputRequired==true everywhere, users did not
pay attention to it because it was not enforced, and now it is
enforced, which suddenly is a huge PITA for users because they have to
update most controls in all forms. Since older versions of LibreOffice
omitted the input-required attribute in the file (the XML stream) when
it had its then-default value (namely "true"), we changed that to now
mean "false". As a side-effect, newer LibreOffice omits the attribute
in the XML stream when InputRequired has its new default value, namely
"false".

So the situation is that any file saved with an older LibreOffice will
have all its form controls with InputRequired==false when opened with
a newer LibreOffice, and any file saved with a newer LibreOffice will
have all its form controls with InputRequired==true when opened with
an older LibreOffice.

This commit makes LibreOffice always write the XML attribute. So that
any file saved with a newer LibreOffice will have the same
InputRequired values when opened in an older LibreOffice.

This enhances forward compatibility, because InputRequired was
enforced in older versions when the underlying database field was
marked NOT NULL. So the current situation leads to unwanted
enforcement in older LibreOffice versions, with a file that is saved
from newer LibreOffice with a control having InputRequired==false and
bound to a database field marked NOT NULL. This commit fixes that, by
ensuring that any form control with InputRequired==false in newer
LibreOffice will also have InputRequired==false in older LibreOffice.

Change-Id: I92ef48ad99c4e2ead43e95376282cc861c181ab3
Reviewed-on: https://gerrit.libreoffice.org/64642
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Ie72854a812c9ea73ded6a3e8ed8992dcc73f40ad
Reviewed-on: https://gerrit.libreoffice.org/65112
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

* Update helpcontent2 from branch 'master'
  - Help files: http -> https
    
    + some more conservative changes
    
    Change-Id: I328505b05838c3f3ce40759096ca77d30c874c57
    Reviewed-on: https://gerrit.libreoffice.org/63196
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Help files: http -> https
    
    + some more conservative changes
    
    Change-Id: I6f7e22164c975421f01e9ba974d82f14a34c0d5d
    Reviewed-on: https://gerrit.libreoffice.org/63219
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Help files: http -> https
    
    + some more conservative changes
    
    Change-Id: I0c5099f12438158ab6f9e4ac504612e2e2bea009
    Reviewed-on: https://gerrit.libreoffice.org/63213
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Help files: Cleanups and Small Improvements
    
    Change-Id: Id363e364f66ab66989d853ba0d2edb49abd3f7f4
    Reviewed-on: https://gerrit.libreoffice.org/63207
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: I2286dcecc52a6dafd8075a211161a16d5a637686
    Reviewed-on: https://gerrit.libreoffice.org/64933
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: Ie60e05fb6b82cd91d3141ef567919f680fd84b6c
    Reviewed-on: https://gerrit.libreoffice.org/64929
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces
    
    Change-Id: I3d29383ab3674d2967b41cceeff1d0ef0fafea06
    Reviewed-on: https://gerrit.libreoffice.org/64928
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#121173 correct double spaces in sentences
    
    Change-Id: Ia8116e46e75cbf32293f20e0c905ed8707156b95
    Reviewed-on: https://gerrit.libreoffice.org/64886
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#121173 correct double spaces in sentences
    
    Change-Id: I46b602d6ca6323d932839b8da5bfef6d4eec2dcc
    Reviewed-on: https://gerrit.libreoffice.org/64872
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: I3bbcb7c64473be6ae9ffa165d448ed90a9a67b1d
    Reviewed-on: https://gerrit.libreoffice.org/64899
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: Icee0b15ad69fadc6e01a50b7f1c6485675ed42b5
    Reviewed-on: https://gerrit.libreoffice.org/64927
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: Iabedfa85dcb06bea8bfb7b0946ef1feafd0eb1d2
    Reviewed-on: https://gerrit.libreoffice.org/64926
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: Ifc4c6777d2b6b45c2dd08a4c62fa794151ad886d
    Reviewed-on: https://gerrit.libreoffice.org/64930
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces
    
    Change-Id: I9e923e6e67393ed460b7641c5c478c00a2a36e0b
    Reviewed-on: https://gerrit.libreoffice.org/64888
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces
    
    Change-Id: I6060aa9759a17cbcb5419586a565688c543cb8f4
    Reviewed-on: https://gerrit.libreoffice.org/64898
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: If125b22f4d77670b82a8951ad72e07d3d7e82364
    Reviewed-on: https://gerrit.libreoffice.org/65120
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Since we're now a good OSX citizen and do all our drawing in the
main thread, I believe the workaround from i#93512 and merged in
commit 81ec6912 ("CWS-TOOLING: integrate CWS i93512_DEV300")
isn't needed anymore. Therefore we can just claim the SolarMutex
and draw. And I couldn't reproduce the deadlock of i#93512 with
this patch applied.

But I already was wrong a few times and many drawing semantics
have changed for OSX 10.14, so I might be wrong again ;-)

Change-Id: Ibbf1c1f394038ee5051bc16d2f3c677f4231b2ba
Reviewed-on: https://gerrit.libreoffice.org/65009
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I10fde27502903c5fdbd474995237502d2636a403
Reviewed-on: https://gerrit.libreoffice.org/65106
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I45b725ee740ea84f6af297338889dc447f279acd
Reviewed-on: https://gerrit.libreoffice.org/65104Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - More pages on Python scripts
    
    Change-Id: I5d8db28da384f52ee835195d3eb889fde0fe33b3
Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/65117
    Tested-by: Jenkins
    

Use range-based loop or replace with STL functions

Change-Id: I063dc78205a4cd982c252a9b62c456e9660b8790
Reviewed-on: https://gerrit.libreoffice.org/65063
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I96208c01deb75cc9e1a5af7a15d7bc94afd28021
Reviewed-on: https://gerrit.libreoffice.org/65105Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Regression from commit 63ff8602.
See thread started at
  https://lists.freedesktop.org/archives/libreoffice/2018-December/081542.html

The Application::SetName is mandatory for DDE to work; otherwise
InitializeDde() in SfxApplication::SfxApplication() fails.

DDE spreadsheet formula expects full name of the target spreadsheet,
including path.

Fixed sheet name (it's "Sheet1", not "Sheet").

Removed redundant tests (former "testRemoveRefreshListener" tests all).

Change-Id: I6299a9ec03c3657a21ad42d0ff87db25cf2be905
Reviewed-on: https://gerrit.libreoffice.org/65079
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The "hides" the hack for native Windows dialogs introduced in
commit 5bb798a9 ("tdf#117295 WIN no main loop shortcut for
OLE dialog") in its own header.

Change-Id: I1f36aad20dec50ae1f296001b51085989afb19f6
Reviewed-on: https://gerrit.libreoffice.org/65100
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>