Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad5
Reviewed-on: https://gerrit.libreoffice.org/62960Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins

Change-Id: I14634cda6d1edcf81ef665d48dd27cabd752571c
Reviewed-on: https://gerrit.libreoffice.org/62981
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie7d728cd36c93d5f398266ee65be0e1bf14a0c97
Reviewed-on: https://gerrit.libreoffice.org/62974
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Id4eee662715246bf58653287fed5ecb954e88dfc
Reviewed-on: https://gerrit.libreoffice.org/62836
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I9f895b7d0a2317a8518dfa7e51e437e54dfb0c13
Reviewed-on: https://gerrit.libreoffice.org/62844
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Unless the underlying column is not nullable and has no default value
this is only a guess, form designer can change it

Change-Id: Ifa403e00b21fdaf86aef383503d54879b25ac62b
Reviewed-on: https://gerrit.libreoffice.org/62969Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

* Update helpcontent2 from branch 'master'
  - related: tdf#121173: double space cleanups
    
    ..and some more improvements (hopefully) 
    
    Change-Id: I17e6656ff0f0274c342b62e72405d396437c8964
    Reviewed-on: https://gerrit.libreoffice.org/62923
    Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
    

Change-Id: I47e67b680a6abdb66020b295f55ee6a73b7b5608
Reviewed-on: https://gerrit.libreoffice.org/62956
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

As the certificate chain can be added after the document was
opened, we need to trigger signature verification every time the
LOK API method getSignatureState is called.

In addition update the tests so that they check the status of a
document that's not signed, a document that was signed but the
certificate chain is not available so the verification fails and
later adding the certificate chain and the verification returns
an OK status.

Change-Id: I44578d0cece5bfc4a2e43fbbcd68b5ea1ccbc38b
Reviewed-on: https://gerrit.libreoffice.org/62276
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

It was used to initialise a virtual device pixel buffer to an
"interesting" pattern, in case actual rendering to it failed. But it
hasn't been needed in a while. And similar code can always be added
temporarily if needed, no need to keep permanently, even in #ifdef
DBG_UTIL.

Change-Id: I650afcb811b903ce3d6d50b9f1eb38c83be68df5
Reviewed-on: https://gerrit.libreoffice.org/62962
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Regression from 9348b322

Change-Id: Ibf9d6b65f0dbcc3a751e3ac5f3dbc28d908d6c25
Reviewed-on: https://gerrit.libreoffice.org/62952Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iad363da3955625c696de843d0a859904e189376c
Reviewed-on: https://gerrit.libreoffice.org/62792
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I720d7d4920ae9c2f5d74ad827e1e214a62fe81a9
Reviewed-on: https://gerrit.libreoffice.org/62947
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I6ca0168abc71b4d9b6d332dc0fd8a3c779fdaa87
Reviewed-on: https://gerrit.libreoffice.org/62524
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I3258268b12cb0914a5e8d1c9b57d7891e83080c6
Reviewed-on: https://gerrit.libreoffice.org/62951Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins

Change-Id: I2b9ea77b48673af3575a3142feea5bed84f75d74
Reviewed-on: https://gerrit.libreoffice.org/62950Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins

Do not move graphic nodes in SwXText::convertToTextFrame()
since it is not reasonable (they are anchored to something that
already moved) and hence it causes errors.

A static function checks wether the current node is a graphic.

A small change in writerfilter was done since a unit test failed:
The condition "m_nAnchorType != 0"  was removed since it is not
reasonable at this place.

Change-Id: I8f27985f6f6c8329483370a7b8baaf9949513f1b
Reviewed-on: https://gerrit.libreoffice.org/60860
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

by avoiding taking the mutex

Also reduce the code that the mutex covers to the minimum necessary.

Change-Id: I115c8a447ec17f4800c39557e8de0bc8c669b47b
Reviewed-on: https://gerrit.libreoffice.org/62936Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

They were removed with fa39a342

Change-Id: I4a717cc9e4ec11dcd3980d8a7f37511417175da7
Reviewed-on: https://gerrit.libreoffice.org/62948Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This was extracted from AfterSigning method and is needed when
we add the certificate chain to the database after the document
was loaded already.

Change-Id: I3087386d0131ce962eb3b588c409542617eb7bfe
Reviewed-on: https://gerrit.libreoffice.org/62275
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

regression from
    commit 16b2b4f2
    Simplify containers iterations in sw/source/ui*

Change-Id: Id77c41acf1cb891ffa23ca1300633031e367d0d1
Reviewed-on: https://gerrit.libreoffice.org/62935Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia2a0d25c3833dfde0cd28337361f3cbd2aa29662
Reviewed-on: https://gerrit.libreoffice.org/62934
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie6a61a5193b7b6d216f924f1abc8627ab605f2a4
Reviewed-on: https://gerrit.libreoffice.org/62931
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

According to code, it is expected that minimized copy of
presentation is proposed with ".mini" suffix as default,
but this does not works right now. As a solution a new
localized prefix "(minimized)" is added to filename.

Change-Id: If869c70a5885a9c917fc7254aa8b0d164a6f5a50
Reviewed-on: https://gerrit.libreoffice.org/62781
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I1437b493f3289b4ac97d061bd71973580571e792
Reviewed-on: https://gerrit.libreoffice.org/62933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

it has been this way since

    commit f333ee45
    Date:   Wed Apr 11 11:54:30 2007 +0000
    INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED

Change-Id: I317efd9538436480a9fc3d37e748b0a51052ef80
Reviewed-on: https://gerrit.libreoffice.org/62932
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I841906973a1a9e7e91ea21a816e69460520efc21

Use that function in the dialog builder instead of having explicit
code in there to check the names.

For now this simply uses a manually curated list of custom widgets. I
used some command line tools to extract the names of custom widgets
used in our .ui files, and then filtered out some I guess (hope) will
not be needed in a mobile app.

For this to work the custom widgets need to have unique names.
Currently that is not the case. Unless I did some mistake, there is
just one case of duplicate name, NotebookbarTabControl, which exists
both in the sfx and vcl libraries. (I simply filtered out that one,
too, for now.)

Change-Id: I29bbf6dfef2b3bde03acfc322495d051a7f275a8

It doesn't have all the images that dialogs need, for instance the
vcl/res/radio1.png.

Change-Id: If7839fecb2358846b92d46a47cce3b97f7556711

Change-Id: I6f4cf36509c2fedf7bed346a07080fe0c67716a2

Not sure about this, but just to catch the eye of the pro.
Git blame says 2012, so maybe it's really no more used

Change-Id: I737f3a1b2803f6ce98cb461350db18d06e0bf981
Reviewed-on: https://gerrit.libreoffice.org/62910Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

This reverts commit 343af46f (ODT
filter: make sure we have a layout before export, 2017-11-29) as it
causes a performance problem with large documents (see bugreport).

I added it initially for the EPUB export, but there this is no longer
needed as commit 3ed8466b (EPUB export,
fixed layout: switch to a metafile-based approach, 2017-12-01) switched
to the better metafile-based approach.

Change-Id: Ie404e23db77b8ded1d29f42b6279a3cd06a574b5
Reviewed-on: https://gerrit.libreoffice.org/62924
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

with Logo syntax, too.

Mutual recursion, for example drawing dragon curve (see in the
unit test of the commit) doesn't need Python syntax any more
to call the function before its definition.

Change-Id: I93426a8c5be394fb4f1203e0490f7fa8d8491597
Reviewed-on: https://gerrit.libreoffice.org/62926
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: If2c89f0f53615f6200b6cd1fb6267cc9b47df927
Reviewed-on: https://gerrit.libreoffice.org/62884
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

the code was creating 4 entries in the array, but potentially not
putting anything there

Change-Id: Ia44aea42b3939842f921d30996c5f10e595fd768
Reviewed-on: https://gerrit.libreoffice.org/62894
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Look for nested if statements with relatively small conditions, where
they can be collapsed into one if statement.

Change-Id: I7d5d4e418d0ce928991a3308fc88969c00c0d0f2
Reviewed-on: https://gerrit.libreoffice.org/62898
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...just like sdt controls already turned off design mode.

I'm not sure why design mode wasn't entirely turned off
right from the start, but I don't want to do that now because
forms are becoming more prominent in Writer. If design
mode is ALWAYS turned off for .docx files, then the workflow
will be different for *new* forms, since writer defaults to on.

Change-Id: I91c771f1ebd5e640da8067d38cb06076d8c50d5a
Reviewed-on: https://gerrit.libreoffice.org/62491
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

::basegfx::utils::createWaveline was invoked with incorrect
parameter, resulted in wavelines rendered along a 4-sided
rectangle instead of a line.

Change-Id: I30f52c95bdb4f804438b04559ba339ba95dee6e1
Reviewed-on: https://gerrit.libreoffice.org/62838
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I4a5ef0b6c490e34f7a4bef82e4b173ec7191dcf3
Reviewed-on: https://gerrit.libreoffice.org/62398
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Insead of custom error dialogs try to use standard LO error
reporting & localization

Change-Id: I199c7770dd884a6c5d9b22075d22ab9a9f2037a8
Reviewed-on: https://gerrit.libreoffice.org/62779
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>