leftover from conversion to using std::vector<Range> instead of
std::vector<Range*>

Change-Id: Iaa2d81b0fac4551f4d1ed685d1e728d5e0ea6929
Reviewed-on: https://gerrit.libreoffice.org/62644
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia124a4af642e449dc05f5bae2d5ca766bd67bd68
Reviewed-on: https://gerrit.libreoffice.org/62388
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I38bd2d434224f90374e088feb5a0f436e6f6a771
Reviewed-on: https://gerrit.libreoffice.org/62639
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

The document properly opens with all sections protected because
document protection (forms view) is enabled. However, when that
setting was toggled off, all sections wrongly became unprotected,
and remained unprotected when round-tripped
(including in Word - so loss of configuration).

Word does protection differently. It opens up in a forms only mode,
but upon enabling editing mode, the individual sections can
still be protected. Only when global enforcement is disabled
do all sections become editable.

So, if global enforcement is enabled, map the section protection to
LO native protection. On startup, the sections will all be protected
because of the global compatibility flag. If the flag is turned
off, then you enter a similar mode to Word's "Edit document" where
the sections are still protected. In LO, *each* section's protection
must be turned off individually to fully disable enforcement.

This patch keeps the same three-step process to fully edit the
entire document, but the meanings take on a different form.
"Compatability: Protect Form" changes from "enforcement" to
"edit document" in concept. BTW, that matches how export works,
where PROTECT_FORM is auto-enabled if any sections are protected.

Section protection in LO can be disabled through
Format - Sections - Write Protection.

Patch initially developed to support tdf#120499.
It depends on an earlier commit in order to round-trip.

Change-Id: I8a2399f79640115d689ae9093792eecef7dbaeec
Reviewed-on: https://gerrit.libreoffice.org/61918
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: I1b8e9d434a682717e09ae1d23470baef55935fe6
Reviewed-on: https://gerrit.libreoffice.org/62664Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I5dc87ec04a7c79359c947ba2786bbe067770904c
Reviewed-on: https://gerrit.libreoffice.org/62665Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I5e1fc327a785e892e1c2f526cce8c58fe1ab928c
Reviewed-on: https://gerrit.libreoffice.org/62413
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iba6eb684366bd60c19e4f28ec76c4d85bd1c4b64
Reviewed-on: https://gerrit.libreoffice.org/62666Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc
Reviewed-on: https://gerrit.libreoffice.org/62667Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I2fb7c2ce3581bf6347a5b6ee85d7e603e2b58800
Reviewed-on: https://gerrit.libreoffice.org/62643Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I6a18502c933937b50a78389b04c5545644d2e3ba
Reviewed-on: https://gerrit.libreoffice.org/62638
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I9c8a40389cc9cc18a017f5ab98aa022856ef301d
Reviewed-on: https://gerrit.libreoffice.org/62642Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins

Change-Id: I8c7592e9bdb212fcbb07655e81faadd07ed880f7
Reviewed-on: https://gerrit.libreoffice.org/62244
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

The intention was to only conditionally warn. Thanks Noel for spotting
my mistake.

Change-Id: Iaa035dba1f834c13a179ef66c3f39777f3843bdb
Reviewed-on: https://gerrit.libreoffice.org/62641Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I463441256f294185349177afb83936230a6c6dea
Reviewed-on: https://gerrit.libreoffice.org/62636
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This reverts commit 02caaef2 ("loplugin:useuniqueptr in
SbiProcDef") and is hopefully easier to follow.

Change-Id: I46be2b3c7a933743795d89fe17a2c499c6983382
Reviewed-on: https://gerrit.libreoffice.org/62548
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Only a few basic attributes for now

Change-Id: I1147e4feaf9eac3664142a678e918a65e9a7b2a3
Reviewed-on: https://gerrit.libreoffice.org/62633
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I367e0a38ca44b6577e79c1cf2c447a85582ce1e3
Reviewed-on: https://gerrit.libreoffice.org/62632
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This broke my Windows build with interesting error messages:

Qt5AccessibleWidget.cxx(772): error C2440: "=": "sal_Int32 *"
kann nicht in "int *" konvertiert werden

Qt5AccessibleWidget.cxx(772): note: Die Typen, auf die verwiesen
wird, sind nicht verknuepft; die Konvertierung erfordert einen
reinterpret_cast-Operator oder eine Typumwandlung im C- oder
Funktionsformat.

Same for line 774.

So actually return the selection parts depending on the provided
int pointers.

Change-Id: Iffbe4481883450b9dacefa867ba7035861d62cdf
Reviewed-on: https://gerrit.libreoffice.org/62635Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

As we already rely on the GlyphItem's font instance, consequently
this removes the SalGraphics GlyphItem based functions. Also
unifies the glyph bound rect cache handling.

An interesting aspect is the rotated glyph bounding box handling
moved from CairoTextRender to FreetypeFont. It doesn't look like
an implementation detail for Cairo, so it may have been a bug.

Change-Id: I81bbb5d8ee98fb77a1eee05568c456f9e4553023
Reviewed-on: https://gerrit.libreoffice.org/62503
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I1d00e975eaf85b5233755abefb952ca1eeacbb4e
Reviewed-on: https://gerrit.libreoffice.org/62630
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ib0808750854c1d59f8d208dbbe4e95045ceb56d0

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I8061ef6a7a8c04baf350844fae1f97836ac03554
Reviewed-on: https://gerrit.libreoffice.org/62399
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Since we can't know the real SalLayoutGlyphsImpl type, we
always have to clone and delete it on assignemt and in the
copy constructor.

Change-Id: I3e3aa1e0271c5ecbb1474a70fae5e63bd7124677
Reviewed-on: https://gerrit.libreoffice.org/62583
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I3b89cb6c24c263a1a8ea4e249ab24256a7d6f3f7

REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags ] ] )

REGEX(Text;Expression) extracts the first match of Expression in
Text. If there is no match, #N/A is returned.

REGEX(Text;Expression;Replacement) replaces the first match of
Expression in Text, not extracted. If there is no match, Text is
returned unmodified.

REGEX(Text;Expression;Replacement;"g") replaces all matches of
Expression in Text, not extracted. If there is no match, Text is
returned unmodified.

Change-Id: I9d26a48f40c64a2704d9d07576c8b1b98b2c7b84
Reviewed-on: https://gerrit.libreoffice.org/62545Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: Ia8b5478b0d2a15f91add4ee76455e73c2c970392
Reviewed-on: https://gerrit.libreoffice.org/62544
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

How to reproduce the problem:

1) Create an ODT file which has an OLE object, where the native data i
an OLE2 container, containing a Package stream, containing a DOCX file.

2) Install some external application on Windows which registers itself
as a handler for the DOCX CSLID [ this is where writing a testcase for
this bug is challenging ].

3) Load the ODT file in hidden mode, e.g. connect to a

 ./soffice "--accept=socket,host=localhost,port=9999;urp;StarOffice.ServiceManager"

process from remote Java, load the file with Hidden=true in the
Arguments parameter of loadComponentFromURL().

4) Save it in a format that reads the replacement graphic of OLE
objects, like HTML or DOC.

Expected result: the replacement graphic is there.

Actual result: the <img> tag has no src attribute (HTML case).

The root cause is that in case the document is loaded in hidden mode
then the IDataObject::GetData() call in OleComponent::getTransferData()
fails, so the OLE objects enters a state where it no longer has its old
replacement graphic, but it doesn't have a new one, either.

Fix the problem by making this update more transactional in
svt::EmbeddedObjectRef::GetReplacement(), so the "document conversion"
scenario (load in one format in hidden frame, save in other format)
works.

Change-Id: I624c372baea56a85fb949bd99046f3af1f258c36
Reviewed-on: https://gerrit.libreoffice.org/62549Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

We don't really care for the palette or even lower bitness of the
original icons, when scaling them. So just convert them to 24bit
to get the best scaling quality.

And also actually fail the OpenGL scaling for 8bit color icons,
instead of handling them as a grayscale image, which results in
"funny" luminance based color icons.

Change-Id: I62ff9e7cd45dbffba81b0db5a0252737b6189059
Reviewed-on: https://gerrit.libreoffice.org/62505
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Needs to be part of Qt5AccessibleWidget

Change-Id: I3543cb3b5834c9967066733f0dbd73e974175892
Reviewed-on: https://gerrit.libreoffice.org/62515
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I184bad8a6915048d425f8baa56d2e5675d4b97d1
Reviewed-on: https://gerrit.libreoffice.org/62512Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

regression from
    commit b4fc9965
    loplugin:useuniqueptr in SdrHdlList

Change-Id: I5f7a8d49f0ce359364933db4c35759118846be2d
Reviewed-on: https://gerrit.libreoffice.org/62543
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Now that we store the LogicalFontInstance instead of the fallback
level, it's not enough to keep a pointer in the glyphs in
SalLayoutGlyphsImpl. We also need a reference to the font, to
keep the font instance alive.

Change-Id: Idc99cf9259af6be672a97ab2c67dbffd9cf29c70
Reviewed-on: https://gerrit.libreoffice.org/62520
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Nobody outside of VCL should deal with GlyphItems.

Change-Id: Id84b0f320bc49f790658f23efe129b92262c2aea
Reviewed-on: https://gerrit.libreoffice.org/62446
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

The FreetypeFont might already have released the font instance of
the glyph, but the glyphs font instance must still be valid, so
use this instead to cache glyph bound rect.

For whatever reason the Windows compiler doesn't accept inline
functions in the GlyphItem struct and wants to export them in
the DLL, even when declared VCL_DLLPRIVATE, so this just uses
static inlines as a workaround.

Change-Id: I4539d91a846a54a05f9648638494e1e99f704b0a
Reviewed-on: https://gerrit.libreoffice.org/62425
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3
Reviewed-on: https://gerrit.libreoffice.org/62539
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ief8157da03f2fa79f97d83bdbb589030ddd82686
Reviewed-on: https://gerrit.libreoffice.org/62538
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The first fixes were wrong and only brought some regression

Change-Id: I5e47393b454ca9dc73d87ac4277fa48a3d8bf38d
Reviewed-on: https://gerrit.libreoffice.org/62530
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I21a100209d9177b80cfb9f4a629fb320626df1b7
Reviewed-on: https://gerrit.libreoffice.org/62511
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

after
    commit 50c63e5c
    pass OutlinerParaObject around by std::unique_ptr

spotted by Mike Kaganski

Change-Id: Id69aafc8b0a0fb06165e3fc0cc6e6a29108b4d1f
Reviewed-on: https://gerrit.libreoffice.org/62540
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>