- 15 Kas, 2018 40 kayıt (commit)
-
-
Michael Stahl yazdı
Change-Id: I6b2df2aee96ab32123d3fa23fd9a2480b3ed3c72
-
Michael Stahl yazdı
Can't tell which chapter/reference fields will be affected by a redline, so we have to either update all of them, or rely on the IDocumentSettingAccess::getFieldUpdateFlags() which lets the SwIdle update the fields, at some later time... Change-Id: I3b9cfd17bd227a18f64dac193f0cc912768810c1
-
Michael Stahl yazdı
Repainting is not enough, values require up-to-date outline visibility etc. Change-Id: I85d99fc65a071279c2d4656a52ff82ed3b2db7d8
-
Michael Stahl yazdı
Change-Id: I386bce6b929e38077c01595de618b89fccdaf5fe
-
Michael Stahl yazdı
Change-Id: Iea24b3823b648066e331dc5e9789c79662727a12
-
Michael Stahl yazdı
With the old Hide implementation this actually would take the last set-field in the redline nodes array section to set the value at the start of the document, because there was no check for that; surely that was wrong... Change-Id: I63fb89ccf0067f1fe375226d6d04cafb6485c5d6
-
Michael Stahl yazdı
... and SwAuthorityFieldType, which needs 2 lists of the fields because each citation may occur multiple times, so their order might change on deletions. This is for when there is a bibliography in the document, and it is set to IsSequence(), i.e., insert Bibliography -> Number entries -> Sort by document position... Change-Id: Iba2c31267aeebacb779713567eeb0aa6659afefb
-
Michael Stahl yazdı
This is quite tricky & somewhat ugly due to the SwValueField base class & we need to duplicate its member too :( It would be possible to filter the deleted fields in SwDocUpdateField::MakeFieldList(), but the problem with that is that the instance is long-lived & might be used with different layout settings, so it's probably better to filter in the 5 or so client functions that iterate over the GetSortList(). Note that this will also filter other fields including database fields, hopefully that shouldn't cause problems. Change-Id: I0cdbc7757fa529598b5dbceec0bd2c4a619be05a
-
Michael Stahl yazdı
Has been like that since CVS import... Change-Id: Iefa49407de90bace5eea2f86170ba8cd29b1cfe7
-
Michael Stahl yazdı
Change-Id: Ifebbaa6ef21ac518f62a726dadaceb97fd5e446b
-
Michael Stahl yazdı
Change-Id: Ied1e89279e3071e0c6c1b414bb23044e6439258c
-
Michael Stahl yazdı
It's only used in one function, just use a local map. Change-Id: I3a79876acf8b31c1a8a14e9f65ada2153e7c773a
-
Michael Stahl yazdı
Change-Id: I3b68a46f68fb4070d26b247a6701b510cc209d9b
-
Michael Stahl yazdı
While at it, rename that to ExpandImpl() so it's unique. Change-Id: I217deb72b4dfdca777e28e18ff56e49863e66640
-
Michael Stahl yazdı
If the bCached=true, it shouldn't matter what the layout is, because the field won't be expanded properly anyway. Except for the SwInputField which disables caching, but that one often has a different code path anyway. For most fields it doesn't matter anyway, e.g. database fields. Change-Id: I628195f43c5d26feba94af0a832386791c072ba1
-
Michael Stahl yazdı
Change-Id: I206d7345525a4de0f9ece6bac575f82ff1f96df8
-
Michael Stahl yazdı
Change-Id: I98530004f2d75b10fc4cd3241b06d513ed57675b
-
Michael Stahl yazdı
Thanks to [loplugin:nullptr] and [loplugin:implicitboolconversion] for finding one of the call sites; 3 current C++ compilers would otherwise have implicitly converted the parameters into nonsense without warning. Change-Id: I3cf6697b37616570fd56fd32da27752983a66f4a
-
Michael Stahl yazdı
The expansion of footnotes (and soon text fields) depends on the layout's mode. In SwXFlatParagraphIterator, just use whatever is SwDoc's "current" layout, should be good enough... Change-Id: Ica3b9eae56b14910c435c0f9c3f8ab6dbcda105f
-
Michael Stahl yazdı
... apparently only used by ToX code; rename uniquely & add layout parameter. Change-Id: I0f94787fecd913912f122a654f183ac59b16e30a
-
Michael Stahl yazdı
... and init it in SwGetRefField::UpdateField(). Change-Id: I69af00678e84214d4a122d8b2d940fcdda5f4ccf
-
Michael Stahl yazdı
Now it can store both the result for Show as well as for Hide mode. Change-Id: I15a14b76a96ef77683cd63039b1a8f5e1e94e4c9
-
Michael Stahl yazdı
Add layout parameter to find the correct outline node. Change-Id: I15477dff18c3e5e34b291a92878d938d04497436
-
Michael Stahl yazdı
Change-Id: I180806bfe40150398fb45f57c7d93e429464f2cb
-
Michael Stahl yazdı
Change-Id: I2d992719c86ec7d0203173c6f9008cf4845b3855
-
Michael Stahl yazdı
GetUndoComment() just returns "$1" and then SwUndoRedlineDelete::GetRewriter() just replaces all of that; seems to work... Change-Id: Iaaa563b8dc6848506a5f8e186248f4f6fb9c80e9
-
Michael Stahl yazdı
Change-Id: Iffb09b9145b72a1ac8710e41a0a7d7ad3abe5c33
-
Michael Stahl yazdı
Reuse some formerly static functions in docnum.cxx Change-Id: I8d6bcca28a4f8a6e197a1c302acdf22ce6de01ff
-
Michael Stahl yazdı
SwCursorShell::LeftRight() and SetCursor(). Change-Id: I71cd382f06a4050c4676864ac50fb268cd099226
-
Michael Stahl yazdı
Change-Id: I4576a464b37e786178a3cb31a0be922f1b55db88
-
Michael Stahl yazdı
Change-Id: I4b5d34d3efd4f49f8b1690ed4c2b063c782b9d20
-
Michael Stahl yazdı
Change-Id: I2cd143baafae09324ad0a439cfad3f916ddb13b3
-
Michael Stahl yazdı
This reuses the IDocumentOutlineNodes code for IDocumentListItems; the only client of it is the field dialog cross reference page. Adapt SwCursorShell::GetContentAtPos() too. Change-Id: I9a9ed464b176dd26bf39969ba94041f995ba8c7e
-
Michael Stahl yazdı
If there already is a merged SwTextFrame and a footnote is being deleted in a non-first node hence UpdateFramesForAddDeleteRedline() is called, the SwFootnoteFrame isn't removed unless by some accident. Just let CheckParaRedlineMerge iterate all top-level nodes. Change-Id: I65ac90636a283d5178b4c0323bcc0ae28b3f1196
-
Michael Stahl yazdı
This is happening in MoveParagraph; the UpdateMergedParaForDelete will reset the pParaPropsNode pointer so move assert below that. Change-Id: I31069578a9bfdb05f01ea778bbe9e9ae43c865c6
-
Michael Stahl yazdı
... if redlining is disabled and MoveNodeRange is called. Change-Id: I8c4e35b1b783446ab9bd888599bcce44222857e8
-
Michael Stahl yazdı
Something must call AddToListRLHidden() on all the nodes. Change-Id: Ibe23f499372b7fd07a2894ee3f90684d53d67aef
-
Michael Stahl yazdı
If redlining is enabled, the selection is copied and so delete redlines become insert redline; better to delete the delete redlines so the insert redline consists only of the visible text. Change-Id: I5f7da96dd957262ccc2b83d0abe6add258b7067f
-
Michael Stahl yazdı
Very tricky... Change-Id: Ic4157d14c2a3ee7c90f103561a376ac6f753a694
-
Michael Stahl yazdı
... for hidden mode. Change-Id: I61f240ee7e4e3b61d53b07170be195c15fd679ae
-