...presumably forgotten when the following casts of nTmp in the SetBaseHeight
etc. calls were changed from USHORT to sal_uInt16 in
7f33ed41 "removetooltypes01: #i112600# Remove
tools types from sw"

Change-Id: I75809e677835910b09b366f755361a667d097402
Reviewed-on: https://gerrit.libreoffice.org/48442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The check against USHRT_MAX was introduced together with a following

  nLen2 = static_cast<UINT16>(nLen);

in 73f043c4 "#96155# #i1858# merge branch and
remove warnings" (and that UINT16 meanwhile replaced with sal_uInt16).

Change-Id: I61346e4ffc90a4f8a97c2d3f822d619faa5b0008
Reviewed-on: https://gerrit.libreoffice.org/48441Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The original code of 7b0b5cdf "initial import"
read

+        long nLen = (    (nNextPieceCp < nBehindTextCp)
+                        ? nNextPieceCp
+                        : nBehindTextCp
+                    )
+                    - nAktStartCp;
+
+        if( 0 >= nLen ) break;
+
+        if( nLen > USHRT_MAX - 1 )
+            nLen = USHRT_MAX - 1;
+
+        if( bIsUnicode )
+            rStr.Append( WW8Read_xstz( rStrm, (USHORT)nLen, FALSE ) );
+        else
+        {
+            ByteString aByteStr;    // Alloc methode automatically sets Zero at the end
+            sal_Char*  pByteData = aByteStr.AllocBuffer( nLen );
+
+            sal_Size nWasRead = rStrm.Read( pByteData, nLen );
+            if( nWasRead != nLen )
+                aByteStr.ReleaseBufferAccess( nWasRead );
+
+            rStr += String( aByteStr, eEnc );
+        }
+        nTotalRead  += nLen;
+        nAktStartCp += nLen;
+        if( nTotalRead != rStr.Len() ) break;

casting nLen to USHORT in the call to WW8Read_xstz, while the current code looks
like it should work fine for larger nLen.

Change-Id: Ie3a0d654ef45421cbbe8e823259e8dfd27bd27e2
Reviewed-on: https://gerrit.libreoffice.org/48437Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...in formula group computation if the formula contains
only a single reference besides any ocOpen/ocClose pairs
wrapping it as the sole content.

In such a case the "result" formula token
returned by ScInterpreter::GetResultToken() is the same
as the original singleref token, so for each row of the
formulagroup, we need to use a separate singleref token.

Also added a unit test in sc/qa/unit/parallelism.cxx

Change-Id: I6032efc5be9b51ca1e9daf9bdd19997a949d2f43
Reviewed-on: https://gerrit.libreoffice.org/48449Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

...presumably forgotten when changing SwEditShell::InsertDDETable parameters
from USHORT to sal_uInt16 in 7f33ed41
"removetooltypes01: #i112600# Remove tools types from sw"

Change-Id: I28ad46bdfb6c95a7d2e0bcbf2ef8eef29217baa5
Reviewed-on: https://gerrit.libreoffice.org/48436Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Icdf57d962ae7b3e24cbed6aba4b05fa2136b3761
Reviewed-on: https://gerrit.libreoffice.org/48433Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which unhelpfully even warns on reinterpret_cast, so causes failures like

> [CXX] sal/osl/unx/signal.cxx
> sal/osl/unx/signal.cxx: In function ‘bool onInitSignal()’:
> sal/osl/unx/signal.cxx:267:50: error: cast between incompatible function types from ‘void (*)(int, siginfo_t*, void*)’ to ‘{anonymous}::Handler1’ {aka ‘void (*)(int)’} [-Werror=cast-function-type]
>                                  oact.sa_sigaction);
>                                                   ^

And since all incompatible (but deliberate) casts between function types across
our code base should already be written as reinterpret_cast, we shouldn't lose
much by just disabling this new warning globally.

Change-Id: If15e9606e8fdc676b61012e31d7369653951ceca
Reviewed-on: https://gerrit.libreoffice.org/48431Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie43c633283be45e72259be5eedd253e403e9f664
Reviewed-on: https://gerrit.libreoffice.org/48377Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I062ea13827d7d9744b0965b305877633485015fa
Reviewed-on: https://gerrit.libreoffice.org/48405Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ibcbfd951d2a7c7862fbc7e6b17c89344ae5bf930
Reviewed-on: https://gerrit.libreoffice.org/48399Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8a145c1024a522a17c6ac2bf961cb4f07f3e7be9

Change-Id: I71d27f3f97e257b4e45261004088ce3435f82090

... at least since other single line styles than SOLID and DASHED
were added some years ago.

This causes an assertion from MSVC std::max in CppunitTest_sw_odfexport.

Change-Id: I2e0833b3d5c5afab259108be1c8782c4c4d26978

Change-Id: I690e6e812d52344faef93b2856ce0f4a22509d2c
Reviewed-on: https://gerrit.libreoffice.org/48396Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9cb59c77a420c975933070eea691cda52b066b0b
Reviewed-on: https://gerrit.libreoffice.org/48397Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9725189846a38860550c651b2428296564824ba8
Reviewed-on: https://gerrit.libreoffice.org/48394Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of type
‘class ScRange’ with no trivial copy-assignment")

Change-Id: I2178697082b1c284d26cedaa64c73b92d9e6aecb
Reviewed-on: https://gerrit.libreoffice.org/48393Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...("error: argument to ‘sizeof’ in ‘char* strncpy(char*, const char*, size_t)’
call is the same expression as the source; did you mean to use the size of the
destination?") in a place where the use of strncpy instead of strcpy (introduced
with 9276f7d5 "fdo#32263") doesn't help prevent
any buffer overflows anyway (the target's size already having been checked to be
sufficiently large).

Change-Id: I70773538f4092f1306fb00f1fa7f9138e06894e5
Reviewed-on: https://gerrit.libreoffice.org/48391Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non-
trivial type ‘struct SbxValues’")

Change-Id: Icf610e692b81030bfd6f2f940c43ee8bf6f1d4e0
Reviewed-on: https://gerrit.libreoffice.org/48389Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

svtools/source/misc/langtab.src is dead since a while.

Change-Id: I373f715d337a47f6ea1e935a7a50565f0e6b3ba2

Add two new properties to SheetCell.idl "FormulaResultType2" and
"CellContentType", because the "FormulaResultType" is returning the
wrong value (com::sun::star::table::CellContentType instead of
com::sun::star::sheet::FormulaResult). Also documeted the curiosity.

Change-Id: Icc6538e155ba27fb9d097d8790ac9b4b230c1446
Reviewed-on: https://gerrit.libreoffice.org/48367Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

...introduced unused with 91b4e453 "new
loplugin: pointerbool"

Change-Id: I3af0ce878f1f2742223d66bcdade4e9c144162cd
Reviewed-on: https://gerrit.libreoffice.org/48387Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I05a1234d7bcbae6f4851abd34ff7acec5853f5f5
Reviewed-on: https://gerrit.libreoffice.org/48329Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I17e617d89d1b5ad92c5c8218958e86ca722b13e2
Reviewed-on: https://gerrit.libreoffice.org/48435Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I20d4304013e12035e522fd1b1e0c201d49961114
Reviewed-on: https://gerrit.libreoffice.org/48434Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7c33d2a64a6b4968e8a83f53f5c893eb5ba268b7
Reviewed-on: https://gerrit.libreoffice.org/48415Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ide16aad0cadd393ce28425ed54c5e77f93d61317
Reviewed-on: https://gerrit.libreoffice.org/48412Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5d5bb6b57a9e9ed2c66d304c18fe7ef233aae072

In fd069bee "initial import" the code was:

+void SfxFilter::InitMembers_Impl()
+{
+    String aExts = GetWildcard()();
+    String aShort, aLong;
+    String aRet;
+    sal_uInt16 nMaxLength =
+#if defined( WIN ) || defined( OS2 )
+        3
+#else
+        USHRT_MAX
+#endif
+        ;
+    String aTest;
+    sal_uInt16 nPos = 0;
+    while( ( aRet = aExts.GetToken( nPos++, ';' ) ).Len() )
+    {
+        aTest = aRet;
+        aTest.SearchAndReplace( DEFINE_CONST_UNICODE( "*." ), String() );
+        if( aTest.Len() <= nMaxLength )
+        {
+            if( aShort.Len() ) aShort += ';';
+            aShort += aRet;
+        }
+        else
+        {
+            if( aLong.Len() ) aLong += ';';
+            aLong += aRet;
+        }
+    }
+    if( aShort.Len() && aLong.Len() )
+    {
+        aShort += ';';
+        aShort += aLong;
+    }
+    aWildCard = aShort;
+
+    nVersion = SOFFICE_FILEFORMAT_NOW;
+    bPlugDataSearched = 0;
+    pPlugData = 0;
+
+    aName = pContainer->GetName();
+    aName += DEFINE_CONST_UNICODE( ": " );
+    aName += aFilterName;
+
+    aUIName = aFilterName;
+}

where USHRT_MAX apparently effectively meant "arbitrarily large".  But when
b7c59605 "INTEGRATION: CWS sfxcleanup" removed
the WIN/OS2 special case it didn't remove all the other code that was now
effectively useless.

Change-Id: I883759f13e0267a189ad176c2ffcc1c78680b0a5
Reviewed-on: https://gerrit.libreoffice.org/48336Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

By default for priniting slides we use not default A4, but size provided
in slide properties.

Additinally renamed IsPageSize() -> IsPaperSize(): it is less ambiguous.

Change-Id: Iaf38dedb32b14cd6fbdd2ad355ecf3208e32663e
Reviewed-on: https://gerrit.libreoffice.org/46407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I006e7fddcb58edb597867e0dd6f2b81ddac3457e

Make the mapping of light weights more likely to hit different enum
values for slightly different weights.

We want to be able to distinguish between for instance Overpass Light
(with weight -0.4) and Overpass ExtraLight (with weight -0.5).

Change-Id: If83fbce68149b267a49ef9bcb6624d8790de7c56
Reviewed-on: https://gerrit.libreoffice.org/48409Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ic12464f01950a5037bb6819a2722aba5a7e3e2e6

> [CXX] vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx:20:
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.hxx:30:
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx:29:
> In file included from workdir/UnpackedTarball/boost/boost/process/child.hpp:22:
> In file included from workdir/UnpackedTarball/boost/boost/process/detail/execute_impl.hpp:24:
> workdir/UnpackedTarball/boost/boost/process/detail/posix/executor.hpp:446:5: error: 'BOOST_POSIX_HAS_VFORK' is not defined, evaluates to 0 [-Werror,-Wundef]
> #if BOOST_POSIX_HAS_VFORK
>     ^

under --enable-gtk3-kde5

Change-Id: Ib4648d1337a493c35b35897dc71c5e971c6eb214

based on i#97605's test cases.

Change-Id: Id7e57914553ba8801a624f667979badc191108e5
Reviewed-on: https://gerrit.libreoffice.org/46152Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Earlier GCC already require a similar workaround to silence -Werror=return-type
("control reaches end of non-void function") a few lines further down, so it's
rather consequential that GCC now also warns about the potential fall-through
here (i.e., for these warnings, GCC apparently assumes that an enum can take on
all of the values from its range of values, not just those denoted by an
enumerator).

Change-Id: I1537a7f6975f900861225ee7a521366a5e57046a

Change-Id: Ica04ee68f18ec6c1e0cd59a0f35ab35ce3c05745
Reviewed-on: https://gerrit.libreoffice.org/48374Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

LO already supports http, https, webdav and webdavs through the
WebDAVContentProvider. Ftp is supported via FTPContentProvider
and then finally we have the GIOContentProvider that can potentially
support SMB, if the dependencies for that are met.

We now configure the KDE file dialog to allow these remote protocols.
Note that this filtering depends on https://phabricator.kde.org/D10024
and https://phabricator.kde.org/D10025 to have any effect.

Then we rewrite the URLs we receive from KIO to a format that is
supported by LO. Most notably, we prepend `vnd.sun.star.` to the
webdav URL schemes, such that they get picked up by the
WebDAVContentProvider. Then finally, we clear the username from
the smb:// URLs we get from KIO, as that prevents GIO from opening
them.

In all cases, the user will get prompted a second time for the
credentials required to access the remote resource. This is
unfortunate, but better than nothing. In the future, we may solve
this issue through either a separate KIO UCP or by getting support
for the FDO Secret Service specification in KWallet.

Change-Id: I91df28434b115639c2698968e2a672b3320bf8e2
Reviewed-on: https://gerrit.libreoffice.org/48350Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Idcd2931415558b41f94eb12a01f350f1ab53d134
Reviewed-on: https://gerrit.libreoffice.org/48319Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only
the file and folder picker are replaced by KDE dialogs. This gives
us a well-maintained GTK LO base with basic KDE integration with
minimum effort.

To prevent issues with nested event loops, the KDE dialogs are
launched from a separate process, the new lo_kde5filepicker helper
executable. A trivial stdin/stdout IPC mechanism transfers the data
between LO and the Qt/KDE helper. The usage of an external process
also allows us to copy'n'paste between LO and the KDE file dialog
without freezing the UI, as would happen when one would do this
in-process. This is in general also the architecture applied by the
kmozillahelper, which is used to integrate KDE file dialogs into
Firefox.

While the KDE dialog is shown, the GTK3 main window is disabled and
close requests are ignored. The KDE dialog in turn also sets the LO
window as transient parent. Together, this makes the illusion perfect
and the KDE dialog behaves like a modal dialog. This works properly
also with multiple LO main windows, and only individual windows will
get blocked as one would expect.

Functionality wise, most of the features of the KDE4 dialog are
supported. You can pick files and folders, and save files under a new
name. Some custom checkbox widgets are supported, but lists, buttons
and preview widgets are not yet implemented. Also, loading remote
files via KIO is not possible yet.

Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829
Reviewed-on: https://gerrit.libreoffice.org/47718Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>