- 07 Agu, 2018 24 kayıt (commit)
-
-
Jan-Marek Glogowski yazdı
The native painting code in the kde5 backend is Qt based only. To prevent multiple inheritance, it's moved into an extra class and just leaves the backend specific QImage blitting in the specific SalGraphics implementation. Change-Id: I3d5f58f42a37966794541fe1214c1b9557376a98 Reviewed-on: https://gerrit.libreoffice.org/58652 Tested-by: Jenkins Reviewed-by:
Jan-Marek Glogowski <glogow@fbihome.de>
-
Jan-Marek Glogowski yazdı
This failed to build to on Haiku with: /sources/core/vcl/qt5/Qt5Bitmap.cxx: In member function 'virtual bool Qt5Bitmap::Create(const SalBitmap&, sal_uInt16)': /sources/core/vcl/qt5/Qt5Bitmap.cxx:155:92: error: invalid cast from type 'unsigned int' to type 'sal_uInt32 {aka long unsigned int}' *image_data = reinterpret_cast<sal_uInt32>(colorTable.at(*buffer_data >> 4)); Change-Id: Ib536901f8c55f854715089bce0ad5d954dd529e9 Reviewed-on: https://gerrit.libreoffice.org/58651 Tested-by: Jenkins Reviewed-by: -
Jan-Marek Glogowski yazdı
In commit bded890a ("Qt5 just release the SolarMutex for Qt event") the Qt5 main loop was switched to running non-locked, as most other backends do, so now we must take the lock when processing Qt events. Eventually CallCallback should be virtual for security? Change-Id: I8cbfc9bb8b3de677a70ad3bd5cb3910fabec9b87 Reviewed-on: https://gerrit.libreoffice.org/58650 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Shows e.g. table cell borders. Change-Id: Ic93fb8bcb11b1d5dc0a3eab88ac7fa33672d177b Reviewed-on: https://gerrit.libreoffice.org/58681 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Takeshi Abe yazdı
Change-Id: I91c4c1d53f1cea0aebbdc2cc1548cad86d5226a4 Reviewed-on: https://gerrit.libreoffice.org/58675 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Maxim Monastirsky yazdı
Regression of 632bc11c ("tdf#117017 Pasting into the formula bar shouldn't retain formatting"). Toggling the overwrite mode sets the EVControlBits::OVERWRITE bit from inside the editeng keyboard handler, so make sure to not override it. Change-Id: I2b5e3fe9cb885ed20e7528fdfe2fd59f5ef05f42 Reviewed-on: https://gerrit.libreoffice.org/58658 Tested-by: Jenkins Reviewed-by:
Maxim Monastirsky <momonasmon@gmail.com>
-
Mert Tumer yazdı
Change-Id: Ieecfad2d0127fec850f7a4f3576a77eec94926b3 Signed-off-by:
Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/58562 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Mert Tumer yazdı
Change-Id: I6afc278908d2afadbf531010ab7e466b9224b9af Signed-off-by:
-
Mert Tumer yazdı
Change-Id: I58a8d104b24c7cf2d021e2dce700e25592c8a605 Signed-off-by:
-
Mert Tumer yazdı
on Android Viewer Signed-off-by:
-
Michael Stahl yazdı
The problem is that AppendAllObjs() doesn't check if MakeFrames() actually created frames, it just assumes success. If there are frames anchored in frames, then it could go through the circular_buffer, find a dependent frame before its anchor frame, unsuccessfully call MakeFrames(), then call MakeFrames() on the anchor frame, and then the vector is empty. A surprising aspect is that push_back on a boost::circular_buffer will silently pop the first element if it's already "full". Possibly this is what caused tdf#112447. 1. insert section 2. in paragraph in section, insert frame 3. repeat 2 4. drag anchor of frame 1 into body of frame 2 5. edit section, click hide 6. edit section, un-click hide 7. only one frame is displayed (regression from 575e222a and/or ce2fce9a) Change-Id: Ie782252ac388524dfb083f655320a50e95239b24 Reviewed-on: https://gerrit.libreoffice.org/58676 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Vincas Dargis yazdı
Add rule to allow creating temporary files like `lu6924jgpjkq.tmp`, because without it files cannot be saved. Change-Id: I640897df5d325e2d01da16840034abbd095fb276 Reviewed-on: https://gerrit.libreoffice.org/58672 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...even with --disable-pch, where CppunitTest_sw_macros_test failed because creating the three iterWrong, iterGrammar, iterSmartTags in SwTextFrame::PaintSwFrame (sw/source/core/text/frmpaint.cxx) happend to have a differnt idea about the size of pointer-to-SwTextNode-member than the WrongListIterator ctor in sw/source/core/text/wrong.cxx. Change-Id: I6acef19c798991cc0fd65f6e8d5cf44485b6d2c6 Reviewed-on: https://gerrit.libreoffice.org/58670 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ibf6d3cb244ddbfc600e6e91564988b9f814a258b Reviewed-on: https://gerrit.libreoffice.org/58668 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ieba632453d7a5f9d1881c01aa81445db9a7158e8 Reviewed-on: https://gerrit.libreoffice.org/58674 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Commit dfee7d93 (sw: get rid of FN_UNO_GRAPHIC_U_R_L and "GraphicURL" property, 2018-03-08) removed support for string-based graphic references, then a later commit restored the setter. But one scenario (when setting the graphic URL before inserting the text graphic object) was still unsupported for real URL setter; restore that as well. Change-Id: I52a7f96e820f614d9d031df3ba03c794984ad68b Reviewed-on: https://gerrit.libreoffice.org/58669Reviewed-by:
-
Stephan Bergmann yazdı
As discussed on #libreoffice-dev: Aug 07 08:48:59 <sberg> vmiklos, the ASan+UBSan bot fails for a while now in UITest_writer_tests, e.g., <https://ci.libreoffice.org//job/lo_ubsan/995/ consoleFull#-14523843999567f988-cbcf-4519-af05-6000b834f13f>; a bit unclear when it started, as it might initially have been hidden by another (meanwhile fixed) issue that stopped the build before reaching this test; I can't reproduce it with my local ASan+UBSan build; I guess something timing dependent, the test code is at sw/qa/uitest/writer_tests/tdf79569.py:32 (i.e., the second .uno:Undo and hits the assert at sw/source/core/layout/findfrm.cxx:1702 (search for it further up in the log), after preceding warnings like "Didn't find wished box"; any idea whether anything there could be timing dependent? Aug 07 09:09:48 <vmiklos> sberg: i'm not sure if any of that is executed synchronously, actually. all of these .uno:Foo commands are dispatched async IIRC Aug 07 09:13:03 <vmiklos> sberg: the easiest i could think of (to find out if my assumption is correct) would be to insert the pyuno equivalent of Scheduler::ProcessEventsToIdle() after the dispatches and see if that helps. (we should have an UNO interface + service that exposes that) Not sure whether all of the executeCommand/executeAction would need to be followed by processEventsToIdle, but probably doesn't hurt to be conservative there (except maybe for increased run time?). Change-Id: Iac64330def636a7b7db958e83feae9ce66d0677b Reviewed-on: https://gerrit.libreoffice.org/58663 Tested-by: Jenkins Reviewed-by: -
Caolán McNamara yazdı
Change-Id: I1063fbe9f41833c70e28343dd8d2392acd579d6d Reviewed-on: https://gerrit.libreoffice.org/58665 Tested-by: Jenkins Reviewed-by:
-
Johnny_M yazdı
This is not a literal translation. Rather, it follows the notions used in the UI, as introduced in commit 79283929 - see https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=cui/source/tabpages/labdlg.cxx;h=41bc3d72ea50e94d31aab369ea5dcdedbb00ddac;hb=79283929ac9b8e56516b70c8381e0c31f1c68645#l86 . This seem to be the legacy callouts described in https://help.libreoffice.org/Common/Callout . Further similar translations in the same files will be done separately later. Change-Id: Iac5f1e34f28f12cd24001c488d35ae3ba3996aea Reviewed-on: https://gerrit.libreoffice.org/58584 Tested-by: Jenkins Reviewed-by:
-
Johnny_M yazdı
Change-Id: Ie23aae867280944a877e5daf1306a703d0fc94ee Reviewed-on: https://gerrit.libreoffice.org/58617 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I664e16e4d61ed11df54bd161ad30c15fc41ce39b Reviewed-on: https://gerrit.libreoffice.org/58648 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
no need for a Deleter class Change-Id: Iee6e9218f4a81dad8c1e932e807dccf61666a0b3 Reviewed-on: https://gerrit.libreoffice.org/58647 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ib2b9963a90a135998b6189fba521bd85f5579cf5 Reviewed-on: https://gerrit.libreoffice.org/58645 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
This was already working for the DOCX import by luck. Make the wrap type explicit, so the ODF import has it correctly. The wrap type for the hidden sw text frame ("textbox of a shape") should be always "through", wrapping is only performed for the surrounding draw shape. Change-Id: Ice28cd5b517d544cfab4900dee32f01b534fee26 Reviewed-on: https://gerrit.libreoffice.org/58656 Tested-by: Jenkins Reviewed-by:
-
- 06 Agu, 2018 16 kayıt (commit)
-
-
Jens Carl yazdı
Change-Id: I15730e0eb76dc08b7751b221a2103af52ba6d8b2 Reviewed-on: https://gerrit.libreoffice.org/58657 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Caolán McNamara yazdı
Change-Id: I2b105221cd90ac224bb140a005ed40c30ad92837 Reviewed-on: https://gerrit.libreoffice.org/58627 Tested-by: Jenkins Reviewed-by:
-
Vikas Mahato yazdı
Change-Id: If8bef32ff4a08edef3bb86f366a7b47d8ac1e397 Reviewed-on: https://gerrit.libreoffice.org/58258 Tested-by: Jenkins Reviewed-by:
Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Vikas Mahato yazdı
Change-Id: I8aea387f5db399e27b2a08224f6c4ac59f26c54c Reviewed-on: https://gerrit.libreoffice.org/58254 Tested-by: Jenkins Reviewed-by:
-
Vikas Mahato yazdı
Change-Id: Icbea042f14ec6559597923f42fee26e666b2cc3c Reviewed-on: https://gerrit.libreoffice.org/58152 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') in files formerly omitted for oversight or non-cxx extension Change-Id: I327c573f44076c6ccfecf737eafccba2da72e1bd Reviewed-on: https://gerrit.libreoffice.org/58600 Tested-by: Jenkins Reviewed-by:
-
Mark Hung yazdı
Unlike odp that has anim:iterate (IterateContainer) node, both parallel time container and interate container appear as p:par in ooxml so that we have to alter the node type in the end. We also have to set the target of the iterate container to make animation work. Change-Id: Ic50b5f1d85716a67712ed1e812bcb0e7f25fb5a8 Reviewed-on: https://gerrit.libreoffice.org/58576 Tested-by: Jenkins Reviewed-by:
Mark Hung <marklh9@gmail.com>
-
Noel Grandin yazdı
instead of making the constructor first perform strlen (normally for the second time). And drop an unnecessary if (.. > MAXSTRLEN) which is impossible to hit, since we check that before adding to this array. Change-Id: I8ef2e027fb4a22e06be81e8b5955350869599d85 Reviewed-on: https://gerrit.libreoffice.org/58597 Tested-by: Jenkins Reviewed-by:
-
andreas kainz yazdı
Change-Id: I23b8d7147cf540bb1ac264e9b113aaec658f8598 Reviewed-on: https://gerrit.libreoffice.org/58638 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Noel Grandin yazdı
Change-Id: If7428654a2577ba67aea57904d2a2b5099c4d602 Reviewed-on: https://gerrit.libreoffice.org/58568 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
No need to convert from an OUString to a sal_Unicode[] and then back again. There is only one ScRawToken allocated so no need to be ultra careful with extra fields here. Change-Id: I279835e83ba02d9d4cf4d724bd8046be6aca1405 Reviewed-on: https://gerrit.libreoffice.org/58580 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ib05e209bfe71bacca99862f0e3266008bb436995 Reviewed-on: https://gerrit.libreoffice.org/58569 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
after commit 9cceba9a make DBG_TESTSOLARMUTEX available in assert builds bt looks like: #0 0x00007faf569074fd in ImplDbgTestSolarMutex() #1 0x00007faf56904df9 in vcl::EventPoster::~EventPoster() #2 0x00007faf4392b452 in AutoRecovery::~AutoRecovery() #3 0x00007faf4392b589 in AutoRecovery::~AutoRecovery() #4 0x00007faf5d03dfc8 in __run_exit_handlers() Change-Id: If72eece22db89b492d8e69d1abb496168e32cb9d Reviewed-on: https://gerrit.libreoffice.org/58636 Tested-by: Jenkins Reviewed-by: -
Miklos Vajna yazdı
Change-Id: I743c0566df36c25b67bdec1eaaa859098f40a1d8 Reviewed-on: https://gerrit.libreoffice.org/58637Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I7385db9e87f8a8f7a4be1f7c52e770e8afcb3a23 Reviewed-on: https://gerrit.libreoffice.org/58615 Tested-by: Jenkins Reviewed-by:
-
Takeshi Abe yazdı
as its instance adds an element only at the end, and no erase. Change-Id: I41dc7c4d0f7d070b7ce0cef2e36ee73c05f342ae Reviewed-on: https://gerrit.libreoffice.org/58635 Tested-by: Jenkins Reviewed-by:
-
