Change-Id: I36e3d7950d64a927ac6f081cf4b163fccd2f4786
Reviewed-on: https://gerrit.libreoffice.org/13549Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

This addresses some cppcheck warnings.

Change-Id: I589e13ee086cffee481954215a97960db656e633
Reviewed-on: https://gerrit.libreoffice.org/13548Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ia528bd301e2f2ee1f7f3b009e3b9c3f395a4dcdb

Change-Id: I149d36a103df51ca78324df3121f51440797e226

Change-Id: I35a89fc3a7f388be783c729c8e3414aba1c5c726

Change-Id: I9c02fdd99504bdee6654d1072559a4afac6532a3

Change-Id: Iebed41cfcc5899387e3defb8d8a0792276349098

Even if it is moved from not a page to a page or vice-versa.
This allows assumptions made in the Base Form wizard to hold,
namely that if one:
1) Creates controls (and their associated shapes)
2) Groups the shapes (in a GroupShape)
Then all the shapes still remember their associated control
and vice-versa.

Change-Id: I31975970e7ea2f7978aea7f753de88ecd8e55234

Change-Id: I91387b354d0034410819dbcb8dc1ad8889fc8f14

Change-Id: I3e79b0b34507b947ac4234bab45265027e445d7f

Change-Id: Ib91120e626f772bb52531c4a35fc70f04cc5c48f

That's what we should refer to later, not the temporary collection we made!

Change-Id: Ie288222c6aefa0f50a0b0878ad83b78909ee56d1

Change-Id: I1e913287229119276fa97f73cb249ed0a0b2c473

as a consequence, successfully delete them

Change-Id: I5dd7b329708dd13f8bfe4a38974c5f6f1202b392

this allows the rest of the code to automagically do the right stuff:
 - get&set position
 - group this control with its label
 - set the label property to the label control
 - ...

Conflicts:
	wizards/com/sun/star/wizards/document/TimeStampControl.java

Change-Id: Ibf3cb0ae82ba5c8a23fde05f6466f8eec8308186

...at least when we can easily not assume it.

shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1

We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.

ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.

The wrong assumptions was leading to the following bugs in the Base
form wizard:

 - Only the first two controls in the form were successfully saved. The
   others were just dropped.

 - Whereas the labels had the proper style (background and text
   colour) applied while creating the document, these were not saved
   successfully

Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8

resolves a shitload of warnings like

warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:426: OElementImport::implImportGenericProperties: unsupported value type!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:443: OElementImport::EndElement: could not set the property "ObjIDinMSO"!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:444: caught an exception!
in function:void xmloff::OElementImport::implApplyGenericProperties()
type: com.sun.star.lang.IllegalArgumentException

Change-Id: Ia598d12e7d9429fe4ad3b1e7173e11e75060a613

Change-Id: I2db8842411e39d7d100d0627f8c930bb3f633d77

Change-Id: Iccb98e50a678e5c53b69fb1052e3dac83cdcf5f5

Change-Id: Iebf7fa5b2335e5c6d71fdba791e49a6378db8a31

This reverts commit 89b3af722cc13a0af06822afe248cdec3b63cfeb.

This reverts commit 534e5676028e41205adba3928f96cd35559b5dca.

Change-Id: I13b50f49658a9ca38dc9a41b219428d5faad70a3

as it forgets its associated control

Change-Id: Ia5bd2212725376ab629f2c271102cea2cff9e823

XShapeGrouper.group returns a XShapeGroup
which is guaranteed to also be a XShape.
If it were not a XShape, this code would not even work
since the first assignment would not work,
since xShapeGroup is of type XShapeGroup.

Change-Id: Ic0d873229a1421c3dc94292d7449614a4b6140a3

Regression from commit 01fc08c0
(fdo#85554 SwXShape: fix getting ZOrder property when doc contains
TextBoxes, 2014-11-20), the problem was that we returned wrong ZOrder of
shapes inside group shapes.

In SwXShape::getPropertyValue(), pObj points to the Writer-interfacing
outermost group shape in case of shapes contained by group shapes, while
GetSvxShape() gives access to the real shape. Given that TextBoxes are
only possible at the highest level (and not inside group shapes), just
check if the two pointers are the same: when not, then no need to
convert anything.

With this, child shapes get back their original ZOrder -- before in case
the group shape had ZOrder=0, all its child shapes had ZOrder=0 as well.

Change-Id: I9c4097154130cd04f6ab2f2082abafc1d4333872

Change-Id: Iaaa3d8a4e8ddf419ecaf75dfa30d1b4a9bc984af

It's more relevant when deciding whether to use OpenCL or not.

Note that we won't use OpenCL for a single formula cell, no matter how large a
calculation it invokes (like =SUM(A1:A1000000), for instance), as a single
cell is not a group.

Change-Id: I66b03c197431c2b4cef96f46b010d99d3e0624fc

Change-Id: Iadfbeb5b97673a8812c90411ff2e49324347ee24

Change-Id: I129c6a250116fdcf78dce63e3b46bb3c789d087d

Change-Id: Id3713657a8a7ff54f8d06e5ee670fcb297686706

Change-Id: I3860e2e54e6a380f8050cdaa63cda52adf70220a

breaks windows build otherwise (fatal erro C1017)

Change-Id: Idae78c621bfb8f989eb33220f015e17a7b7fb92f

Change-Id: I54a1a714cb80f2d41a922416a0b9d94f1e329b57

Change-Id: I3cbd554daa74d2c0d9371cb6f07718edea7b24a0

I forgot that images in menus are automatically shown/hidden
depending on platform. So put these back again

Change-Id: I617fae15dbb9bd8cdfb04e2ae45fb83b4a7666fb

where 6 of the strings are already just string resources, doing a full docking
window res to .ui conversion for the two remaining strings seems overkill

Change-Id: I6d3224f8bb84edcdb784901aa93351c042684a3e

Change-Id: If038dcd198bd9ef8c7057a549b6bf4776c28843d

Change-Id: Ic2175faf247d7c05717d397b8afdb9d90087f1d3

Change-Id: I7f6311c541db507236f6c6ab999aee5db8683f33