Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 30 Ock, 2019 16 kayıt (commit)
    • Stephan Bergmann's avatar
      -Werror,-Wunused-parameter · 1ac54de7
      Stephan Bergmann yazdı 
      Change-Id: I60b67eeabf5f11f0d3ad4de7b5ad11bc5851d474
      1ac54de7
    • Stephan Bergmann's avatar
      loplugin:includeform · fc67d200
      Stephan Bergmann yazdı 
      Change-Id: I8ac8b1cbbf94f405ffef0037b6957b35d44a8f91
      fc67d200
    • Michael Weghorn's avatar
      tdf#122752 gtk3_kde5: Use non-native fpicker for non-Plasma desktops · bf93bae6
      Michael Weghorn yazdı 
      Adding the custom widgets to the native dialog currently depends
on the native dialog using a KFileWidget, which is just the case for
the native QFileDialog implementation on Plasma/KDE5.

In order not to lose custom controls for non-Plasma desktops,
fall back to using the non-native QFileDialog there and adding
the custom controls to its layout.
This was mostly taken over from Qt5FileDialog.
(This is a similar approach as that taken for the kde5 VCL plugin
in https://gerrit.libreoffice.org/#/c/67106/ ).

Adding the controls to the layout returned by 'QFileDialog::layout()'
cannot be used for the native dialog as well, since a nullptr is
returned in this case.

From QFileDialog doc:

> By default, a platform-native file dialog will be used if the platform
> has one. In that case, the widgets which would otherwise be used to
> construct the dialog will not be instantiated, so related accessors such
> as layout() and itemDelegate() will return null. You can set the
> DontUseNativeDialog option to ensure that the widget-based
> implementation will be used instead of the native dialog.

Change-Id: I75fbe7731da28d0dc7df878f4c57e141d4d89902
Reviewed-on: https://gerrit.libreoffice.org/67111Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
Tested-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
      bf93bae6
    • Caolán McNamara's avatar
      crashtesting: crash exporting ooo58458-1.odt to doc · 3a2c2ad8
      Caolán McNamara yazdı 
      since...

commit 8780fa41
Date:   Tue Oct 30 12:23:36 2018 +0100

    svtools: fix lost replacement grpahic when updating it via OLE fails

EmbeddedObjectRef::UpdateReplacementOnDemand is called by a chart during
EmbeddedObjectRef::GetReplacement which resets mpImpl->pGraphic to null

Change-Id: Id473b807582164eeb1791a26f6e0005a240f5989
Reviewed-on: https://gerrit.libreoffice.org/67120
Tested-by: Jenkins
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      3a2c2ad8
    • Katarina Behrens's avatar
      tdf#120772: implement file manager -> LibO DnD · 67b0fcea
      Katarina Behrens yazdı 
      not sure if we should support also other than URL list mimetypes

Change-Id: Ida3f65637247822198b04682a3d1a7c196a24e0c
Reviewed-on: https://gerrit.libreoffice.org/66997
Tested-by: Jenkins
Reviewed-by: 's avatarKatarina Behrens <Katarina.Behrens@cib.de>
      67b0fcea
    • Michael Weghorn's avatar
      tdf#122752 kde5: Use plain qt5 fpicker for non-Plasma desktops · c902b3a9
      Michael Weghorn yazdı 
      Since KDE5FilePicker relies on the Plasma-specific KFileWidget
to be present for inserting custom controls, this doesn't work
on non-Plasma desktops, resulting in missing controls.

Therefore, use a plain (non-native) Qt5FilePicker for the non-Plasma case.

Change-Id: I163af89ecd7eab800d55baa2ce057802caed262c
Reviewed-on: https://gerrit.libreoffice.org/67106
Tested-by: Jenkins
Reviewed-by: 's avatarKatarina Behrens <Katarina.Behrens@cib.de>
      c902b3a9
    • Caolán McNamara's avatar
      ofz#11545 can treat BITFIELDS like COMPRESS_NONE for size sanity check · b10a3c47
      Caolán McNamara yazdı 
      Change-Id: Ic8b0cbe0c7821d287b2233bc015cb888e0e18d88
Reviewed-on: https://gerrit.libreoffice.org/67110
Tested-by: Jenkins
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      b10a3c47
    • Miklos Vajna's avatar
      framework: allow storeSelf() on the main thread · f1e77547
      Miklos Vajna yazdı 
      This is similar to commit 22aa6508
(framework: allow dispatching a command on the main thread, 2019-01-29),
except it addresses the scenario where save is performed with an UNO API
call, not with a dispatched command.

This way both load and save is possible on the main thread, providing a
safe way to interact with documents containing OLE objects on Windows.

Change-Id: I3516c944ece8ed0e26aa13fc9def5857b8344404
Reviewed-on: https://gerrit.libreoffice.org/67109Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
      f1e77547
    • Eike Rathke's avatar
      Resolves: tdf#93951 set remainder as bad string if not parsed as valid · 7d6f30d0
      Eike Rathke yazdı 
      Change-Id: Ieb9fa5e9cd2d5919a36fbe65ced107eab33c72e2
Reviewed-on: https://gerrit.libreoffice.org/67090Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
Tested-by: Jenkins
      7d6f30d0
    • Stephan Bergmann's avatar
      Avoid computing negative nColSpan · f1f84cf7
      Stephan Bergmann yazdı 
      With Clang -fsanitize=implicit-signed-integer-truncation,
CppunitTest_sw_ooxmlexport8 fails with

> sw/source/filter/writer/wrtswtbl.cxx:666:39: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit, unsigned)
>  #0 in SwWriteTable::FillTableRowsCols(long, unsigned short, unsigned int, unsigned short, long, unsigned int, SwTableLines const&, SvxBrushItem const*, unsigned short, unsigned short) at sw/source/filter/writer/wrtswtbl.cxx:666:39
>  #1 in SwWriteTable::SwWriteTable(SwTable const*, SwTableLines const&, long, unsigned int, bool, unsigned short, unsigned short, unsigned short, unsigned int) at sw/source/filter/writer/wrtswtbl.cxx:757:5
>  #2 in DocxAttributeOutput::InitTableHelper(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&) at sw/source/filter/ww8/docxattributeoutput.cxx:3481:31
>  #3 in DocxAttributeOutput::FinishTableRowCell(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&, bool) at sw/source/filter/ww8/docxattributeoutput.cxx:907:9
>  #4 in DocxAttributeOutput::TableNodeInfoInner(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/docxattributeoutput.cxx:4248:5
>  #5 in MSWordExportBase::OutputStartNode(SwStartNode const&) at sw/source/filter/ww8/wrtww8.cxx:4167:26
>  #6 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2812:13
>  #7 in DocxAttributeOutput::WriteFloatingTable(ww8::Frame const*) at sw/source/filter/ww8/docxattributeoutput.cxx:336:17
>  #8 in checkAndWriteFloatingTables(DocxAttributeOutput&) at sw/source/filter/ww8/docxattributeoutput.cxx:396:30
>  #9 in DocxAttributeOutput::StartParagraph(std::shared_ptr<ww8::WW8TableNodeInfo>) at sw/source/filter/ww8/docxattributeoutput.cxx:406:9
>  #10 in MSWordExportBase::OutputTextNode(SwTextNode&) at sw/source/filter/ww8/wrtw8nds.cxx:2181:22
>  #11 in MSWordExportBase::OutputContentNode(SwContentNode&) at sw/source/filter/ww8/wrtw8nds.cxx:3327:13
>  #12 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2727:13
>  #13 in DocxExport::WriteMainText() at sw/source/filter/ww8/docxexport.cxx:1469:5
>  #14 in DocxExport::ExportDocument_Impl() at sw/source/filter/ww8/docxexport.cxx:527:5
>  #15 in MSWordExportBase::ExportDocument(bool) at sw/source/filter/ww8/wrtww8.cxx:3212:19
>  #16 in DocxExportFilter::exportDocument() at sw/source/filter/ww8/docxexportfilter.cxx:86:17
>  #17 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:497:55
>  #18 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:149:23
>  #19 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2411:25
>  #20 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1505:19
>  #21 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2818:39
>  #22 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2675:9
>  #23 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:321:19
>  #24 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3001:46
>  #25 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1672:13
>  #26 in SwModelTestBase::reload(char const*, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:796:20
>  #27 in SwModelTestBase::executeImportExportImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:283:9
>  #28 in testN779642::Import_Export_Import() at sw/qa/extras/ooxmlexport/ooxmlexport8.cxx:746:1

(where nCPos is 23, nOldCol is 2, and nCol is 0).

sw/qa/extras/ooxmlexport/data/n779642.docx processed by that testN779642 is the
only case during `make check` for which the added SAL_WARN_IF triggers.  That
file was added with 874f0a1b "n#779642: ignore
framePr inside table or the table import won't work", leaving its origin
unclear, and trying to open it with at least MS Word for Mac version 16.21 fails
with "could not be opened", so it looks somewhat plausible that computation of
such negative spans should just not happen.

Change-Id: I0d460d04050017f7793ae51dc2a51ebbd3c4c193
Reviewed-on: https://gerrit.libreoffice.org/67075
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      f1f84cf7
    • Balazs Varga's avatar
      tdf#122915 Chart OOXML: Export individual data label prop · 2eac095e
      Balazs Varga yazdı 
      Export the xLabelPropSet instead of the xPropset and the
individual data label formatting will not be disappeared.

Change-Id: Ic8c64543ad1e8b40d6d6a5cb7a9a244923e028f1
Reviewed-on: https://gerrit.libreoffice.org/66995
Tested-by: Jenkins
Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
Tested-by: 's avatarLászló Németh <nemeth@numbertext.org>
      2eac095e
    • Miklos Vajna's avatar
      writerfilter: make members private in RTFSymbol · a16372db
      Miklos Vajna yazdı 
      Change-Id: I8f608908689d9ebe2027bc36bf71b8cf84a016dc
Reviewed-on: https://gerrit.libreoffice.org/67095
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      a16372db
    • Jens Carl's avatar
      tdf#45904 Move XPropertySet Java tests to C++ · b89dbc08
      Jens Carl yazdı 
      Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj.

Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba
Reviewed-on: https://gerrit.libreoffice.org/67101
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      b89dbc08
    • Jan Holesovsky's avatar
      sw: Ctrl + shape insertion was not setting up the layer. · b6b28931
      Jan Holesovsky yazdı 
      The consequence was that the shapes were inserted into the background
layer.

The problem was particularly visible with the LOK, but reproducible on
the desktop too.

Includes unit test.

Change-Id: I16137331f944101e25679ec8c4a034bea658bc57
Reviewed-on: https://gerrit.libreoffice.org/66917
Tested-by: Jenkins
Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
      b6b28931
    • Dmitriy Shilin's avatar
      tdf#107792 vcl/win: introduce ScopedCachedHDC · c2c60eb9
      Dmitriy Shilin yazdı 
      Change-Id: Ia6c5ca98005642bbcce9d9d66bf16a4d4cbed04e
Reviewed-on: https://gerrit.libreoffice.org/66648
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      c2c60eb9
    • Andrea Gelmini's avatar
      Fix typo · 44df356a
      Andrea Gelmini yazdı 
      Change-Id: I01f5a09e65091f460c28f6c18d683f5a3135762e
Reviewed-on: https://gerrit.libreoffice.org/67100
Tested-by: Jenkins
Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      44df356a
  3. 29 Ock, 2019 24 kayıt (commit)