Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d
Reviewed-on: https://gerrit.libreoffice.org/21498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I0cb13cdfbff3bfda13c08cd34a0032121500b4a3
Reviewed-on: https://gerrit.libreoffice.org/21518Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

This brings FontAttributes into line with ImplFont and Font, which is
important to the refactoring work I am doing.

Change-Id: I2a2ca2f18fc7b5be45d6f350c0328fad62bf2bc9
Reviewed-on: https://gerrit.libreoffice.org/21517Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Iab0160bdf664689404ff6fd093b51c0b4d2c4f10
Reviewed-on: https://gerrit.libreoffice.org/21512Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Iffe94aa2ff007d7361af7166f489ebfdb7593fc1
Reviewed-on: https://gerrit.libreoffice.org/21511Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc
Reviewed-on: https://gerrit.libreoffice.org/21510Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I3ae138d1a06d22be42a3cd6f565fba6950208fc6

Change-Id: Id105284fae75945c4c054fcac8c6390a4a62f1e1

/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: warning: type ‘struct SlideshowImpl’ violates one definition rule [-Wodr]
 class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: a different type is defined in another translation unit
 class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: the first difference of corresponding definitions is field ‘mpShowWindow’
     VclPtr<ShowWindow>     mpShowWindow;
                            ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: a field of same name but different type is defined in another translation unit
     VclPtr<ShowWindow>     mpShowWindow;
                            ^
/home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: type name ‘VclPtr<sd::ShowWindow>’ should match type name ‘VclPtr<ShowWindow>’
 class VclPtr
       ^
/home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: the incompatible type is defined here
 class VclPtr
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: warning: type ‘struct SlideShowView’ violates one definition rule [-Wodr]
 class SlideShowView : public ::comphelper::OBaseMutex,
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: note: a different type is defined in another translation unit
 class SlideShowView : public ::comphelper::OBaseMutex,
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: the first difference of corresponding definitions is field ‘mpSlideShow’
     SlideshowImpl*                          mpSlideShow;
                                             ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: a field of same name but different type is defined in another translation unit
     SlideshowImpl*                          mpSlideShow;
                                             ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: type ‘struct SlideshowImpl’ should match type ‘struct SlideshowImpl’ that itself violate one definition rule
 class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase
       ^
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: the incompatible type is defined here
 class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase
       ^

Change-Id: Ibbb7fb6f35f7e2771aef78a38fc4b6adef131845
Reviewed-on: https://gerrit.libreoffice.org/21503Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Change-Id: I23fb9abf2b9462c939d4d9caf699e48ffded3bb4
Reviewed-on: https://gerrit.libreoffice.org/21505Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

/home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:84:8: warning: type ‘struct snewfoil_value_info’ violates one definition rule [-Wodr]
 struct snewfoil_value_info
        ^
/home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:71:8: note: a different type is defined in another translation unit
 struct snewfoil_value_info
        ^
/home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:86:16: note: the first difference of corresponding definitions is field ‘mnBmpResId’
     sal_uInt16 mnBmpResId;
                ^
/home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:73:17: note: a field with different name is defined in another translation unit
     sal_uInt16  mnId;
                 ^

Change-Id: Ic5f5354424188a0889e842e80cb70dd90ecaeff3
Reviewed-on: https://gerrit.libreoffice.org/21504Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Change-Id: I29c88c834a01f8d04a2998ea3edfa95cd0cadb85

Change-Id: I7c4783ab70e7456d30ee86bb1c415e6d54df3285

Change-Id: Iecea747a436de1afe529e024974006a256aa5f5a

Change-Id: I8813b5676504e6de2af70d181fa9e905538fb05c

Change-Id: I02b37ead4f930a91f9e8c6d472ffe0d2991bb78f

Change-Id: I67c259f4da968b9decc4ac95195864a28283d1b5

Change-Id: I15ccdcf7c56a9677fb01646cad96e7c7d9ba7cd4

Change-Id: Id1d5afee85d54c48e2cd14d9604cbbae4b0b8fc2

... also check type of args and throw if it doesnt match

Change-Id: Ic7a45aeab58b79abf3baee4bd3bf6f78fe3fa116

Change-Id: I030c6854e925c2a51b8c40de38e889a96c5ae32d

Change-Id: Id5c83f8dcc19dc5e94a895f1e15bc5dc8e800d9f

Change-Id: I2f5f36fe9b9c7d1ee4289f2af268c25ebf8963d9

Change-Id: Ia06a716f4ddcfd6884f5b9578d7c0b361d3f66f4

Change-Id: I171fe6370d554ace330df254f07b3b2d45693edd

- also use decltype(..) to prevent integer overflow

Change-Id: Id3fd76d79702e01642758db08d74b7a8e0f7f62b

Change-Id: Ic515b7868c747d5ce5ff0856890aa0af9e567339

Change-Id: I77a1c71f1a801e83f861b43e05e456a75fc511da

Change-Id: I4927986485feb665339e6708bb66286a54926ab8

Change-Id: Ic50f66a4a08dab6fd55a14475d1e9a4947e16048

Change-Id: Ie9dd59319a6cba1181388708efc40c2bea76de32

Change-Id: I0d85021ded0b33d9c2c8d2454ad737842323a099

Change-Id: I3fd30be5e84c4a88d2c334f573fc4fc56a03646b

Change-Id: I8451bc5a754332a4cbfaa721324e8256271de05e

Change-Id: I48af7bbb78f33035e6b8369eb460a6fdf5fc96b4

Font accessors:
- GetFamily()
- GetPitch()
- GetWidthType()
- GetWeight()
- GetItalic()
- GetName() <--- shouldn't that be GetFamilyName()?!?
- GetStyleName()

Font mutators did not need to be added.

Font unit tests are testing:
- Setting and getting FontFamily private member
- Setting and getting FontPitch private member
- Setting and getting FontWidth private member
- Setting and getting FontWeight private member
- Setting and getting FontItalic private member
- Setting and getting the family name and style

ImplFont accessors:
- GetFamilyNoAsk()
- GetPitchNoAsk()
- GetWidthTypeNoAsk()
- GetWeightNoAsk()
- GetItalicNoAsk()
- GetFamilyName()
- GetStyleName()

(These "NoAsk" functions are necessary because the default getters call on a function
that checks the configuration for default values, something that is not wanted in all
cases).

Change-Id: Icfbc8b4e5253d55a80892df050b0803dfc7d7c9f
Reviewed-on: https://gerrit.libreoffice.org/21501Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: If7a6eb598a1e121c1c74e520f7e2238016a3e6e0
Reviewed-on: https://gerrit.libreoffice.org/21506Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ifde1184e469fc9a74de007a0caf27750b2ffbcbb

So much so that I think we only need one or the other. As such, I'm
implementing the functionality that is in one of the classes so that
(and vice versa) might eventually be able to use the same class!

Change-Id: I1b32a5a5213ea406a96386ac4a4553cd81d3728d