Change-Id: I8688c65695080804bae22209ed5d4890ced1a8dc
Reviewed-on: https://gerrit.libreoffice.org/66678
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I8b33fcbbf538660703f6cdb9818e8fae2c623be9
Reviewed-on: https://gerrit.libreoffice.org/66674
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...in 113536e9 "Avoid
-Werror=format-{overflow,truncation}="

Change-Id: Ie26abed8c5694a3b26777771737ded2b3b484935

Selection clipboard now should properly get
and set data from/to selection buffer
and not from/to copy buffer.

Related: tdf#122239

Change-Id: Ia5298932ee277385c6f8a587d4fcb8204647c491
Reviewed-on: https://gerrit.libreoffice.org/66577
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

During export of the TOC into DOCX all TOC field parts
should be placed inside one STD frame: field start-begin,
field-separate and field-end mark.

Updated unit test.

Change-Id: I10e37a48160e1dc4f0074c4e2e7621a59f79c2ee
Reviewed-on: https://gerrit.libreoffice.org/66587
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Finally the bugdoc rendering result is reasonable and even looks like a
tree as it should.

Change-Id: I4e7a729afd3d2c5af2e7f41903737bd56be406fa
Reviewed-on: https://gerrit.libreoffice.org/66664Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I6b660ba86ba639935da509623f1041b6fc1debc0
Reviewed-on: https://gerrit.libreoffice.org/66669
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

rather than searching pointer each time

Change-Id: I0db8990b39cce024fbf0bfc6ebd091a5fa210c02
Reviewed-on: https://gerrit.libreoffice.org/66665
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I823a809048905a93f1413e3332dcb5fe18748a4a

Change-Id: Ia46b136f64c2750ed466d86967de9dfe90b4ce65
Reviewed-on: https://gerrit.libreoffice.org/65003
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

error: base class ‘class salhelper::SimpleReferenceObject’ should be
explicitly initialized in the copy constructor

after
    commit 3b16e997
    Date:   Fri Jan 18 15:38:07 2019 +0200
    cleanup SwAuthEntry manual ref-counting

Change-Id: I291a8a4f6c2a6ec38506265f6a0382f89774ecd4

Change-Id: I021d63c9d57f1e0435bcc5f97abc57bc39fece01

Change-Id: I1492c604ac39ce72fe2cfe8804ac15e8c41b9a46

Does nothing. Needed for customer application to proceed. Once we are
further along in getting it to work, we can investigate what the
parameters passed to this ToolsOptionsView method actually are. (This
WordBasic thing is something that has been deprecated since last
century, I suspect, so no wonder it is hard to find authoritative
documentation on it.)

Change-Id: I62a6d6d9abb9364afca110570fa341a2375a77a6

Change-Id: Ia577174fac926295db439349f6caca178b363ba0

End-user VB6 applications might not like the exception. Better to just
ignore.

Change-Id: I42718de7855079e38c7983db39180c184ab7224f

OpenOld() just forwards to the regular Open(), passing empty extra
parameters. CustomizationContext is fully dummy for now.

Change-Id: I167494700853768d971fe16afea35e90a647a00e

Which shows that m_rSdrExport was unused.

Change-Id: I74c305dd2088764c8971bcad09e60b7714eae05d
Reviewed-on: https://gerrit.libreoffice.org/66661Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

...as emitted by at least GCC 8.2 with --enable-optimized, e.g. at:

> In file included from include/rtl/ustring.hxx:37,
>                  from include/cppuhelper/factory.hxx:26,
>                  from unoxml/source/rdf/librdf_repository.hxx:24,
>                  from unoxml/source/rdf/librdf_repository.cxx:20:
> include/rtl/string.hxx: In static member function ‘static std::shared_ptr<{anonymous}::librdf_TypeConverter::Node> {anonymous}::librdf_TypeConverter::extractNode_NoLock(const com::sun::star::uno::Reference<com::sun::star::rdf::XNode>&)’:
> include/rtl/string.hxx:294:27: error: ‘*((void*)(& type)+8).rtl::OString::pData’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          rtl_string_release( pData );
>          ~~~~~~~~~~~~~~~~~~^~~~~~~~~
> unoxml/source/rdf/librdf_repository.cxx:2094:30: note: ‘*((void*)(& type)+8).rtl::OString::pData’ was declared here
>      boost::optional<OString> type;
>                               ^~~~

This appears to be a common pattern of false positives with uses of
boost::optional, common enough to disable the warning globally for affected
compilers, even if there would also be useful findings by that warning (e.g.,
<https://gerrit.libreoffice.org/#/c/66619/> "Fix -Werror=maybe-uninitialized").

I didn't bother to file a GCC bug for the reproducer used in configure.ac,
<https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=maybe-uninitialized>
already shows lots of open bugs in that area, and the documentation at
<https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Warning-Options.html> states that
"GCC may not be able to determine when the code is correct in spite of appearing
to have an error."

(Clang appears to not support -Wmaybe-uninitialized at all, so exclude it from
the configure.ac check, to not have the check's failure result in an unsupported
-Wno-maybe-uninitialized end up on the compiler command line.)

Change-Id: Ifb9ca4c342750eae54f7e1a01506101310484c7e
Reviewed-on: https://gerrit.libreoffice.org/66621
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized.  These are not
actually problems, as in both cases strncpy(p,...,N-1) is used to copy a
string into an area p of length N that has initially been zero-initialized, so
p[N-1] will already contain NUL.  But add the (redundant) p[N-1]=NUL just in
case, and to silence GCC (where the documentation explicitly recommends this
additional write as a way to silence the warning).  Unfortunately, in hstyle.cxx
at least GCC 8.2 with --enable-optimized would still emit the warning, even
though it uses the recommended way of handling it, so needs to be silenced with
a #pragma.

Change-Id: Ie41f420c732c2bfb699903ebd21ce1a89dd2b236
Reviewed-on: https://gerrit.libreoffice.org/66620
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized:

> In file included from vcl/source/gdi/pngread.cxx:27:
> include/vcl/pngread.hxx: In member function ‘bool vcl::PNGReaderImpl::ReadNextChunk()’:
> include/vcl/pngread.hxx:49:12: error: ‘aDummyChunk.vcl::PNGReader::ChunkData::nType’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      struct ChunkData
>             ^~~~~~~~~

The immediately relevant part is initializing

        sal_uInt32 nType = 0;

in the ChunkData ctor, but while at it, also make the Read*Int32 calls in
PNGReaderImpl::ReadNextChunk more robust.

Change-Id: Id6ad10a4382a8d063fd70c7bac595c3693475ca3
Reviewed-on: https://gerrit.libreoffice.org/66619
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized, by making the buffers
large enough for the (hypothetical) largest values of the various date/time
components

Change-Id: I82e9b08fa099546b2d6f29c702e1440df9e6c6e0
Reviewed-on: https://gerrit.libreoffice.org/66618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as emitted by at least GCC 8.2 with --enable-optimized, about trying to
output up to 4 bytes into a destionation of size 3

Change-Id: I42c3c9bb7a0355a7d4a1574c6c65d6f74a97f1dc
Reviewed-on: https://gerrit.libreoffice.org/66617
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie9b605eb5340f9e47a977020a8f3688c2412a3c9
Reviewed-on: https://gerrit.libreoffice.org/66635
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Use range-based loop or replace with STL functions.

Change-Id: Ide655aa3633f548ac38c71b452b0ecfc91ee9128
Reviewed-on: https://gerrit.libreoffice.org/66636
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one

Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e
Reviewed-on: https://gerrit.libreoffice.org/66545
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

And remove the "handle" nonsense and just pass plain honest pointers to
a real type around

Change-Id: Ic49443f5f8b20890d8335088331fff81585e8981
Reviewed-on: https://gerrit.libreoffice.org/66615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If58a22a3d9536ade5f63a3708fd0b6c53f2e21c3
Reviewed-on: https://gerrit.libreoffice.org/66585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Print dialog text's capitalization changed to follow the styles used in GNOME user interface elements.

Change-Id: I718c4776eaa28e98c5209d160cd47e27782b1101
Reviewed-on: https://gerrit.libreoffice.org/66093Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I14fba5feb45ee2f8de5f017b6da95bd1fe4908f8
Reviewed-on: https://gerrit.libreoffice.org/66660
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

* Update helpcontent2 from branch 'master'
  - Removed executable permission on image files
    
    Change-Id: Ia148161e36c046bfd6374c686c5074d8524dbf06
    Reviewed-on: https://gerrit.libreoffice.org/66638
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#121065 Replace SetOperations, Relations Symbols with SVGs
    
    Replace SetOperations, Relations Symbols PNG images with SVG and
    updated 03090800.xhp, 03090200.xhp and Package_html_media.mk
    
    Change-Id: I2066c1e692a4549a5ab9e020adf1d25ceb7d75c0
    Reviewed-on: https://gerrit.libreoffice.org/66643
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update dictionaries from branch 'master'
  - Bring shipped Spanish dictionary up to version 2.4
    
    Change-Id: Ie814270a83d7459d402e8e92dab4959f2f0793e5
    Reviewed-on: https://gerrit.libreoffice.org/66654Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

It passed "make check" on Linux

Change-Id: I9e6779003639e4b90e8fcbe3ef8a7f7dc1ed85f3
Reviewed-on: https://gerrit.libreoffice.org/66652
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I19809e68542d5795310dcfccbaec70fa931c5147
Reviewed-on: https://gerrit.libreoffice.org/66651
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I24ecf429d26c19823cd76128d2b5e0ec3bdf82c7
Reviewed-on: https://gerrit.libreoffice.org/66639Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9872b27450e9b50d8bef33abc267a763d7d516cb
Reviewed-on: https://gerrit.libreoffice.org/66632
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I11fa408a446aa9fd36780392ae10457822acbb68
Reviewed-on: https://gerrit.libreoffice.org/66606Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Calling the DeleteObject function with a stock object does nothing [1].

1. https://docs.microsoft.com/en-us/previous-versions/ms969928(v=msdn.10)

Change-Id: Icfa1eb834dae33132ff49633035d52606e0cc236
Reviewed-on: https://gerrit.libreoffice.org/66646Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0bbe9da97de8a71824888ee0d4387aaa338e40a0
Reviewed-on: https://gerrit.libreoffice.org/66645
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>