- 30 Eki, 2018 21 kayıt (commit)
-
-
Tor Lillqvist yazdı
It seems that on iOS, where we don't have any Java, Python, BASIC, or other scripting, the only thing that would use the C++/UNO bridge functionality that invokes codeSnippet() was cppu::throwException(). codeSnippet() is part of what corresponds to the code that uses run-time-generated machine code on other platforms. We can't generate code at run-time on iOS, that has been known forever. Instead we have used some manually written assembler to handle it instead. We used to have a Perl script to generate a set of code snippets for different cases, different numbers of parameters of the called function and whatnot, but that went away at some stage some year ago. (It is unclear whether that broke the C++/UNO bridge on iOS, or whether the stuff continued to work even after that.) Anyway, this handwritten assembly, or the manual construction of internal data structures for exceptions, or something else, seemed to have bit-rotten. Exceptions thrown with cppu::throwException() were not catchable properly any longer. Instead of digging in and trying to understand what is wrong, I chose another solution. It turns out that the number of types of exception objects thrown by cppu::throwException() is fairly small. During startup of the LibreOffice code, and loading of an .odt document, only one kind of exception is thrown this way... (The lovely css::ucb:InteractiveAugmentedIOException.) So we can simply have code that checks what the type of object being thrown is, and explicitgly throws such an object then with a normal C++ throw statement. Seems to work. Sadly the cppu::getCaughtException() API still needs some inline assembly in the C++/UNO brige. That seems to work though, knock on wood. This commit also adds a small "unit test" for iOS, copied from cppuhelperm to ImplSVMain(). Ideally we should not copy code around of course, but have a separate unit test app for iOS that would somehow include relevant unit tests from source files all over the place. Later. Change-Id: Ib6d9d5b6fb8cc684ec15c97a312ca2f720e87069 Reviewed-on: https://gerrit.libreoffice.org/60506 Tested-by: Jenkins Reviewed-by:
Tor Lillqvist <tml@collabora.com> (cherry picked from commit 7d6be61a) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: I0991b13a7538581642f530bf45a1bba1b1b644d5 Reviewed-on: https://gerrit.libreoffice.org/60505Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
Tor Lillqvist <tml@collabora.com> Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: I0b17c595fc0d169f6393ab8734a1eecb241f59be Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: I7454c10a1547db796554f45f2d630af81a916c55 (cherry picked from commit 59b9fc47) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
(To be used from Xcode projects elsewhere building iOS apps that want to link to iOS code built here.) Change-Id: I39bf2a4ed059930fcfc30c4d2016dfbc698da353 (cherry picked from commit e3bac83b) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Eike Rathke yazdı
Change-Id: Ifea7072922388b2c0b7631fb809b23e2a5524a3c Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
LibreOfficeLight is buildable in master. In this branch I am now trying to make it build for the needs of the "Mobile" app in online.git. Change-Id: I08b1ea0ef74dc5384d3b2edb2607d4a4f031469a Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
jan Iversen yazdı
Change-Id: I4999be84c45fa32d0ae6f62f667b2c7470972f49 (cherry picked from commit 90c22bf8) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: I43c6e841144b6e5f76d2c78e7b78ab41a29c20e5 Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
jan Iversen yazdı
"voided" new formal parameter Change-Id: I7d8849765eb6a2642f48159bae34c3b8bec3a8cd (cherry picked from commit 7c30bf05) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: Ibc2a9d4426e9ef09eb874e7a9fef0ea31cad56d5 (cherry picked from commit 57ba4567) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
jan Iversen yazdı
When not using scripting, there were a number of unresolved symbols. First aproach did not work, so this commit is the more extensive. Change-Id: Iaf78bde10d9a43862d58d1aa8f46b14aa075eddb Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: Ia9263e67c3a4094a58141a8140de66a22accb768 Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: Ia13dc01f86e51064658d5ad9a996c6bd555cbeef (cherry picked from commit 1d6d1eef) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Also, I don't see why we would want to use -miphoneos-version-min=12.0 just because we build against the 12.0 SDK. Use 11.0 as the minimum runtime iOS version for now. Change-Id: Ibbb65c785dc3c96c43413cf8b1f57fe8708bb5f7 Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
They belong in an autogen.input, not in a distro-configs file. Change-Id: I4d9133b7c192d6e95cada51e8c3105b21f0b7985 Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: Ia42daaf0dbb8fcd0230c7cee21a0f5d560885c22 (cherry picked from commit b0bed245) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: If6149dce7a0467a73720e9ea40e54705518f3316 (cherry picked from commit 2b9d6a6c) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
(In master it is disabled for Android, too.) Change-Id: Iee7b31f1b1a498b99f027cc9f5aeb60360213e51 configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Change-Id: Id18bafaaf8f5315a0590687d98ea97952bdf883b Reviewed-on: https://gerrit.libreoffice.org/62624Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
There is no guarantee that if something is wrong, the Application::ShowNativeErrorBox() will manage to show anything, is there? And this code might be invoked in a program that doesn't even have any GUI. So at least try to show the message on stderr, too. Change-Id: Ieb11a6f490c26c773af646ed7e9c3cf6ccb4a669 Reviewed-on: https://gerrit.libreoffice.org/62550Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
- 26 Eki, 2018 1 kayıt (commit)
-
-
Samuel Mehrbrodt yazdı
Not only by hitting the (invisble) frame or the text content. Change-Id: I125f76a102611b628411d8c5acf70e3ed9e5e8fe Reviewed-on: https://gerrit.libreoffice.org/51276Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit d7994364)
-
- 25 Eki, 2018 1 kayıt (commit)
-
-
Tamas Bunth yazdı
And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: I866add99a699150c6550ee7f7ff2ee947e07117c Reviewed-on: https://gerrit.libreoffice.org/61648 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/62318Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
- 23 Eki, 2018 1 kayıt (commit)
-
-
Eike Rathke yazdı
Change-Id: I7578d568d2afe5d3a45b31a8a349cd370b03fc67 Reviewed-on: https://gerrit.libreoffice.org/62204Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4df55ffe)
-
- 20 Eki, 2018 16 kayıt (commit)
-
-
Stephan Bergmann yazdı
Reviewed-on: https://gerrit.libreoffice.org/60657 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a8eb5155) Change-Id: Iab7bc66db94fe02bb3714234d68b3e2fc3569fdf
-
Andras Timar yazdı
Change-Id: If4337153f8b0edb424132ab60b50dc5a89ca25ee
-
Justin Luth yazdı
PROTECT_FORM maps to enforcement = true, not "everything is protected". "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." So, sections should retain their protected on/off status regardless of the value of PROTECT_FORM. My guess was that this was to offset the fact that DOCX import did not import protected status, so this helped to protect the sections that should not be unprotected. A followup patch will address the import side. patch initially developed to support tdf#120499. Change-Id: I8ff6d31711651a4827cbb8520fd68e88273d6799 Reviewed-on: https://gerrit.libreoffice.org/61905 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit fa667b6d)
-
Justin Luth yazdı
Change-Id: Ib4f100d4019643cde893ef1d8643a5c08b55ff8f Reviewed-on: https://gerrit.libreoffice.org/61951 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 2ec0cf50)
-
Justin Luth yazdı
Just because some sections are unprotected doesn't mean that the document should not open in forms mode. MSWord 2016 opens it in "forms view" mode which also doesn't allow editing those unrestricted settings. Only when choosing the "Edit Document" view are the unprotected sections editable - similar to LO turning off the Compatibility: Protect Forms flag. Unfortunately, the "I want to address this" comment was from 2011, so obviously his temporarly solution became more permanent that expected. If this patch now blocks someone from being able to edit a document (because now only the forms components of the document are editable) they can remove the forms protection by going to tools - options - LibreOffice Writer - compatability - and disable Protect Form. patch developed to support tdf#120499 and depends on the patch for tdf#37778. Change-Id: I86e26095ade6b2cf0ab8ea8fc941a92fa672a2f7 Reviewed-on: https://gerrit.libreoffice.org/61901 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 3e2e4907)
-
Justin Luth yazdı
Protection is not related to fReadOnlyRecommended In Word, documentProtection enforcement is a document level setting which is required for the section protection setting to be enforced. formprot: "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." In LO, section protection is honored if it is simply enabled, so only enable a section's protection if the enforcement variable is set. Round-tripping will lose the fact that sections are marked as protected if the enforcement is off. patch initially developed to support tdf#120499 where the focus is on sections, not on read-only and the fake section that was being created. Change-Id: I08c37ea6a9cc8fd1bdf7f36771b2d719bf9c93d6 Reviewed-on: https://gerrit.libreoffice.org/61899Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by:
Justin Luth <justin_luth@sil.org> (cherry picked from commit 8ba20167)
-
Caolán McNamara yazdı
Change-Id: I30a8fb0568f00253f8d7a55eab51279f639b33cc Reviewed-on: https://gerrit.libreoffice.org/61982 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2b276917)
-
Mike Kaganski yazdı
Change-Id: I55814a6b4cdfda93a51621b5b31c166507a7e7a6 Reviewed-on: https://gerrit.libreoffice.org/62005 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 49d304c4) Reviewed-on: https://gerrit.libreoffice.org/62028Reviewed-by:
Eike Rathke <erack@redhat.com> (cherry picked from commit 79511385)
-
Caolán McNamara yazdı
Change-Id: If352e7a0f6e8dab2a9acc9aa2cde56b40cedb50c Reviewed-on: https://gerrit.libreoffice.org/61993 Tested-by: Jenkins Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 392ec204)
-
Caolán McNamara yazdı
Change-Id: I73a617137bf0b3b567181ff817069944076eab0e Reviewed-on: https://gerrit.libreoffice.org/62022Reviewed-by:
Julien Nabet <serval2412@yahoo.fr> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3ec5fb84)
-
Miklos Vajna yazdı
RTF export at the moment exports children of group shapes as a flat shape list. This means that the order inside the group shape is not relevant for the toplevel ZOrder, so just don't write it. (cherry picked from commit 2b920bdc) Reviewed-on: https://gerrit.libreoffice.org/61904Tested-by:
Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1c6bea8e) Change-Id: I870707cb28c2f177c0e5d9cf5328260e76b661f3
-
Caolán McNamara yazdı
Change-Id: Icc13fb7193fb1e7c50e0df286161a10b4ed636c7 Reviewed-on: https://gerrit.libreoffice.org/61969 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit b1c85cdb)
-
Caolán McNamara yazdı
since... commit b4bbb5e5 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls revert the relevant piece, in this case there are two Windows/Contexts getting their settings manipulated, rather than the usual one Change-Id: I0a228aee6aaf1f58b2235fccf14dc63ffa96dd2d Reviewed-on: https://gerrit.libreoffice.org/61317Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0be3a5ee) Reviewed-on: https://gerrit.libreoffice.org/61525 (cherry picked from commit 3e69c24b)
-
Michael Stahl yazdı
This results in a garbage OUString. Change-Id: I03b8030a812d7016df5c29f1341749fbdedf1729 Reviewed-on: https://gerrit.libreoffice.org/61652 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit bf0276f0) Reviewed-on: https://gerrit.libreoffice.org/61674Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 2c93c692)
-
Caolán McNamara yazdı
Change-Id: I0ca70cdb9b80305c5339668d65d2c4c9977e7160 Reviewed-on: https://gerrit.libreoffice.org/61606 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 1d4fd993)
-
Eike Rathke yazdı
The parent is always the ScDBCollection that contains the ScDBCollection::NamedDBs container, not the one the ScDBCollection::NamedDBs was copy-constructed from. Change-Id: Ia409347f3aeb9ad7a5e68da7af727adfac98d6a2 Reviewed-on: https://gerrit.libreoffice.org/60833Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7ea5d339) Reviewed-on: https://gerrit.libreoffice.org/60842Reviewed-by:
Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 8755c986)
-