Change-Id: Ifbd0026b097ff9fbf077dda57f874cfc59da3e45
Reviewed-on: https://gerrit.libreoffice.org/37119Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Subsequent submissions need to pass
'eslint filter/source/svg/presentation_engine.js' w/o error.

Change-Id: If79c43844d48602d19cde8d4dd12d7e7eef674fe

Change-Id: I54a6478522f03706b5d2d10b58857a3de2876ca8
Reviewed-on: https://gerrit.libreoffice.org/37118Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Ported the class BoxSnakesWipe

Change-Id: I024f982998571d5a90252b10f873c0fc344af2ff
Reviewed-on: https://gerrit.libreoffice.org/36902Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

seems like SVGMatrix.translate() and its counterparts doesn't
modify the matrix inplace.

Change-Id: I3ccfbe99f58cd455e291d4d41657a104ec197e83
Reviewed-on: https://gerrit.libreoffice.org/36903Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

SwKernPortion is inserted between different scripts  to
snap the later text portion to the charcter grid if type
of text grid is lines and chars, even if snap-to-char
isn't checked, and create unexpected space there.

It is not necessary because when snap-to-char is not
checked, there would be pitch between characters.

Format all three scripts in the same way and do not
insert kern portion anymore if snap-to-char isn't checked.

Change-Id: I6078b425aa735beb50cc6a6b4eafbba9f91f7132
Reviewed-on: https://gerrit.libreoffice.org/37037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I4ed78efc82a9dad490930351175dc5d501fdc499
Reviewed-on: https://gerrit.libreoffice.org/37114Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

... instead of using simple IDs which are assumed to be one greater than
the slide position everywhere in the codebase.

Use a 16 bit static counter and uniquely assign page ids to SdPage
objects. This helps in identifying which slide was already selected
in second view before any slide is deleted in the first view. Otherwise,
using simple positions to keep track of it leads the second view to end
up selecting the wrong slide after any slide is added or removed in the
first view.

Change-Id: I465cf7ea86899f0e52549062a9e5fa5cd459f978
Reviewed-on: https://gerrit.libreoffice.org/36863Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Change-Id: I8f7a0d5b4b0534c71a32457d58006af0d6ddf133

No diff in workdir/SdiTarget.

BEWARE: If you're going to revert this for whatever
reason, you should also revert the previous commit
that removed the SlotType property from sdi files!

Change-Id: I78cc391a6b47f4672157926eba1b55e786f48f2d

sdi files have two ways to specify the type of a slot:

(a) Put it at the beginning of the first line
(b) Using the SlotType property

Where (b) have higher priority, and (a) is actually
ignored for "method slots" (i.e. the ones that have
parameter parentheses, even empty, and therefore get
the SfxSlotMode::METHOD flag), which is very
confusing.

The goal here is to make exclusive use of (a) for all
kinds of slots, and eventually remove the SlotType
support code from svidl (in a follow-up commit).

Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634

No diff in workdir/SdiTarget.

Change-Id: I53e974c8ccafbbc3675f67b87a0e1b8ff19b6790

Also expand nested methods.

Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN
from sw/sdi/_basesh.sdi which changed the .uno name from
WatercanStyleModeOnOff to StyleWatercanMode, to match the
name in sfx2/sdi/sfx.sdi (it was forced by svidl to have
the same name).

Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d

Drop unused execute method, and fix state method
to match actual use.

Change-Id: I93b86bbe10b48bf7fca7d9068446a698d7dd9036

Change-Id: Ia33dddfba35da3b495aae4edabe80b1a560674cd
Reviewed-on: https://gerrit.libreoffice.org/37111Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

regression since

commit 46a153cb
Author: Chris Sherlock <chris.sherlock79@gmail.com>
Date:   Sun Apr 23 18:53:58 2017 +1000

    vcl: update error codes to defined constants for code clarity

    Change-Id: I6e86c45b71fc15d6645501128e7d86f8e179e652
    Reviewed-on: https://gerrit.libreoffice.org/36851Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Id1a3f26a84c7641b0b6af71dc842a683d0c1dd0c

Change-Id: I6537e818a783ef908e2ae4d068752669529fb75e

Change-Id: If12d46d49936af3a91b2d50ca8fca43596eb4ae5

Change-Id: I15533651b1eff5c00d69f7a1e050997f25addabe

Change-Id: Ic7247a6d0e702572ca304bb048bfabfafcbf7505

when what you really want is std::vector.
Also drop unnecassary use of std::unique_ptr
and constify a couple of methods.

Change-Id: I676ee3460a015b0c7656167c06a569c30c861f98
Reviewed-on: https://gerrit.libreoffice.org/37106Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iaa644b38775477f8f6f329ab55d9d32414ee0738
Reviewed-on: https://gerrit.libreoffice.org/37089Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Useful for group formula logging.

Change-Id: I40a02f0aa88d7c63a641f2a79956236d0db39f15
Reviewed-on: https://gerrit.libreoffice.org/37088Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: I92ac00654b78f7b0d568a825dc879d06e475827c
Reviewed-on: https://gerrit.libreoffice.org/37105Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I38f734af566e954532c288434be84a8553e76b9c

Change-Id: I8b4c2753e56c79348e42f8b9b56f19d7424dd70c
Reviewed-on: https://gerrit.libreoffice.org/37104Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5f33f24aa6fd1685e32c9df11855a26ad891eb5b
Reviewed-on: https://gerrit.libreoffice.org/37096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ic83f0e0491bede43dba7f22c5bd6c31b95e65df1

it also doesn't make sense to numerically compare a %hash
enable warnings in the script and remove a duplicated variable (and
some unnecessary hash-declarations)

Change-Id: I0a84dc28f369931ee31a1cf12849fde2b63f1ca2

Change-Id: I8eb5a3d3141fcc76bf5caffe0a7b30d5ec2b0c8c

Change-Id: I61960512e297417eb096b3bc921974aa43f74ccc

besides using deprecated syntax – "if (defined %hash)" (or "if (defined
@array)" for that matter) – just using "if (%hash)" (or "if (@array)")
would do, it is also unnecessary to create the hash if it doesn't exist
(autovivification will take care of that)

Change-Id: Ib5704b2d609ae3658f3c166f9e26a051957149f8

Change-Id: Ifd86ab3c89c285ad5329fc86cc57967ebd1af91a
Reviewed-on: https://gerrit.libreoffice.org/37100Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I3ab1cc8f8950dc858c8abda27e5eef8c46fe6877
Reviewed-on: https://gerrit.libreoffice.org/37099Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I800b6c4c222a283816251c112b8a69847f5404e4
Reviewed-on: https://gerrit.libreoffice.org/37098Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

When we copy/paste a pivot chart to another (new) document, we
"send" a chart data as ODC to the other document. In the new
document we can't use the pivot table (as there is none in this
document) so we read-in the table data from the document to the
internal data provider.
The problem was that we didn't match the (fake) range names from
the pivot table correctly in the internal data provider and the
data wasn't populated. This commit fixes that and changes the fake
range names to something that is easy to parse and matches the
names in internal data provider.

Change-Id: I9872160cca68abd91738a25bf9b3b27bc77ce38d
Reviewed-on: https://gerrit.libreoffice.org/37086Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0e9363f6aa6f9d1011bc917645122408f9728ca2
Reviewed-on: https://gerrit.libreoffice.org/36794Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If13f6d800b857cc6d581ef7800beb0f25b3f5a37
Reviewed-on: https://gerrit.libreoffice.org/36793Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If3abc80f8511d9c7bf0d5197ce28ef4cf60a6b45
Reviewed-on: https://gerrit.libreoffice.org/36792Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Id4ebdf875b8ae02b786fd703d2559594acb8b4be
Reviewed-on: https://gerrit.libreoffice.org/37081Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>