Change-Id: I735005f2e311abf7b64cce6b67002fe6e0d60281

Change-Id: I62e953c886886158f227362fef7048459192217b

Change-Id: Ib188b2a8dbfbc91f2e89952d6df2c0c357091a78

ScGlobal::FindUnquoted
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32
  - remove last two parameters because noone was using them

ScCompiler::GetDocTabPos
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32

inputhdl.cxx/lcl_MatchParenthesis
  - return -1 instead of STRING_NOTFOUND
  - change return type from xub_StrLen to sal_Int32
  - make function static, no-one outside this module is using it

Change-Id: I141ab082db180ff2da5a7ca6813cd3607b9ea7f7

And convert some xub_StrLen to sal_Int32 in the same patch of code.

Change-Id: I72c92bf9413dbca14688cb8d46a023df49a5d41a

The code was interchangably using the two anyway.

Change-Id: I4f3fe8f1d699a9725bbcce0138a9d978a1eff28a

...otherwise running e.g. "soffice slot:5410" would crash with

> Invalid read of size 8
>  at 0x712DCCC: SfxItemSet::~SfxItemSet() (svl/source/items/itemset.cxx:317)
>  by 0x65B4990: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166)
>  by 0x65B2CC4: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166)
>  by 0x674CD94: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:784)
>  by 0x674CF46: SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:376)
>  by 0x674D03E: non-virtual thunk to SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:378)
>  by 0x4F21028: desktop::DispatchWatcher::executeDispatchRequests(std::__debug::vector<desktop::DispatchWatcher::DispatchRequest, std::allocator<desktop::DispatchWatcher::DispatchRequest> > const&, bool) (desktop/source/app/dispatchwatcher.cxx:581)
>  by 0x4F2CDB3: desktop::OfficeIPCThread::ExecuteCmdLineRequests(desktop::ProcessDocumentsRequest&) (desktop/source/app/officeipcthread.cxx:1061)
>  by 0x4EE3159: desktop::Desktop::OpenClients() (desktop/source/app/app.cxx:2493)
>  by 0x4EE14E7: desktop::Desktop::OpenClients_Impl(void*) (desktop/source/app/app.cxx:2012)
>  by 0x4EE0127: desktop::Desktop::LinkStubOpenClients_Impl(void*, void*) (desktop/source/app/app.cxx:2007)
>  by 0x927B9E6: Link::Call(void*) const (include/tools/link.hxx:123)
>  by 0x999AD8F: ImplHandleUserEvent(ImplSVEvent*) (vcl/source/window/winproc.cxx:1976)
>  by 0x9997E64: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (vcl/source/window/winproc.cxx:2591)
>  by 0x99ADCFC: SalFrame::CallCallback(unsigned short, void const*) const (vcl/inc/salframe.hxx:243)
>  by 0x99ACD47: SalGenericDisplay::DispatchInternalEvent() (vcl/generic/app/gendisp.cxx:91)
>  by 0x1783C027: GtkData::userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:935)
>  by 0x1783C13D: call_userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:945)
>  by 0x37B6847E05: g_main_context_dispatch (usr/src/debug/glib-2.36.3/glib/gmain.c:3054)
>  by 0x37B6848157: g_main_context_iterate.isra.22 (usr/src/debug/glib-2.36.3/glib/gmain.c:3701)
>  by 0x37B68481FB: g_main_context_iteration (usr/src/debug/glib-2.36.3/glib/gmain.c:3762)
>  by 0x1783AC3F: GtkData::Yield(bool, bool) (vcl/unx/gtk/app/gtkdata.cxx:576)
>  by 0x1783FEF6: GtkInstance::Yield(bool, bool) (vcl/unx/gtk/app/gtkinst.cxx:425)
>  by 0x9299F40: ImplYield(bool, bool) (vcl/source/app/svapp.cxx:364)
>  by 0x9295B52: Application::Yield() (vcl/source/app/svapp.cxx:396)
>  by 0x9295B1F: Application::Execute() (vcl/source/app/svapp.cxx:345)
>  by 0x4EDE2C9: desktop::Desktop::Main() (desktop/source/app/app.cxx:1715)
>  by 0x92A6397: ImplSVMain() (vcl/source/app/svmain.cxx:162)
>  by 0x92A7B55: SVMain() (vcl/source/app/svmain.cxx:198)
>  by 0x4F35980: soffice_main (desktop/source/app/sofficemain.cxx:85)
>  by 0x40098C: sal_main (desktop/source/app/main.c:48)
>  by 0x400966: main (desktop/source/app/main.c:47)
> Address 0x1d719700 is 0 bytes inside a block of size 32 free'd
>  at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>  by 0x6A02EA1: CntItemPool::~CntItemPool() (sfx2/source/explorer/nochaos.cxx:123)
>  by 0x6A02C85: CntItemPool::Release() (sfx2/source/explorer/nochaos.cxx:154)
>  by 0x6A02BF8: NoChaos::ReleaseItemPool() (sfx2/source/explorer/nochaos.cxx:89)
>  by 0x65E1A31: SfxApplication::Deinitialize() (sfx2/source/appl/appquit.cxx:147)
>  by 0x65A29B0: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:242)
>  by 0x65A2828: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:223)
>  by 0x65C021C: SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:121)
>  by 0x65C033E: non-virtual thunk to SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:123)
>  by 0x1F176DD2: framework::Desktop::terminate() (framework/source/services/desktop.cxx:353)
>  by 0x1F177E1B: non-virtual thunk to framework::Desktop::terminate() (framework/source/services/desktop.cxx:357)
>  by 0x4F217FD: desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:637)
>  by 0x4F2190E: non-virtual thunk to desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:640)
>  by 0x674CD77: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:782)
>  ...

Change-Id: I6b4fb9b6f0d2afc9caecf3dd5355d11edb6abbe8

Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f

Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b

Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07

-added postpone method for vml export in docxattributeoutput

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
        https://gerrit.libreoffice.org/6366

Change-Id: I37586447547e2e09028f7ae5009bcfaa87a35678

The other filter associated with the .dot extension is
writer_MS_Word_95_Vorlage, obviously the 97 one should be preferred.
With having one filter as preferred for this extension, plain
'--convert-to dot' starts to work.

Change-Id: I7207d0fcb3c55b8dcc7b6179ccfa33a7c85d2ce8

Change-Id: I26894edd3962c2b2856d2bfa4a4aa4e6f4e65c9e

Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71

Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44

Change-Id: Ic71774a8e6c4ffc8267b940b8b253e4526512435

Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd

Change-Id: Ib6cc0f089e9b3cbcfee67c6a780527e148f3c382

Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0

Change-Id: I467334094a621f4bab0ff251267412fb3a0fb4b7

Change-Id: I748f9a1f214245b96c04da7a92dad43512fea47e

Change-Id: I60bbdd2a2592a1e5333abe50711aa227786ce935

Change-Id: Idf73eb831f52d4d74e6fbb6ea27f59ebbfd13a8c

Change-Id: I75b5a0e6739991b234819bd11ce901b90f68ffba

Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3

Change-Id: I05d96875b9d1deb87dadd63f446080a6fe3494a9
Reviewed-on: https://gerrit.libreoffice.org/6630Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d

Change-Id: I5790d7e0c15ac837865597da6ab8a165a5291813

Change-Id: I2d40c589eb3b5c99300f36cd705c32cf824b2a98

Change-Id: I87dd775949d1d3cc2c191e84e57b49cd66ecc750

-- so it does not need to check it again

Change-Id: Id6fc2732bde8dd7f6011828b6bc29d7947bf6312
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/6629Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I52a5b2d7d3302ba887364e7bf5b377bf93394406

Change-Id: Ib286fa65ee54a09a78686b8b11453228c4196910

error: The project 'MobileLibreOffice' does not contain a scheme named
'MobileLibreOffice'

Change-Id: If722a222407f1e85086d9d89d7863be7a5c8368e

Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23

Change-Id: I7a20f89e5a113c6c8760d51475d8198e28ad6aac

Change-Id: I46c5655904cecb6807b218e613cbcdbb6fd236e8

Despite the comment in salwtype.hxx, and despite it being set, before
4e7495ac the mbDeltaIsPixel flag had not been
used for anything on OS X (or other desktop OSes). So when the code was
modified for the sake of touch devices to do take mbDeltaIsPixel into
consideration, that code path was incorrectly taken also on OS X leading to
incorrect scrolling.

Change-Id: I7cbca4656037eefce963e976f6acf8fbb32d5269

Change-Id: Id6e984cff8c171099e3bf0ec6940a28b4000b2e9

Change-Id: I8a4d15a7d7948a19df0fb8a585969d56f9918772