This was added in commit 2fcf3a87
(ooxml: preserve gradient shape fill, 2014-01-31), and assumes that the
theme colors can be preserved, as the theme definition is grab-bagged as
well.

But the theme is grab-bagged only for DOCX, not for PPTX, so skip
gradient grab-bag for PPTX, otherwise the gradient would refer to
incorrect colors in the theme.

Change-Id: I98e1c67d4b10e68916f81dd7fc508eb4146d506b
Reviewed-on: https://gerrit.libreoffice.org/67386Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/72681Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Take over missing case from 'KDE5FilePicker::initialize' to
'Qt5FilePicker::initialize' and make
'Qt5FilePicker::addCustomControl' virtual, so that the
subclass's implementation is called in the 'initialize()'
method (in particular to avoid adding another autoextension
checkbox).

Drop the 'KDE5FilePicker::initialize' so that the
base class implementation is used, which now does the
same thing.

Add 'override' keyword in KDE5Filepicker.hxx.

Change-Id: Id151a4d4862af4275f6c21c6537a79c52e3ed513
Reviewed-on: https://gerrit.libreoffice.org/68059
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 77d5795f)
Reviewed-on: https://gerrit.libreoffice.org/72656

Add an option to Qt5FilePicker constructor to
say whether the QFileDialog should be a native one or not,
since 'QFileDialog::selectFile' does not preselect the correct
name in the native dialog any more if the
'QFileDialog::DontUseNativeDialog' option has ever been set, i.e.

    QFileDialog fileDialog;
    fileDialog.setOption(QFileDialog::DontUseNativeDialog);
    fileDialog.setOption(QFileDialog::DontUseNativeDialog, false);
    fileDialog.selectFile("test.txt");

will not properly set the name in the native file dialog, which
broke 'setDefaultName' for the KDE5FilePicker.

This makes it work again, even though I think that the underlying
issue is a Qt bug
(s. https://bugreports.qt.io/browse/QTBUG-73682 ).

Change-Id: I99a1e7c97d594925d600fa8eaf3303f9013551c2
Reviewed-on: https://gerrit.libreoffice.org/68058
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 1d01ebc8)
Reviewed-on: https://gerrit.libreoffice.org/72655

Use the custom controls widgets from the parent class
Qt5FileWidget and drop the own class members that were
used for this.

Also call the base class's implementations for the methods
that interact with the custom controls.
Since the native Plasma/kde5 file picker handles automatic
file extensions by itself while the non-native qt5 one does
not, the methods in KDE5FilePicker only forward those
method calls that are not related to the corresponding
control ('CHECKBOX_AUTOEXTENSION').

Change-Id: Ia2de3211ffba7814683914a5e629208b19b2ed82
Reviewed-on: https://gerrit.libreoffice.org/68057
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 0b93a6c3)
Reviewed-on: https://gerrit.libreoffice.org/72654

preserving SmartArt allows editing it in PowerPoint after saving as pptx file

* moved common parts for docx and pptx export to oox/drawingml
* fixed export tests that expected shapes on output

Change-Id: I3e70a9f4177bebf5e1671232f4cd0ef0e7212626
Reviewed-on: https://gerrit.libreoffice.org/69598
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/72474

At least building on Flathub makes presence of this information a hard
requirement now (see <https://blogs.gnome.org/hughsie/2019/03/28/
new-appstream-validation-requirements/> and witness the failed
<https://flathub.org/builds/#/builders/32/builds/3597>).

The suggested way to calculate that information is via the form at
<https://hughsie.github.io/oars/generate.html>, which I filled in as follows
(the answers I selected are prefixed with "=>"):

> By answering all the questions you can generate AppStream-compatible markup
> for the upstream AppData file.
>
> If the user is able to "enable" NSFW or "adult" content, then this should be
> included in the assessment even if it is turned off by default.
>
> What type of component are you generating content for:

=> Application that can connect to the Internet

> OARS has multiple versions, and the newer versions include more questions
> involving specific cultural and religious sensitivities. What version of OARS
> metadata do you want to produce:

=> 1.0 (works with all clients)

> Advertising
>
> Defined as the activity of producing advertisements for commercial products or
> services.
>
> For example, this would include banners showing the Coca-Cola logo shown in a
> Soccer game.

=> None

> Gambling
>
> Defined as taking a risky action in the hope of a desired result.
>
> For example, this would include spinning a wheel to get in-app credits.

=> None

> In-App Purchases
>
> Defined as items or points that a user can buy for use within a virtual world
> to improve a character or enhance the playing experience.

=> None

> Online Text-only Messaging
>
> Defined as any messaging system connected to the Internet.

=> None

> Online Audio and Video Messaging
>
> Defined as any multimedia messaging system connected to the Internet.

=> None

> Contact Details
>
> Defined as sharing identifiable details with other users to allow out-of-band
> communication.

=> None

> Information Sharing
>
> Defined as sharing information with a legal entity typically used for
> advertising or for sending back diagnostic data.
>
> For example, this would include sending your purchasing history to Amazon.

=> None

> Location Sharing
>
> Defined as sharing your physical real-time location.
>
> For example, this would include uploading the GPS co-ordinates of your current
> location. NOTE: This does not include heuristic based location services, e.g.
> GeoIP and others.

=> None

> The following markup can be pasted into the existing application AppData file.
>
> <content_rating type="oars-1.0" />

Change-Id: I063484d8031892c20f88999c5a9beeae3666511c
Reviewed-on: https://gerrit.libreoffice.org/72581
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 0a136095)
Reviewed-on: https://gerrit.libreoffice.org/72667Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6bdb9aa89a8a5181b096f47f90ab6fb5711e7447
Reviewed-on: https://gerrit.libreoffice.org/69541
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 9e37ab4e)
Reviewed-on: https://gerrit.libreoffice.org/72661Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This includes some not-so-nice lifetime handling of the button
"clicked" connection handling. I decided to keep the code in
one place, simply always forcing a disconnect on show, instead
of a more "optimized" code version in SetFrame.

First we try to get the icon from the system theme, but use LO's
own icon theme as a fallback.

Change-Id: Ic0459623ec907b9a54bef4670bf65cf587cd47ea
Reviewed-on: https://gerrit.libreoffice.org/71784Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 8ea988f5)
Reviewed-on: https://gerrit.libreoffice.org/71931
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Take over functionality from 'KDE5FilePicker::addCustomControl'
that has not been implemented in qt5 one yet.

Change-Id: I9690e163b3b739bfec6813d9a4e1e0170b730187
Reviewed-on: https://gerrit.libreoffice.org/68056
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit c5947393)
Reviewed-on: https://gerrit.libreoffice.org/72653

Directly access member 'm_pExtraControls' from parent class
Qt5FilePicker for managing custom widgets, rather than maintaining
an own one.

This is meant as an intermediate step, further refactoring will
follow.

Change-Id: I0568d3db68dc24042e198d36f4b5e49608f93a0e
Reviewed-on: https://gerrit.libreoffice.org/68055
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 2bd0400a)
Reviewed-on: https://gerrit.libreoffice.org/72652

Turn existing functions in Qt5FilePicker into protected
static class methods and reuse them in KDE5FilePicker.

The qt5 implementation covers everything that kde5 had,
and a little more (e.g. covers case 'ControlActions::DELETE_ITEM'
in 'handleSetListValue' as well).

Reviewed-on: https://gerrit.libreoffice.org/68054
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 0dda9db8)

Change-Id: I9673b20e3313c0628a76f0d94e018327f4af8523
Reviewed-on: https://gerrit.libreoffice.org/72651
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Base class's 'Qt5FilePicker::cancel' already does nothing
just the same way.

Change-Id: Ie125d117f27849b29f082c72e320c1021e81163e
Reviewed-on: https://gerrit.libreoffice.org/68053
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 424ffe29)
Reviewed-on: https://gerrit.libreoffice.org/72650

The non-native QFileDialog automatically adds the file extension
for the selected filter in the listbox, therefore it was stripped
from the filter title in 'Qt5FilePicker::appendFilter'.

Since the native Plasma/kde5 file dialog does not add it automatically,
introduce a new member 'm_bShowFileExtensionInFilterTitle' to specify
whether or not to strip the extension and set it accordingly in
KDE5FilePicker (so that it continues to show e.g.
"ODF Text Document (.odt)" instead of just "ODF Text Document").

This allows for KDE5FilePicker to reuse the base class implementation
and thus to drop all related own members and methods.

Change-Id: Icfb77d065160d3f655e3e89ad69de4195781373a
Reviewed-on: https://gerrit.libreoffice.org/68052
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit fee0bf03)
Reviewed-on: https://gerrit.libreoffice.org/72649

Base class's 'Qt5FilePicker::setDescription'
does the same, namely nothing.

Change-Id: Ie89a1e1edaf20c49a1b16f43000a4a054b21f3b2
Reviewed-on: https://gerrit.libreoffice.org/68051
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 3035db41)
Reviewed-on: https://gerrit.libreoffice.org/72648

Use base class's 'Qt5FilePicker::getDirectory' instead
to reduce duplication.

Strictly speaking, the 'KDE5FilePicker::implGetDirectory'
implementation used by 'KDE5FilePicker::getDirectory'
suggests that the display directory is returned
rather than the selected directory, and the same
method 'implGetDirectory()' was actually previously used
by the 'KDE5FilePicker::getDisplayDirectory()' method
as well (removed in a previous commit).

The code worked fine inside KDE5FilePicker (where the
native Plasma/kde5 file dialog is used) but would lead
to incorrect results when used inside Qt5FilePicker, e.g.
for the following scenario

* open  folder picker displaying $HOME that contains
  a directory "bar"
* do a single mouse click on the "bar" directory
* click "OK"

The call to 'toOUString(m_pFileDialog->directoryUrl().url())'
inside 'getDirectory()' would return '$HOME/bar' for the native
QFileDialog on KDE Plasma 5, but '$HOME' when
used with the non-native QFileDialog

Anyway, the implementation inside 'Qt5FilePicker::getDirectory'
works fine for both cases, so just drop the KDE5FilePicker one.

Reviewed-on: https://gerrit.libreoffice.org/68050
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit fa738707)

Change-Id: I86dcf98ed310636b899ad289d8a8a8fa263dd2e9
Reviewed-on: https://gerrit.libreoffice.org/72647
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Base class's 'Qt5FilePicker::getDisplayDirectory'
does the same.

Change-Id: I835603848736a328d0cf63b0bdc87895761e229c
Reviewed-on: https://gerrit.libreoffice.org/68049
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit d5ac5eb5)
Reviewed-on: https://gerrit.libreoffice.org/72646

Base class's 'Qt5FilePicker::disposing' is the same.

Change-Id: I91069385541a519f006d10b0580104f14beb551e
Reviewed-on: https://gerrit.libreoffice.org/68048
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 1542aad2)
Reviewed-on: https://gerrit.libreoffice.org/72645

Change-Id: I4680cc4a8507d0d2409301b62ab81165fcfcdba1
Reviewed-on: https://gerrit.libreoffice.org/68047
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 6d00c53f)
Reviewed-on: https://gerrit.libreoffice.org/72644

... and related signals/slots.

Those from the Qt5FilePicker base class do the same thing,
except for one 'SolarMutexReleaser' that was commented out
in 'KDE5FilePicker::getFiles' for no apparent reason since
that line was added in commit 8fb0881a.

Take over the slightly nicer syntax for the range-based for loop
from 'KDE5FilePicker::getSelectedFiles' to
'Qt5FilePicker::getSelectedFiles'.

Change-Id: I419f933d256f3b85eccaea85803b4890770efa24
Reviewed-on: https://gerrit.libreoffice.org/68046
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit e180574f)
Reviewed-on: https://gerrit.libreoffice.org/72643Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

... and related signals/slots.
They are the same as in the Qt5FilePicker base class.

Change-Id: I115d0daa6beace44b9c791fc892d7cf553c562bb
Reviewed-on: https://gerrit.libreoffice.org/68045
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 9c960a6b)
Reviewed-on: https://gerrit.libreoffice.org/72642

Base class's 'Qt5FilePicker::setTitle' is the same.

Change-Id: I071bf5f962c2d8b0821d78e97793c8637f5c0a1b
Reviewed-on: https://gerrit.libreoffice.org/68044
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 4a5761b6)
Reviewed-on: https://gerrit.libreoffice.org/72641

Drop the 'm_xListener' member and methods using it.
The inherited Qt5FilePicker methods do the same thing.

This also avoids that two methods are called when
a file or filter is selected, since the
'QFileDialog::filterSelected' and 'QFileDialog::fileSelected'
signals had been connected to slots in both, the
qt5 and kde5 fpicker constructors.

Change-Id: I60e3eda29e6497f51165e87d0c4ab2e17f209a1c
Reviewed-on: https://gerrit.libreoffice.org/68043
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 1e9148f9)
Reviewed-on: https://gerrit.libreoffice.org/72640

Drop the '_dialog' member from KDE5FileDialog and use
the one from Qt5FileDialog instead.
Move up 'm_bIsFolderPicker' to Qt5FilePicker.

Also, move some of the related functionality from
the kde5 file picker to the qt5 one, in particular
take over missing parts from 'KDE5FilePicker::setMultiSelectionMode'
to 'Qt5FilePicker::setMultiSelectionMode' and drop the
former (now inherited from the base class).

This e.g. also makes sure that only folders are available
for selection when using a FolderPicker in qt5
(e.g. in the dialog to add a JRE in "Tools" -> "Options"
 -> "Advanced"). The functionality had only been implemented
for kde5 beforehand.

Since the QFileDialog is set to non-native mode in
Qt5FilePicker constructor, native mode needs to be
excplicitly enabled again for kde5.

Since Qt's signal/slot mechanism is used to connect
signals on the object in both constructors
(Qt5FilePicker/KDE5FilePicker), some events will
trigger multiple actions. This will be taken care
of in subsequent commits, along with further
refactoring.

Change-Id: I245d46c12945acb91c9b52dcff5c83248ac087dd
Reviewed-on: https://gerrit.libreoffice.org/68042
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 0e496318)
Reviewed-on: https://gerrit.libreoffice.org/72639

While this does not make much sense by itself as of now,
it will allow to reduce code duplication in follow-up commits.

Change-Id: Ie1a9bf3e516044ad5e56c526d1cf49cf1cb76f8a
Reviewed-on: https://gerrit.libreoffice.org/68041
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 77c0c38e)
Reviewed-on: https://gerrit.libreoffice.org/72638

Change-Id: Ie956560885fd9bb9e7367018a2f6e37a26c3c6af
Reviewed-on: https://gerrit.libreoffice.org/72495Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ibc12e52d075c7bc7c33b7c25841cfd122d6c014e
Reviewed-on: https://gerrit.libreoffice.org/72452
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I8fd0ebc336c222184485f72eb7c9d97922ab1386
Reviewed-on: https://gerrit.libreoffice.org/72497
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ieaf341dd13e06046044f3523c3aad74476160402
Reviewed-on: https://gerrit.libreoffice.org/69328
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/72473

before that there were imported two GroupShapes:
	- empty one with properties like id, name, InteropGrapBag
	- second one with actual shapes

also fixed tests that relyed on that behaviour

Change-Id: I2b94a53e21666b16725c4353448d75e916e4f9df
Reviewed-on: https://gerrit.libreoffice.org/69252
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/72472

it will allow to preserve SmartArt when saving PPTX files

Change-Id: I9bb66c59d202b4ce426864599014d042d4aa04b0
Reviewed-on: https://gerrit.libreoffice.org/68916
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/72471

.. if the original shape fill is defined with a theme

Override the alpha value with the current value get from
FillTransparence API attirbute even if the color is defined
with a style or a color scheme.

Reviewed-on: https://gerrit.libreoffice.org/72596
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 259d01a3)

Change-Id: I09d26238a9c2b501279e6749687dc535e614bbd6
Reviewed-on: https://gerrit.libreoffice.org/72618
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

SwLinePortion::Truncate() called in
SwTextFormatter::FormatReset() delete the portion referred
by m_pFirstOfBorderMerge.

Change-Id: I68e134c86db617d37ea2efa09dad4409772146b5
Reviewed-on: https://gerrit.libreoffice.org/72300
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
(cherry picked from commit 96acebb7)
Reviewed-on: https://gerrit.libreoffice.org/72512Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Write the correct theme path to the InteropGrabBag, the same path
what is generated and checked in the export code.

Reviewed-on: https://gerrit.libreoffice.org/72500
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit a8bba60e)

Change-Id: I32617c1a11cf3bafb142f7c8839b498aaac49aa0
Reviewed-on: https://gerrit.libreoffice.org/72521
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

this seems to have been wrong for a very long time, but we used
to get away with it back in the .src era with presumably amusingly
random strings from other parts of the ui shown in the summary
of changes are of the organizer page of the dialog

Change-Id: If223182170ba8519d7899f8044f01c2a12f4e391
Reviewed-on: https://gerrit.libreoffice.org/72491Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins

In a filepicker, user can select any file filter ('All files' for
example) and still choose to open .odb file. Specific UIName of
the current filter ('ODF Database' in this case) shouldn't therefore
be a hard requirement, the correct file extension is enough.

Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24
Reviewed-on: https://gerrit.libreoffice.org/72377
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit dc17f247)
Reviewed-on: https://gerrit.libreoffice.org/72453Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I7d712426ff82242fd1a53779ad1e7df6d6fa86d9
(cherry picked from commit b5bc0d40)

so just Window:SetUpdateMode was called, not also
SvTreeListBox::SetUpdateMode

Change-Id: I37a91f8aff6e8a2399cb7cacfcdc6b3f8b1f44ab
Reviewed-on: https://gerrit.libreoffice.org/72451Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins

* Update translations from branch 'libreoffice-6-2'
  - update translations for 6.2.4 rc2
    
    and force-fix errors using pocheck
    
    Change-Id: Ic143bd8070d7f8ef2c46265a88cfc215717c807c
    

Regression from commit 8c73b16f (DOCX
import: declare wpg as a supported feature, 2013-12-05), the problem was
that <wpg:graphicFrame> did not forward to to the relevant oox context,
and also Writer had no idea how to create a
com.sun.star.drawing.OLE2Shape. Fix the later by using the same service
name that's in use for the non-groupshape case.

(cherry picked from commit fdf4aaa3)

Change-Id: Id3536854da7c1f01525bb38d801496ecebd4c161
Reviewed-on: https://gerrit.libreoffice.org/71524Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I58a7391aec0c5cb3b5b5feb6be1ab3ecac2f0d5e
Reviewed-on: https://gerrit.libreoffice.org/72356
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 3490c872)
Reviewed-on: https://gerrit.libreoffice.org/72363Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>