Kayıtlar (commit) · 207d8b88ecf43a945745194dc999348e570a5264 · LibreOffice / core

01 Kas, 2018 8 kayıt (commit)

loplugin:useuniqueptr in ContentImplHelper · 207d8b88

Noel Grandin Eki 29, 2018 yazdı

Change-Id: I56909fcaf8088a353bbd0bb783c88d51b9f0822f
Reviewed-on: https://gerrit.libreoffice.org/62654
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

207d8b88

loplugin:useuniqueptr in SalFrame::PostEvent · 478f3f01

Noel Grandin Eki 30, 2018 yazdı

Change-Id: Ib066b1d6df90f330f2f93ec639bd7bc59a08c024
Reviewed-on: https://gerrit.libreoffice.org/62507
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

478f3f01

use unique_ptr in markForDeletion · 9375e542

Noel Grandin Eki 31, 2018 yazdı

Change-Id: I10e5ad02243c7045d51191c735163ee4a027126e
Reviewed-on: https://gerrit.libreoffice.org/62695
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

9375e542

rename RemoveX->Remove in SfxUndoArray · 15c86cad

Noel Grandin Eki 31, 2018 yazdı

accidentally left it this way when doing
    commit 19e71597
    Date:   Mon Oct 29 16:15:27 2018 +0200
    loplugin:useuniqueptr in MarkedUndoAction

Change-Id: I250676df7af27f485c5d34281ef0da1e127eb24c
Reviewed-on: https://gerrit.libreoffice.org/62694
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

15c86cad

tdf#120920 Assertion failure when switching slide layouts with text entered · ef9bfdfe

Noel Grandin Eki 31, 2018 yazdı

no need to call StartListening here, has already been done inside
SdPage::CreatePresObj

Change-Id: I590e51f7afeb336d562d3ad9ccc123f542897aae
Reviewed-on: https://gerrit.libreoffice.org/62689
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ef9bfdfe

fix pyuno compile on Fedora29 · 485ec8e1

Noel Grandin Eki 31, 2018 yazdı

'PyUnicode_GetSize' is deprecated [-Werror,-Wdeprecated-declarations]

Change-Id: Id298d6a2b0af9ce418f9124c9addda55fcdc0318
Reviewed-on: https://gerrit.libreoffice.org/62687
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

485ec8e1

drop LISTBOX_ERROR · d4e96a36

Noel Grandin Eki 31, 2018 yazdı

almost nobody checks it, so rather just assert

Change-Id: Ic3ad4c04c4f6013db3e8757559d3a773df020a1d
Reviewed-on: https://gerrit.libreoffice.org/62684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

d4e96a36

Clean up file by sorting entries · 2f1a4e0a

Jens Carl Eki 31, 2018 yazdı

Change-Id: If24bcf1a3c6aaa6929230e379e364507a5d5fe9b
Reviewed-on: https://gerrit.libreoffice.org/62713
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

2f1a4e0a

31 Eki, 2018 32 kayıt (commit)

mysqlc: Add support for mediumnint and char types · e33424dd

Tamas Bunth Eki 31, 2018 yazdı

When reading column types from information schema, it can be mediumint
and char types as well. Mediumint should be 3 bytes long. We can use
sal_Int32 for that.

Change-Id: Id3507b1f38cabfb96800fc7743c911e36609a346
Reviewed-on: https://gerrit.libreoffice.org/62697
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

e33424dd

Re-introduce the functionality to look for multiple iOS SDK versions · ef15830d

Tor Lillqvist Eki 31, 2018 yazdı

Currently, look for 12.1, 12.0 and 11.4. (But of course I recommend
people keep their Xcode updated, and thus now build against the 12.1
SDK.)

Also get rid of two AC_SUBST variables that were not used anywhere.

Change-Id: Ic1abf3eb1d900c843263dc781fd4c9a8ab126f09

ef15830d

replace StartExecuteModal with StartExecuteAsync · 9d1c68ae

Caolán McNamara Eki 31, 2018 yazdı

Change-Id: I2c0e0266f6bb468ebb5285f95d1824cf12100812
Reviewed-on: https://gerrit.libreoffice.org/62690
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

9d1c68ae

Handle also css::ucb::NameClashException>(aException · 97be9270
Tor Lillqvist Eki 31, 2018 yazdı
```
Change-Id: I979a163e796418d9a693229698b638cec4bf2226
```
97be9270

Current iOS SDK is 12.1 · 741e19f7

Tor Lillqvist Eki 31, 2018 yazdı

It sucks that configure.ac nowadays looks for exactly one specific
version of the iOS SDK. I don't understand why that was thought to be
a good idea.

Change-Id: I5b67e17c627735bbafffc8177f1422813a33e034

741e19f7

tdf#119630 Fix lost focus in Sidebar menu · 4f1903a0

Jim Raykowski Eki 31, 2018 yazdı

Focus to document after deck selection or customization from the sidebar
menu.

Change-Id: I315fecfe7bfaedf4c751b1c240e08b80daa77221
Reviewed-on: https://gerrit.libreoffice.org/62677
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

4f1903a0

tdf#120540 draw/impress UI: add Format / Table submenu · 72ec2c80

Justin Luth Eki 12, 2018 yazdı

Although these commands were available in context menus,
there was no main menu access to these commands.

Also:
-cleanup unused context/popup labels related to table items.

Change-Id: Ia574c3783bb279e869c2b8c716f6fb394aa21873
Reviewed-on: https://gerrit.libreoffice.org/61715
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

72ec2c80

Fix xmlSecSize size mismatch · 3ea3611b

Mike Kaganski Eki 30, 2018 yazdı

Since commit 9630a2df,
CppunitTest_xmlsecurity_signing on Win64 segfaults:

===
[CUT] xmlsecurity_signing
/usr/bin/sh: line 1: 10188 Segmentation fault      ( PATH="C:\lo\src\core\instdir\program;C:\lo\src\core\instdir\program;C:\lo\src\core\workdir\LinkTarget\Library;C:\lo\src\core\workdir\UnpackedTarball\cppunit\src\cppunit\DebugDll;$PATH" $W/LinkTarget/Executable/cppunittester.exe $W/LinkTarget/CppunitTest/test_xmlsecurity_signing.dll --headless "-env:BRAND_BASE_DIR=file:///$S/instdir" "-env:BRAND_SHARE_SUBDIR=share" "-env:BRAND_SHARE_RESOURCE_SUBDIR=program/resource" "-env:UserInstallation=file:///$W/CppunitTest/xmlsecurity_signing.test.user" "-env:CONFIGURATION_LAYERS=xcsxcu:file:///$I/share/registry xcsxcu:file:///$W/unittest/registry" "-env:UNO_TYPES=file:///$I/program/types.rdb file:///$I/program/types/offapi.rdb" "-env:UNO_SERVICES=file:///$W/Rdb/ure/services.rdb file:///$W/Rdb/services.rdb" -env:URE_INTERNAL_LIB_DIR=file:///$I/program -env:LO_LIB_DIR=file:///$I/program -env:LO_JAVA_DIR=file:///$I/program/classes --protector $W/LinkTarget/Library/unoexceptionprotector.dll unoexceptionprotector --protector $W/LinkTarget/Library/unobootstrapprotector.dll unobootstrapprotector --protector $W/LinkTarget/Library/vclbootstrapprotector.dll vclbootstrapprotector "-env:CPPUNITTESTTARGET=$W/CppunitTest/xmlsecurity_signing.test" ) > $W/CppunitTest/xmlsecurity_signing.test.log 2>&1
warn:sfx.appl:18084:18824:sfx2/source/appl/app.cxx:191: No DDE-Service possible. Error: 16399
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon !
warn:basic:18084:18824:basic/source/uno/namecont.cxx:973: Cannot access extensions!
warn:basic:18084:18824:basic/source/uno/namecont.cxx:973: Cannot access extensions!
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:291: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully.
HEAP CORRUPTION DETECTED: after Normal block (#1570713) at 0x00000197AC7E5AB0.
CRT detected that the application wrote to memory after end of heap buffer.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:346: xmlSecDSigCtxVerify() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully.
HEAP CORRUPTION DETECTED: after Normal block (#1585431) at 0x00000197AC7E7BF0.
CRT detected that the application wrote to memory after end of heap buffer.
SigningTest::testDescription finished in: 3332ms
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon !
SigningTest::testECDSA finished in: 550ms
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon !
SigningTest::testECDSAOOXML finished in: 466ms
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon !
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes!
SigningTest::testECDSAPDF finished in: 433ms
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully.
warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:346: xmlSecDSigCtxVerify() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully.
===

The problem is mismatch between sizeof(xmlSecSize) in xmlsec and LO:
xmlsec uses 32-bit integer, while LO uses 64-bit. Crash happens in
XMLSignature_MSCryptImpl::validate(), when pDsigCtx->manifestReferences
address is incorrectly retrieved and passed to xmlSecPtrListGetSize.

Despite the comment in xmlsecurity/inc/xmlsec-wrapper.h mentioned that
the XMLSEC_NO_SIZE_T isn't used in xmlsec for MSVC, it's actually used
there since commit 1cf0cd6f0f19c34a23228f7de691187887081dff. So we need
to enable it for MSVC, too.

Change-Id: I05a4f4f6700c178d28886a7ac203469c41d7048b
Reviewed-on: https://gerrit.libreoffice.org/62676Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

3ea3611b

Update git submodules · 45d8fb0b

Andras Timar Eki 31, 2018 yazdı

* Update dictionaries from branch 'master'
  - typo: Typographica -> Typographical
    
    Change-Id: I9e9dc28dcb27ec466a5beecb1141f82489c803b1

45d8fb0b

Translate German comments · 2a06d784

Johnny_M Eki 30, 2018 yazdı

Change-Id: I94cdb753d01dfd0d5b8f78ede1819b281b840ab2
Reviewed-on: https://gerrit.libreoffice.org/62669
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2a06d784

Update mdds to 1.4.3. · ee401edf

Kohei Yoshida Eki 31, 2018 yazdı

Change-Id: I26f06c230533ed72c2b60ce5c9230bbd0a0db2e4
Reviewed-on: https://gerrit.libreoffice.org/62679
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

ee401edf

Update git submodules · f53422ab

Olivier Hallot Eki 31, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - tdf#121073 fix Presenter console shorcuts
    
    Change-Id: If932427763d8f4c352bd53b7d5a9161293188ad1
    Reviewed-on: https://gerrit.libreoffice.org/62691
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

f53422ab

qt5 a11y: Implement QAccessibleEditableTextInterface · 1c712a44

Samuel Mehrbrodt Eki 31, 2018 yazdı

Change-Id: I21106ac31484c4bf47363e3805315c5fb698e172
Reviewed-on: https://gerrit.libreoffice.org/62682Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

1c712a44

-Werror,-Wunused-parameter · d72c9157
Stephan Bergmann Eki 31, 2018 yazdı
```
Change-Id: I32713889f92f56bd1ec711116ac8232a6a462163
```
d72c9157

fix clang -fpermissive warnings in Qt5AccessibleWidget · ce382378

Noel Grandin Eki 31, 2018 yazdı

error: converting to ‘bool’ from ‘std::nullptr_t’ requires
direct-initialization

Change-Id: Id002e2bf0363ddde1a1172cf6364180dbcac64ee

ce382378

lok: new function to add certificate to certificate DB · 08c3c504

Tomaž Vajngerl Eki 24, 2018 yazdı

Also needed to extend XCertificateCreator with a new method
"addDERCertificateToTheDatabase".

Change-Id: I7b4df65365893bd5a0628aeec30b3156584849fe
Reviewed-on: https://gerrit.libreoffice.org/62273
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

08c3c504

tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/ · 7513af89

Gabor Kelemen Eki 23, 2018 yazdı

Found with bin/find-unneeded-includes after recent improvements
- remove UNO headers from blacklist
- remove newly found unneeded fw declarations
- fix up some not self contained headers

Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf
Reviewed-on: https://gerrit.libreoffice.org/62264
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

7513af89

oox: remove dead QuickDiagrammingLayout · f4818faf

Miklos Vajna Eki 30, 2018 yazdı

This would create a com.sun.star.drawing.DiagramShape, and work with
that, but nobody implements such a service.

Change-Id: Iaaed3ace95d86e52ba50e059ab89698197709189
Reviewed-on: https://gerrit.libreoffice.org/62671
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

f4818faf

sw: turn on clang-format for docxtablestyleexport · 42cbd5aa

Miklos Vajna Eki 30, 2018 yazdı

This had (consistent) manual formatting before, but recently I broke it.

Change-Id: Ifd925797c5599aa55852b2e2fb7d16c5812cd159
Reviewed-on: https://gerrit.libreoffice.org/62673
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

42cbd5aa

Fix qt5 build after · 441a8c57

Samuel Mehrbrodt Eki 31, 2018 yazdı

Change-Id: I4d8a2212006cb82a106c30b491b58e23a6e1aa7b
Reviewed-on: https://gerrit.libreoffice.org/62680Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

441a8c57

qt5 a11y: Add table selection support · a5123f05

Samuel Mehrbrodt Eki 30, 2018 yazdı

Change-Id: I4e655a2b4c6a0057935ac5e47c93b16e763d4357
Reviewed-on: https://gerrit.libreoffice.org/62675
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

a5123f05

qt5 a11y: Implement QAccessibleTableInterface · aca43029

Samuel Mehrbrodt Eki 30, 2018 yazdı

Change-Id: Ic632a2253afb960cda43f84905dd519e9052c0eb
Reviewed-on: https://gerrit.libreoffice.org/62668
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

aca43029

lok: Get the object shell from the document · 15018316

Tomaž Vajngerl Eki 24, 2018 yazdı

Change-Id: Id62c0db3c9f404aaab70de0a73a20b2bb57b0393
Reviewed-on: https://gerrit.libreoffice.org/62272
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

15018316

loplugin:useuniqueptr in ParagraphObj::ParagraphObj · cdb75065

Noel Grandin Eki 30, 2018 yazdı

Change-Id: I4c5dcdad18988381b64479cad077234978437795
Reviewed-on: https://gerrit.libreoffice.org/62661
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cdb75065

loplugin:useuniqueptr in PPTTextObj::PPTTextObj · 2a8f860a

Noel Grandin Eki 30, 2018 yazdı

Change-Id: Ib150ecf2dbcc0e3be1d7b1d4daba6065605597ee
Reviewed-on: https://gerrit.libreoffice.org/62660
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2a8f860a

loplugin:useuniqueptr in SfxSplitWindow · 7b8e5bbf

Noel Grandin Eki 30, 2018 yazdı

Change-Id: I30ece3781df9f705c96f9fc69e2b2a943625f6b3
Reviewed-on: https://gerrit.libreoffice.org/62659
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7b8e5bbf

loplugin:useuniqueptr in Accelerator · ea277ae7

Noel Grandin Eki 29, 2018 yazdı

Change-Id: I4dbca6a57ea150067f734b2edb79e750b3ff9745
Reviewed-on: https://gerrit.libreoffice.org/62656
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ea277ae7

loplugin:useuniqueptr in UcbLockBytes::SetSize · a3d31cab

Noel Grandin Eki 29, 2018 yazdı

Change-Id: Ie968bedac6abb8f76705e30eaaebb74fed949883
Reviewed-on: https://gerrit.libreoffice.org/62655
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

a3d31cab

loplugin:useuniqueptr in ImplSysReadConfig · c2ce6468

Noel Grandin Eki 29, 2018 yazdı

Change-Id: I59fc342e480b6ace1bbe366692d834f1076abac2
Reviewed-on: https://gerrit.libreoffice.org/62653
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

c2ce6468

loplugin:useuniqueptr in SfxItemPoolCache::ApplyTo · c969f04f

Noel Grandin Eki 29, 2018 yazdı

Change-Id: Ica6ffb5bbaad5c941c65cae02bba7ea2380646f3
Reviewed-on: https://gerrit.libreoffice.org/62652
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

c969f04f

loplugin:useuniqueptr in TypeWriter::createBlop · 167a2a0a

Noel Grandin Eki 29, 2018 yazdı

Change-Id: Iafc9fdcaeb83d1a383ed60b3b610043d0325cde2
Reviewed-on: https://gerrit.libreoffice.org/62650
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

167a2a0a

loplugin:useuniqueptr in l10ntools · cdeb83ed

Noel Grandin Eki 29, 2018 yazdı

Change-Id: Ib8dafdb2b3831cdd9481fd19b340ac377c8dc9db
Reviewed-on: https://gerrit.libreoffice.org/62649
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cdeb83ed