Change-Id: I1afc6278f6853d5e45a305b4f731cb6af0e00cc1
Reviewed-on: https://gerrit.libreoffice.org/72955
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Remove a chunk of O(n^2) work in XMLHints_Impl

Change-Id: I6b391af630d83ddd563b66bc1ad1640cd78debc7
Reviewed-on: https://gerrit.libreoffice.org/72948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

I have recently added shapes star24 and star32 to the unit test, but
forgotten to update the comment in the test accordingly.

Change-Id: I712c652100cadedc06a0b16c8dd27dc078cdbbeb
Reviewed-on: https://gerrit.libreoffice.org/72954
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I700e573b45510a1c81e8d5bc50a59f521b17b5c2
Reviewed-on: https://gerrit.libreoffice.org/72953
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: I917956cefc34ad87a0c601c280fe7d8febb6b5d4
Reviewed-on: https://gerrit.libreoffice.org/72945
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

This fixes tdf112618, which wasn't importing properly anymore
since recent commit cc899c69
for bug 101826.
I tried to setFly( XFillTransparencyItem(100) ), but then
it didn't round-trip. Fixing up the export sounds like a
suicide mission, so I just used the non-regressive path.

There is still a chance that unset transparency could cause problems
with other types like solid/gradient/bitmap.  However, I wasn't
able to design any example documents to prove that. One difference
is that the RES_BACKGROUND looks in the parents (bInP) for
attributes, while I only transfer directly set attributes(!bInP).

Change-Id: I5160562e222629510ede3b49ae85ec99f7b351c9
Reviewed-on: https://gerrit.libreoffice.org/71646
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ifa4f861f1005adf8192d5d1871ba8310965a7049
Reviewed-on: https://gerrit.libreoffice.org/72930Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie160b87a0334290ae80e4fedcda3c7b56745c70e
Reviewed-on: https://gerrit.libreoffice.org/72933
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie64aee5d16d8b8f39e1dba75628bb0b97b4dddd9
Reviewed-on: https://gerrit.libreoffice.org/72935
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia9523bdb340e6aae9d3243306add8f0871f3d5ee
Reviewed-on: https://gerrit.libreoffice.org/72941Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I09ea15a845bdae45453983862edbcbe9550cce86
Reviewed-on: https://gerrit.libreoffice.org/72942
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I0e671745c320283a1f62f49c336a1d68cfae4371
Reviewed-on: https://gerrit.libreoffice.org/72940
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I16e3d831aa8a393a4d740742710b9af3d6f9262f
Reviewed-on: https://gerrit.libreoffice.org/72937
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4c1b1328536300dd4f46b4c8db3cadf143e8612a
Reviewed-on: https://gerrit.libreoffice.org/72931
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4df91638680b18e4e93dcb7d742e91012b75c92e
Reviewed-on: https://gerrit.libreoffice.org/72934
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I113b437d21487bb65a4d88e8d1e8732762d3263f
Reviewed-on: https://gerrit.libreoffice.org/72936
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I91d07eb59329030a1c7503062816773ea5b09cbd
Reviewed-on: https://gerrit.libreoffice.org/72928
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I924e62ed2c65be8ac4b9664a17935fb0ada041a3
Reviewed-on: https://gerrit.libreoffice.org/72938
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic8643301cddebe6f62178e7611f2ebe22beddf0b
Reviewed-on: https://gerrit.libreoffice.org/72932
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9f986b89128c36e62cbfeedf500a116f40de74cc
Reviewed-on: https://gerrit.libreoffice.org/72939
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia9adea465427a492ed0062c28e3e6dc09cc77673
Reviewed-on: https://gerrit.libreoffice.org/72927
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ieff9c7c7904b19b4202415b860b7a372503f46b6
Reviewed-on: https://gerrit.libreoffice.org/72926
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I22ec1ef8914262d20824b0d6d41a694820bac1b7
Reviewed-on: https://gerrit.libreoffice.org/72925
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Revert LO 6.3 bugfix d9a6eab1
because LO has changed the behaviour of implicit sections
when Protect Forms is enabled.  Now they are editable,
making the Protect Form compatibility option nearly useless.
(tdf#122201 commit d9a6eab1
which was backported to LO 6.2). Since implicit sections are
now editable in LO, they should export as editable.
See tdf#124451 for a one-sided discussion about this.

Since many people may have used this switch as a simple way
to create a protected form in the past, document this change
and point to sections as the way to set protection natively.

Protect Form is now only good for protecting the form field
itself from being deleted while the user is filling out the form,
and that is true only for legacy sw::mark::IFieldmark form fields
which have no UI in LO for adding them (.doc compatibility forms).

Change-Id: I938f015fe63c22e831654e96de77b5809bb924ff
Reviewed-on: https://gerrit.libreoffice.org/71716
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Id54e7c4fb977a41e6a4a20d51543c45a9283480a
Reviewed-on: https://gerrit.libreoffice.org/72879
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3ff0c23b54ba4e7a534693ba25a3ffb27d1c18e1

+ some slight simplification

Change-Id: Ifa9d4d7d27e80217f778f3625ef4437828600dd3
Reviewed-on: https://gerrit.libreoffice.org/72922
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

This is useful for the Online, where we want to insert the text box
directly into the document so that it is visible right away.

Change-Id: I09ab2efba758aac077fa37ddfd20b1486b35b3ef
Reviewed-on: https://gerrit.libreoffice.org/72912
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

...from SvtValueItemAcc to unrelated ValueItemAcc in ~SvtValueSetItem.  The
Svt* classes had been copied from the non-Svt* ones in
4883fd31 "weld ScTabBgColorDlg", but this
static_cast had apparently been missed when copying ~SvtValueSetItem from
~ValueSetItem (and the originally copied SvtValueItemAcc::ParentDestroyed had
later been removed with d4d03761
"loplugin:unusedmethods").  But the static_cast in ~ValueSetItem would never
have been necessary in the first place (though that needs partial reversal of
508c95f1 "improve passstuffbyref return
analysis", which had unhelpfully changed ValueSetItem::GetAccessible to return a
reference).

Change-Id: If1c9bb617ac4ad3c24371729504f9082594c048f
Reviewed-on: https://gerrit.libreoffice.org/72914
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic35c9898624f0c13b6d64725808e765a64c17081
Reviewed-on: https://gerrit.libreoffice.org/71937
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I15bea9555422f96380d08e607b173b81d00b9ab1

...to svx::a11y::AccFrameSelector (which are unrelated final classes).  UBSan
Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and
clicking into the top-right corner of the widget caused

> svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector'
> 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild'
>  e1 03 80 0d  90 4f c2 88 ce 7f 00 00  02 00 00 00 be be be be  00 00 00 00 00 00 00 00  00 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'svx::a11y::AccFrameSelectorChild'
>  #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50
>  #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21
[...]

The code was like that ever since 60f11adb
"Integrate branch of IAccessible2", which had presumably confused
AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not
been a deeper need for the static_casts anyway).

Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e
Reviewed-on: https://gerrit.libreoffice.org/72910
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

in
	commit d6865e5c
	Date:   Fri May 24 11:52:30 2019 +0200
    use std::unordered_map in RTFTokenizer

Change-Id: I5197eae86c4611d1598dbb60bae4962ad0576ecd
Reviewed-on: https://gerrit.libreoffice.org/72906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

so pass in the shared_ptr we already have (and enforce that we pass in
the right one)

Change-Id: Ic481b5ec17c34ed9cba50586dedb6184505dee24
Reviewed-on: https://gerrit.libreoffice.org/72908
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id05f65543eeb06526535ce9eaee354b4789e2069
Reviewed-on: https://gerrit.libreoffice.org/72883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

it is just obfuscating the code

Change-Id: I72491d4861d06bd032bb014314c18605967aa3c9
Reviewed-on: https://gerrit.libreoffice.org/72824
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Hyperlink at numeric data lost after export.

tdf79972.xlsx: Test file from Excel 2016.

Change-Id: I6064724e6e38325386c4dfc8f1e9d93cce041975
Reviewed-on: https://gerrit.libreoffice.org/72894Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins

of a paragraph after a tracked deletion in Hide Changes
mode (including hiding the numbering completely).

We add the numbering of the paragraph to the first node
of the deletion, so Hide Changes mode will show the
actual text content correctly.

Note: file saving already makes the same changes in the
deletion without this workaround, too.

Change-Id: I09d3ad2c05bfd6c7f9f65cfe21a4bade2ac18a14
Reviewed-on: https://gerrit.libreoffice.org/72784
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Under ASan, clicking into the Calc "input line" control (in the toolbars) caused

> ==26138==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x616000107a4c at pc 0x7fc890d792cb bp 0x7fff4cab6d90 sp 0x7fff4cab6d88
> READ of size 1 at 0x616000107a4c thread T0
>  #0 in Edit::IsPassword() const at include/vcl/edit.hxx:285:38
>  #1 in vcl::Window::getDefaultAccessibleRole() const at vcl/source/window/accessibility.cxx:327:73
[...]
> 0x616000107a4c is located 116 bytes to the right of 600-byte region [0x616000107780,0x6160001079d8)
> allocated by thread T0 here:
>  #0 in operator new(unsigned long) at /data/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cc:105:3
>  #1 in VclPtr<ScInputBarGroup> VclPtr<ScInputBarGroup>::Create<vcl::Window*&, ScTabViewShell*&>(vcl::Window*&, ScTabViewShell*&) at include/vcl/vclptr.hxx:129:42
>  #2 in lcl_chooseRuntimeImpl(vcl::Window*, SfxBindings const*) at sc/source/ui/app/inputwin.cxx:157:12

This looks like it got broken with cca4d9ab
"convert WB_PASSWORD to a bool field on Edit" assuming that a Window of type
CALCINPUTLINE derives from Edit, even though ScInputBarGroup does not.

Change-Id: I1457c6cd07477ee0fa868c3949105aa96116a366
Reviewed-on: https://gerrit.libreoffice.org/72893
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The problem was that in case the shape text has an explicit language
set, then the shape language will have no effect on shape text language;
need to clear those attributes explicitly.

The const_cast<> for the EditTextObject should be OK, since we change
the shape's item set anyway, so we don't omit any needed notifications.

Change-Id: I721e3f0aefa103a6bfa320a671da2ee1e039fa38
Reviewed-on: https://gerrit.libreoffice.org/72904Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ie4f1362510636006cae8a680b3ad2bbfa93e854b
Reviewed-on: https://gerrit.libreoffice.org/70449
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>