V547 Expression 'mpTargetSlideSorter != nullptr' is always false.

The code wasn't used since commit 4b83a7fe
(initially, mpTargetSlideSorter pointer was compared to a pSlideSorter
parameter, which was always nullptr since commit above; then commit
f946e905 removed the const parameter).

Change-Id: I70047ae3e7ef39419be0012e375856d8a50d5793
Reviewed-on: https://gerrit.libreoffice.org/63229
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'pUnits' is always true.

Change-Id: I2bd31fcc31c36b43d14ff2a10a7143b9fbe86b3d
Reviewed-on: https://gerrit.libreoffice.org/63228
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

A legacy callout from toolbar 'Text', not a custom shape, is a
rectangle with an additional tail. Currently only the end of
the tail is dragable. The error was, that all points of the tail
had got markers and that the markers had got a wrong point reference.

Change-Id: I900b1294aaeefc0f46547c6db009a3c750955460
Reviewed-on: https://gerrit.libreoffice.org/63120
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Full circle and ellipse have eight handles, all other legacy circle
kinds have two additional handles for to modify start and end angle.
The error was, that the loop was not adapted at its start, but at its
end, and the values 8 and 10 were interchanged.

Change-Id: I13204382a21f1b7900f0eafa18960e401e5a0c9d
Reviewed-on: https://gerrit.libreoffice.org/63103
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Text box and rectangle have the same kind and number of handles in
'Edit Point' mode. Only that a text box has an additional handle for
its blinking frame. The error was, that this special one was not
skipped for a rectangle.

Change-Id: Iae7af3eb196e61e32ecd5a39ba0ec553bbdaaa48
Reviewed-on: https://gerrit.libreoffice.org/63070
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

A polygon consists of line segments without controls and curve
segments with two controls. Where two segments meet, can only be
'line to line', 'line to curve' or 'curve to curve'. So for a
handle which marks a meeting point of two segments, there are 0
or 1 control before and 0 or 1 control after. Thus a loop is not
needed and makes the code harder to read. Therefore I have
removed the loop.

Change-Id: I48bcdbdf028542e08b3f5ed3f66907f2993e26bd
Reviewed-on: https://gerrit.libreoffice.org/63036
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643
Reviewed-on: https://gerrit.libreoffice.org/63235
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V555 The expression '(curpos - bufpos) > 0' will work as 'curpos != bufpos'.

Change-Id: I432c10c9c5ecc99293ec3f03f6e1a660e1c47e28
Reviewed-on: https://gerrit.libreoffice.org/63236
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'Oep <= Osp' is always false.

Some of the conditions in the type detection code weren't reachable.
Also moved the code from class member to static function.

Change-Id: Iaf9dbe8ab15a1970b5cd580cf5d868715a234d02
Reviewed-on: https://gerrit.libreoffice.org/63230
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'pFormat' is always true.

Change-Id: I11a32f903a08296fb9e6732032b7c7f00cb8aced
Reviewed-on: https://gerrit.libreoffice.org/63233
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression '!pGroupInfo->m_pModule' is always false

The chunk of code updating module pointers was always doing nothing
since the beginning (commit 997cf427
from 2004), because the line to load the module was commented out.
So just remove it now.

Change-Id: I8db38e795662bba6b3b4693e7ba8a869a97acdd2
Reviewed-on: https://gerrit.libreoffice.org/63232
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... which is apparently not needed anymore for #i41635. The revert allows
to properly skip "deselect" accessible event when there's no selection
previously.

Also removed the other identical correction, which was added in commit
4883fd31.

Change-Id: I87c629d679b5c253a3864061074bfde77507fb12
Reviewed-on: https://gerrit.libreoffice.org/63231
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I637ba12d0c1b7baa8f7f4be456e6101594eb934a
Reviewed-on: https://gerrit.libreoffice.org/63227
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I38d02cb771363f5012a18f41c5bf5c6fe728bd49
Reviewed-on: https://gerrit.libreoffice.org/62261
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7340a561e0df0c781fd834388deb4b9f83800f9b
Reviewed-on: https://gerrit.libreoffice.org/63221
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I1d13f22325679f17ddef231991ecb0e199f00c50
Reviewed-on: https://gerrit.libreoffice.org/63223
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I94fe979fde236111b72b0b445ee2566177a3f0e3
Reviewed-on: https://gerrit.libreoffice.org/63226
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: I89f596c5d4ee95cc48ee52507bbce9ed4eb0085a
    Reviewed-on: https://gerrit.libreoffice.org/63225
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: Id538fc081ea563f2c257c061812263ae33c7af52
Reviewed-on: https://gerrit.libreoffice.org/62971
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

The _XNamed tests are already written in C++ since commit
bbfddc1b for ScNamedRangeObj.

Change-Id: Ief17cea92c8b2ee42ef44da35f7a02ca07b099b6
Reviewed-on: https://gerrit.libreoffice.org/63224
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

An iOS app might itself, for testing and debugging purposes, look for
LANG in the environment (potentially passed to it by Xcode; the OS
does not set such an environment variable). It is confusing if that
then gets set during the execution of core code back to a device's
default.

Change-Id: I9dcf44090aed84b55fd4240bda2562026cd8dacb

Change-Id: If3efa54c5d0ce7ffee3bf3f4ecb1de5ff7e4267d

Just ifdef out the call of it for now. This is a temporary solution,
we presumably do want dialogs to be "themed" appropriately for the iOS
app.

Change-Id: I0b14bd59ecc13037c9ff2a286405a5020081f1d5
Reviewed-on: https://gerrit.libreoffice.org/63112Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 237042b8)

Change-Id: I7c1500f8e5e1a1f25cbb9cd41d897a37c1402f5b

Change-Id: I59e4803a5d9b01062eb0eaca0bf65d28298bd3e4
Reviewed-on: https://gerrit.libreoffice.org/63121
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

* Update helpcontent2 from branch 'master'
  - tdf#119269 Font Features Help page
    
    Change-Id: I72f23c891dda9dda8f7d42b72aa370285abd7a41
    Reviewed-on: https://gerrit.libreoffice.org/63205
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#119415 change from fuse.js to fuzzysort.js
    
    Tied the index listing to the current module.
    Fuzzysort.js is MIT licensed.
    
    Change-Id: I5d95cc1870a1856089217846ed0af572abc882d7
    Reviewed-on: https://gerrit.libreoffice.org/63203
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Regressions from commit 45519023 ("Resolves: tdf#119997
toolbar layout unlock doesn't refresh ui"), commit c5977a89
("Resolves: tdf#96451 do magic to enable embedded chart sidebar
only for chart") and commit faed29ca ("for now show chart
sidebar").

It also adds an assert for the underflow, as nobody cared for
the underflow warnings since some years.

Change-Id: I86bb093987f084c85a7b640a846dfe0aefea9e48
Reviewed-on: https://gerrit.libreoffice.org/63204
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I9f8f25ee72e93fdf575312b6b0c5d32be9ea45cc

Too many side conditions are possible with implicit array of
references in array mode. Propagate new ReferenceOrRefArray
parameter class to indicate the preferred return type for
arguments to functions whose parameters explicitly handle array of
references.

Change-Id: I1f01266495c2ef1941ffe0cb7c2e0a5ae0bb7e69
Reviewed-on: https://gerrit.libreoffice.org/63201Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I5d657fa4d6f63b93ad3775a5641d08c6e0f3a615

Also remove macroni.

Change-Id: I0b2914e9f0e2aba9d8ca10338b515b598126e315

Change-Id: I89dcf5a102be19fd1bc314a89538a121522f4a43

Change-Id: Ib1afbb0b5647048f24d4ea6f9859b76328568dac

Change-Id: Iff50f7aeb471870230e9e822657deed6aefad268

Change-Id: I7cae61e1fa9cf74b98627d557890fd41047421df

Change-Id: Ibc425d8e630460547d66723ccabeaf4ac29d2719

Change-Id: Ic189aecf092b9cffd800e410d2d6e88016c43052

Change-Id: I1962a4a1397363b1c15e49d57b0bbcc9c232ce30

Use ColorData for custom widget themes to
make it more readable and consistent.

Renamed and split out colors to be more accurately
named and representative of how they are used.

Fixed a number of inconsistencies in how colors
were used across widgets.

Change-Id: I1cbb5f19223bd55107379b049beccaf1de4e26b2