Change-Id: I9df9dd3f2bfaedccb4a02681964544daf39f261e
Reviewed-on: https://gerrit.libreoffice.org/60580
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iac11d3ea29cc9529a786db3b91b79a9e7bcbd2cf
Reviewed-on: https://gerrit.libreoffice.org/60581
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie0fe76ef5c5c706007c2285b3a309d92ff4bc2b0
Reviewed-on: https://gerrit.libreoffice.org/60528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I08f177d74aff278c62f76e32a1401ff24f249c57
Reviewed-on: https://gerrit.libreoffice.org/60589Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia57fc61147179a92569918417692e44e11ad6061
Reviewed-on: https://gerrit.libreoffice.org/60646
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

http://crashreport.libreoffice.org/stats/crash_details/61ba172a-ce27-46d7-8493-dc7cb688b10a

presumably since...

commit 767188fd
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu May 17 16:21:02 2018 +0100

    make PlaceEditDialog a bit more ordinary

which missed the other ctor

Change-Id: Iece359b94afdd0d2c48afe7f301e7178180f1dc5
Reviewed-on: https://gerrit.libreoffice.org/60586
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1485/>

Change-Id: Id58b86b561ebe10e23c14130bd5f3efe10f95be5
Reviewed-on: https://gerrit.libreoffice.org/60656
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This was a problem since commit 29d4ecf3
(tdf#115574 sot: fix Excel -> Writer paste, 2018-03-29), the root cause
seems to be that (older?) Safari provides RTF clipboard content which
simply doesn't contain the images.

Just to back to the old behavior on macOS for now, hopefully the
problematic RTF producer will go away in the long run.

Change-Id: I5c40b28671978cfbf8593f1cc9775985dffc5030
Reviewed-on: https://gerrit.libreoffice.org/60641Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Icb13a87a8a55c89d4852a31c7708eb3596d9f689
Reviewed-on: https://gerrit.libreoffice.org/60630
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I67c2283974eb71978beaf265f821fd2c5c5ae55c
Reviewed-on: https://gerrit.libreoffice.org/60626
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1d4379350793c3c245952793af5defeea84075b3
Reviewed-on: https://gerrit.libreoffice.org/60624
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

no need to store ref-counted object like OString on the heap

Change-Id: Ifd031ae68dfd615e99f54414cb2dc32aac60daa8
Reviewed-on: https://gerrit.libreoffice.org/60623
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8387731747ee6eb7d74037c0eff7fc9ac0b884c8
Reviewed-on: https://gerrit.libreoffice.org/60619
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I095e0b35d62fa0c82e7e171b2923431e06175558
Reviewed-on: https://gerrit.libreoffice.org/60614
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibf84535dd24292e7c6f67b813224bfd4e02945cd
Reviewed-on: https://gerrit.libreoffice.org/60612
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I677d9b229d1c9f69d74b4fbde9b81124bd1ddd12
Reviewed-on: https://gerrit.libreoffice.org/60611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I998676bb563307d31df7d787b741519263c7308a
Reviewed-on: https://gerrit.libreoffice.org/60609
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I19f4762b17fcd6841b7c6520770400297f59dd03
Reviewed-on: https://gerrit.libreoffice.org/60608
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifce0dc836ea8500105ebcf3302f37ad6968929ec
Reviewed-on: https://gerrit.libreoffice.org/60607
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fixing a leak in SwView::InsertMedium

Change-Id: I9abd97151b0fd7b3f6c286926e1a317ea47dc232
Reviewed-on: https://gerrit.libreoffice.org/60606
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8acc0df204417846d275dbba290177d0f166f3d9
Reviewed-on: https://gerrit.libreoffice.org/60605
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id8701c91d272850368db80b1ebabf11ea2a028f5
Reviewed-on: https://gerrit.libreoffice.org/60604
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id32017ea2d3214e2bb568501ec633f182c5766de
Reviewed-on: https://gerrit.libreoffice.org/60603
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I731a57bff9f74811b240b6eaabbafed833b2fbd3
Reviewed-on: https://gerrit.libreoffice.org/60602
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6121e2b41a5e6116be8027fe5197ce53d8f6797f
Reviewed-on: https://gerrit.libreoffice.org/60562
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Several drawing styles added

Change-Id: I3c0efcdc5c0462844f84f5dbb355cfa800a70898
Reviewed-on: https://gerrit.libreoffice.org/60444
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

...e.g. during UITest_conditional_format
(https://ci.libreoffice.org//job/lo_ubsan/1039/):

> /sc/source/core/data/colorscale.cxx:524:48: runtime error: value -33.2609 is outside the range of representable values of type 'unsigned char'
>     #0 0x2b778b7d666d in (anonymous namespace)::GetColorValue(double, double, unsigned char, double, unsigned char) /sc/source/core/data/colorscale.cxx:524:48
>     #1 0x2b778b7bd096 in (anonymous namespace)::CalcColor(double, double, Color const&, double, Color const&) /sc/source/core/data/colorscale.cxx:530:25
>     #2 0x2b778b7bcb94 in ScColorScaleFormat::GetColor(ScAddress const&) const /sc/source/core/data/colorscale.cxx:625:20
>     #3 0x2b778b8906a4 in ScConditionalFormat::GetData(ScRefCellValue&, ScAddress const&) const /sc/source/core/data/conditio.cxx:1830:33
>     #4 0x2b778cb8968a in (anonymous namespace)::handleConditionalFormat(ScConditionalFormatList&, std::__debug::vector<unsigned int, std::allocator<unsigned int> > const&, CellInfo*, ScStyleSheetPool*, ScAddress const&, bool&, bool&, bool) /sc/source/core/data/fillinfo.cxx:301:34
>     #5 0x2b778cb74e49 in ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) /sc/source/core/data/fillinfo.cxx:581:54
>     #6 0x2b77941656c0 in ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) /sc/source/ui/view/printfun.cxx:539:5
>     #7 0x2b77914e965b in ScDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short) /sc/source/ui/docshell/docsh4.cxx:2032:9
>     #8 0x2b76f7004296 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short) /sfx2/source/doc/objembed.cxx:229:5
>     #9 0x2b76f7001b81 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short) /sfx2/source/doc/objembed.cxx:176:9
>     #10 0x2b76f6fd8fe3 in SfxObjectShell::CreatePreviewMetaFile_Impl(bool) const /sfx2/source/doc/objcont.cxx:168:5
>     #11 0x2b76f6fd618b in SfxObjectShell::GetPreviewMetaFile(bool) const /sfx2/source/doc/objcont.cxx:115:12
>     #12 0x2b76f55728ab in SfxPickListImpl::AddDocumentToPickList(SfxObjectShell*) /sfx2/source/appl/sfxpicklist.cxx:134:54
>     #13 0x2b76f5576d93 in SfxPickListImpl::Notify(SfxBroadcaster&, SfxHint const&) /sfx2/source/appl/sfxpicklist.cxx:222:17
>     #14 0x2b76fc444921 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:49:13
>     #15 0x2b76f4eb062c in SfxEventAsyncer_Impl::IdleHdl(Timer*) /sfx2/source/appl/appcfg.cxx:119:5
>     #16 0x2b76f4eaf705 in SfxEventAsyncer_Impl::LinkStubIdleHdl(void*, Timer*) /sfx2/source/appl/appcfg.cxx:114:1
>     #17 0x2b7724e683b7 in Link<Timer*, void>::Call(Timer*) const /include/tools/link.hxx:84:45
>     #18 0x2b7724e67599 in Timer::Invoke() /vcl/source/app/timer.cxx:77:5
>     #19 0x2b7724c40779 in Scheduler::ProcessTaskScheduling() /vcl/source/app/scheduler.cxx:451:13
>     #20 0x2b7724c3b168 in Scheduler::CallbackTaskScheduling() /vcl/source/app/scheduler.cxx:270:5
>     #21 0x2b7725b02fac in SalTimer::CallCallback() /vcl/inc/saltimer.hxx:55:13
>     #22 0x2b7725af43a5 in SvpSalInstance::CheckTimeout(bool) /vcl/headless/svpinst.cxx:206:21
>     #23 0x2b7725afbc52 in SvpSalInstance::DoYield(bool, bool) /vcl/headless/svpinst.cxx:418:14
>     #24 0x2b7724dafc3b in ImplYield(bool, bool) /vcl/source/app/svapp.cxx:471:28
>     #25 0x2b7724d8a3ff in Application::Yield() /vcl/source/app/svapp.cxx:536:5
[...]

Change-Id: I1650c2236a183c7b6349be6cb444d350e85ea8b6
Reviewed-on: https://gerrit.libreoffice.org/60654
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

30530afa follow-up

Change-Id: I74082858c938087c5698ef0948a72b9a61b9127c
Reviewed-on: https://gerrit.libreoffice.org/60593Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

According to the OOXML standard, <w:cr> (carriage return –
Unicode character 000D) is equivalent to a break
with null type and clear attributes, so we handle it as
a <w:br/>, instead of endOfParagraph, fixing
losing table paragraphs and tables containing <w:cr/>.

Note: It seems, MSO cannot handle carriage return characters
in table cells correctly. It shows squares (unknown
characters) without line break there. Copying this text to
a non-table paragraph in MSO, we get the correct layout with
line breaks. Copying this text with carriage return characters
back to a table cell, we get squares again. With this LO fix,
it will be possible to fix the bad tables edited by MS Word
by using LO, because LibreOffice import/export converts all
<w:cr>s to <w:br>s (as before, but now without destroying
the structure of the tables).

Change-Id: Iee42f71e9a00531353582e7127c2c212ea0890d0
Reviewed-on: https://gerrit.libreoffice.org/60585
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

...since 88582ebe "weld SdCharDlg"

Change-Id: Id6069271806e1a19688debf045169890e557cc66
Reviewed-on: https://gerrit.libreoffice.org/60645
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...after 27463197 "clang-tidy bugprone-copy-
constructor-init" made e.g. the SfxStyleSheetBase copy ctor (in
svl/source/items/style.cxx) use the copy instead of the default ctor for its
OWeakTypeObject sub-object

Change-Id: I7deec4ea2f968587ba1dc03e33206cecfa3f8df5
Reviewed-on: https://gerrit.libreoffice.org/60644
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...because loplugin:constfields is wrapped in

  #if !defined _WIN32 //TODO, #include <sys/file.h>

Change-Id: I9b2a72ecd31f561c71be5a74a752344c24d40f26
Reviewed-on: https://gerrit.libreoffice.org/60598
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are'nt working 31
    
    Module cui
    
    Change-Id: I3f9dc6e469b04f0e86c426c907a8213fe351b8c4
    Reviewed-on: https://gerrit.libreoffice.org/60636
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Import time before:

12.192 seconds

After:

5.836 seconds (47.87% of baseline) for me.

Change-Id: Ifd650addaae3fe25b45cf0fd452f78372e60c467
Reviewed-on: https://gerrit.libreoffice.org/60591Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: I2219e81ed03a92ea5ff4cff3e494a7c483d16cec
    Reviewed-on: https://gerrit.libreoffice.org/60634
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I7cae6b3f31b10efc72884bce4bda7bf6b380cbc2
Reviewed-on: https://gerrit.libreoffice.org/60597
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I825230daf223ff94ab1dbc19d81d478fbf464f56
Reviewed-on: https://gerrit.libreoffice.org/60596
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I14040fd236d399bfce6c4e6e6927a00aabe5b2c5
Reviewed-on: https://gerrit.libreoffice.org/60595
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This will guarantee SfxItemSet existence

Change-Id: Ia969b5391c7b20d3a2bbba4376a16fcaadccb9d4
Reviewed-on: https://gerrit.libreoffice.org/60563
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: Ibb1e11eb438607d26ebd06e7fb160cf850915d5b
Reviewed-on: https://gerrit.libreoffice.org/60555
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>