Change-Id: I48e0d84ec0307f9895b5148f9522df8f0c02ac6c
Reviewed-on: https://gerrit.libreoffice.org/55758Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Move remaining _XCellRangeReferrer tests to C++ and partly fix #i84656.

Change-Id: I77cc8550888f460a6ae265816907a19a81cbe871
Reviewed-on: https://gerrit.libreoffice.org/55732Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
A bit of fallout management as well.

Change-Id: Ie058eac6608d7c6dc2cfb29f1081b6684a4412ac
Reviewed-on: https://gerrit.libreoffice.org/55541Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I76685155ca0d9f19a787c8cda13c1fa5afde8250
Reviewed-on: https://gerrit.libreoffice.org/50304Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I0e442ca3787c1b71c919dbf2d4da75eabfaca47f
Reviewed-on: https://gerrit.libreoffice.org/55747Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

...which violates the ctor's preconditions, so is UB.  Also, the "XML Help
Document Type Definition" appendix of
<http://documentation.openoffice.org/online_help/OOo2HelpAuthoring.pdf> states
that "branch" and "id" attributes are #REQUIRED for the "bookmark" element.

(There's probably further cases in the surrounding code where a std::string is
created from a potentially null argument, which would benefit from similar
fixes.)

Change-Id: I414576d13de784de1290951bcdd5e3ecb51f9cb8
Reviewed-on: https://gerrit.libreoffice.org/55735Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

address some out of bounds oddness seen with
rtl_ustr_getlength_heap_buffer_overflow.sample

Change-Id: I5a9772de9607644f43e74174f73053d292ca7cc0
Reviewed-on: https://gerrit.libreoffice.org/55722Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  279e341d56686a5e381fbc53faec3395e4cd451a

Helponline: Allow for system typeface to be used

Change-Id: Ic3868b0bcdbb978f450666b4f98e53587b5e7f85
Reviewed-on: https://gerrit.libreoffice.org/55728Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

/sw/source/core/text/txtfrm.cxx:987:16: runtime error: downcast of address 0x2b53270e5890 which does not point to an object of type 'const SwTextNode'
0x2b53270e5890: note: object is of type 'SwContentNode'
 00 00 00 00  70 f9 c7 cb 52 2b 00 00  60 5c 7a 00 e0 60 00 00  f0 5b 0e 27 53 2b 00 00  40 15 18 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'SwContentNode'
0 in SwTextFrame::GetTextNodeFirst() const /sw/source/core/text/txtfrm.cxx:987:16
1 in SwFrame::InvalidatePage(SwPageFrame const*) const /sw/source/core/layout/wsfrm.cxx:702:21
2 in SwContentFrame::Cut() /sw/source/core/layout/wsfrm.cxx:1111:5
3 in SwContentNode::DelFrames(bool) /sw/source/core/docnode/node.cxx:1361:9
4 in SwContentNode::~SwContentNode() /sw/source/core/docnode/node.cxx:1017:5
5 in SwTextNode::~SwTextNode() /sw/source/core/txtnode/ndtxt.cxx:270:1

So call this from the ~SwTextNode instead, while it's still a
SwTextNode.

Also revert the order of resetting the wrong-flags
to what it was before b75e052d,
as DelFrames_TextNodePart() before DelFrames() will cause the
root's SetNeedGrammarCheck to be called, which nobody will notice in
practice, but...

Change-Id: I0f4f38a484a28dd13a0696bb083300f9ec1e0836
Reviewed-on: https://gerrit.libreoffice.org/55739Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Next step is to put more logic into the decision
if Draw or Impress should be loaded - if we have a
self-exported Impress, import as Impress, else
(including all not-self-created SVG Graphics) import
to Draw.
To do this it is necessary to be able to import to
different document formats at all. To do this, add
an internal filter type to the filter mechanism
(types/registration/...) and decide in the SVG
XExtendedFilterDetection::detect from SVGFilter
which one to use.
Added tooling for SVG detection and more, see
SVGFileInfo. This allows to detect for SVG, but
also if the creator was LO and if it was Draw or
Impress. The document format/filter is choosen
accordingly.
Corrected the error with <g visibility="hidden">
Slides inisde <g class="SlideGroup"> for import
of self-exported Impress documents. No idea why
this was written that way, but needs to be fixed
to get a visible content at all.
Also adapted the final mapping from pt to 100thmm
in SvgSvgNode::decomposeSvgNode. Unfortunately
(and also for unknown reasons) the self-exported
Impress does not write svg:width/height values,
thus the adaption from assumed svg-units (px) to
100thmm has to be skipped.
Have identified the place in svgio where I can
embed Pages/Slides to a helper-Primitive to later
be able to 'break' such GraphicObjects to multiple
Pages/Slides. I have added a Primitive called
PageHierarchyPrimitive2D for this purpose.

Change-Id: I38bfef6e7b16479a025fc754e38b4e21a006ad38
Reviewed-on: https://gerrit.libreoffice.org/55434Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

...mainly to test how well/poorly extension help is supported by
--with-help=html, but also as a kind of reference implementation.  (There are
also extensions in odk/examples/ that contain help content, namely
odk/examples/DevelopersGuide/Extensions/DialogWithHelp/ containing context-
sensitive help for a dialog, a topic that is not covered here.)

See <https://wiki.openoffice.org/wiki/Documentation/DevGuide/Extensions/
Help_Content#Integration_into_the_OpenOffice.org_help_system> for the ways an
extension's help content can be integrated into the "classic" (plain
--with-help) help system (citing sub-section headings used in that document):

* Help Viewer Contents page:

  The contained help.tree provides a "The test-passive Extension" section with
  a "The test-passive Extension" page (main.xhp).

* Help Viewer Index page:

  The contained main.xhp provides index entries for "test-passive extension" and
  "extensions"-"test-passive", and---only on the index pages of Calc and Writer
  ---for "test-passive extension in Calc and Writer".

* Help Viewer Find page:

  The contained main.xhp is indexer="include", so it should be found by e.g.
  searching for "bla bla".

* Context sensitive help and extended tool tips:

  The contained Addons.xcu has been extended with a small (floating by default)
  toolbar containing a "native" button (doing the same as the "passive - native"
  menu entry), and the contained main.xhp provides an extended tooltip of "Show
  the test-passive extension's native dialog" for that toolbar button (displayed
  when using "Help - What's This?" and hovering over the button).

  For context-sensitive help for dialogs, see the mention of
  odk/examples/DevelopersGuide/Extensions/DialogWithHelp/ above.

The contained help is only provided in "en" localization, which should thus be
used as fallback regardless for which locale LO is run.

The help-related XML files need to provide identifiers in lots of places, many
of which appear to be unused for the given example uses.  I specified those as
empty strings.

The workdir/Extension/test-passive.oxt extension can be built with `make
Extension_test-passive`.

Change-Id: I0e75f35df85683c9fae1d1384fa6afeaeb8a687d
Reviewed-on: https://gerrit.libreoffice.org/55736Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I5cef91c2cdb13e33ad19597cd722e77e7c7796c9
Reviewed-on: https://gerrit.libreoffice.org/55745Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic33454aa64116e1258362df1bd0ff3ddb05745af
Reviewed-on: https://gerrit.libreoffice.org/55734Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I28ec2bd374d98ea1094649ac30ff7dd4c62370ae
Reviewed-on: https://gerrit.libreoffice.org/53726Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

just allocate these object inside the vector, we allocate in them in one
big block anyhow, not one at a time

Change-Id: I8df17ce180264efb5f51af2da91918889db4e68b
Reviewed-on: https://gerrit.libreoffice.org/55697Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The relevant files ('libvclplug_gtk3_kde5lo.so',
'lo_kde5filepicker') resulting from the '--enable-gtk3-kde5'
build option are put into the kde-integration package
(e.g. a Debian package when the '--with-package-format=deb'
option is given).

However, so far that package was only created at all when
one of the options '--enable-kde4', '--enable-qt5' or
'--enable-kde5' was given in addition.

Since those are not needed for the gtk3_kde5 vclplug, also
build the kde-integration when none of the others is
built in addition.

Change-Id: I86eb71ac7879c7226c9eaa89774b68125212a75c
Reviewed-on: https://gerrit.libreoffice.org/55310Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Change-Id: I92dff76a313fb5ab8f4ffc637fc45b57e6e31554
Reviewed-on: https://gerrit.libreoffice.org/55721Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...and make Table formula navigation wrap

This patch is for both Table formula and Wrong table formula navigation.

Change-Id: I79938ef876040ac15eb3e56c7d262f69431629a6
Reviewed-on: https://gerrit.libreoffice.org/55358Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Namely
GtkComboBox
GtkComboBoxText
GtkMenuItem

Change-Id: I85a971ca9cee5f17649b93d13d6b2aeb5440f830
Reviewed-on: https://gerrit.libreoffice.org/55414Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

...and make Comment navigation wrap

Change-Id: I2d56d1d1fdcef45f5dee10c5fa8fbfff49c3d3e4
Reviewed-on: https://gerrit.libreoffice.org/55304Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I045b6815a36837aa03293b98f53534c13960875b
Reviewed-on: https://gerrit.libreoffice.org/53963Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I9b6db677d43ec33b9f3f5c1e06b1725dec96cc6f
Reviewed-on: https://gerrit.libreoffice.org/54790Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I2ed73a296b813de722156c69ac64cf9d6cff199d
Reviewed-on: https://gerrit.libreoffice.org/55197Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>

This is because text in box is same colour as the background.
This is only an issue for Linux/KDE.
This change fixes this issue.

Change-Id: Icb908ace25c69fd2fb51f8f44082ca6b00f55c43
Reviewed-on: https://gerrit.libreoffice.org/55660Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This patch changes navigate behavior to move to prev/next footnote text
when in footnote frame.

Change-Id: If206098d8817b74ab484a1039371c058d321fda2
Reviewed-on: https://gerrit.libreoffice.org/54195Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I942279bdf2774d6c30deae2b2f35cd9edca07efd
Reviewed-on: https://gerrit.libreoffice.org/55614Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9ae4a9d821946591060ceadb45af05c27560668b
Reviewed-on: https://gerrit.libreoffice.org/55410Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I8990b18dd5a66eba98acc1fb3899e1d397ceff4c
Reviewed-on: https://gerrit.libreoffice.org/55730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Just a dummy implementation so far. Needed because customer Automation
client software seems to access it (through the very obsolete
WordBasic API, even). It remains to be seen whether any actual mail
merge functionality is needed.

Change-Id: I40419da544f61173e4bcf759b887997c7f233b02
Reviewed-on: https://gerrit.libreoffice.org/55727Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ia6d711faaad8c7e1af16b5f72ab5f2b417172e36
Reviewed-on: https://gerrit.libreoffice.org/55700Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I07307f2c572cd490fb7a52429824a76e0a637fe5
Reviewed-on: https://gerrit.libreoffice.org/55724Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

The state of the attributes for spacing are now read and set
correctly.

Change-Id: I661c00e247b55c64ea39c03db77dab9fa0775852
Reviewed-on: https://gerrit.libreoffice.org/55455Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I421a9e04464f8b722d100982d359b0b8c4a33585
Reviewed-on: https://gerrit.libreoffice.org/55702Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I3ba1b0d1b5412c30e540cf45fe21ef946839afed
Reviewed-on: https://gerrit.libreoffice.org/55372Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

since...

commit d46c3214
Date:   Thu Jun 7 12:37:33 2018 +0200

    assert in BitmapInfoAccess if bitmap is empty or we can't read from it

Change-Id: I138a53e9ce0763d4e62cfbba594abb323e807378
Reviewed-on: https://gerrit.libreoffice.org/55704Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  e530fd67898e3cfe403301627f29ea85aed66f0b

Add qtz media files

Change-Id: Ia0bbd2ebc13bc0fb271d6cc322ead05e42230aa1
Reviewed-on: https://gerrit.libreoffice.org/55717Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I83da56774b37b1c9c6abc4d6b1e7624db3f66de4
Reviewed-on: https://gerrit.libreoffice.org/55696Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

just because use_count is > 2, doesn't mean we have two simultaneous
writes, could be 2 readers and a writer

Change-Id: Ife7fc91ff2e597e6bb847460f46bdde954e63e4f
Reviewed-on: https://gerrit.libreoffice.org/55695Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

If sc/qa/unit/data/ods/functions.ods is run with OpenCL disabled
(and the mnOpenCLMinimumFormulaGroupSize check disabled too), then
ScTokenArray::CheckToken() considers the token for OpenCL, and if
the token is ocExternal, it passes all the related OpenCL checks,
and thus ScTokenArray::CheckForThreading() is never called.
However, since OpenCL is disabled, then actually the threaded code
will be executed, since the blacklisting for ocExternal has not been
done.

Change-Id: Ib4d4d63d3925746f6e13da0611ac869e9a094b5b
Reviewed-on: https://gerrit.libreoffice.org/55676Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I8f433b1ae5cc23aaa08935e87fca7674064ce881
Reviewed-on: https://gerrit.libreoffice.org/55706Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>