Change-Id: Ie68bf48b44ab583f0ea8a4a02d330ce95d739c00
Reviewed-on: https://gerrit.libreoffice.org/57213
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

commit 0307a627 fixed the
top margin import of the paragraphs of document sections, and
import of first paragraph of the text frames with beforeAutospacing,
but nullified all other paragraph top margins in frames.

Note: there is no visible margin difference in the unit test (extended
by this commit) before and after the fix, because the first paragraph
uses also afterAutospacing, resulting still 14pt paragraph space.
But the tested beforeAutospacing value of the next paragraph checks
the fix correctly.

Change-Id: I0ab3b8bbff33c5488f4b4af1ea4dabf7105103f2
Reviewed-on: https://gerrit.libreoffice.org/57231Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Additionally adapted EscherPropertyContainer's AddOpt
methods to be more safe and flexible. Added support for
SvMemoryStream. Changed Data handling in EscherPropSortStruct
to use std::vector<sal_uInt8>, adapted all usages and
converions throgh all modules. This makes memorty handling
for these parts much safer (no more local new-ops, no
longer delete[] there).
Currently there are quite some usages of nProp.size() and
&nProp[0] to access the data. but the base for further
changes to work more on std::vector is done.

Change-Id: I982225c5bfc06fdd9e195d18cd3c550d15f1d48d
Reviewed-on: https://gerrit.libreoffice.org/57061
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

When embedding, the fonts are gathered and added to the ODF
document. This change in addition adds the functionallity to
embed used fonts only and filtering out of font scripts. When
embedding used fonts only, they are filtered depending on if
the style (referencing the font) is in use and in addition if
the font is used in direct formatting.

Change-Id: I1ba0066b1eb34bdde7247eeb63c1be5a91db984d
Reviewed-on: https://gerrit.libreoffice.org/57168
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

- Add setting to embed used fonts only
- Add setting for filtering of Latin, Asian, Complex script fonts

Change-Id: I8d093ed05fdcef3715616c008f6eeaa8cfbcc850
Reviewed-on: https://gerrit.libreoffice.org/57167
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Including correction of earlier translations in case of and around "packen"

Change-Id: Icaeaebb46a15edcc4abdcfee55d07b43e1767e06
Reviewed-on: https://gerrit.libreoffice.org/57156Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Following resolution of tdf#117575, this commit add
disambiguation between '0' and '?' in integer part
XML_MAX_BLANK_INTEGER_DIGITS is added for the number of '?'
XML_MIN_INTEGER_DIGITS is the number of '?' and '0'
This preserve compatibility with previous versions:
in previous versions '?' will be transformed in '0'
It also applies to scientific and fraction numbers.

Change-Id: I6e1185bbece9c615240425cc973d59052b22aa34
Reviewed-on: https://gerrit.libreoffice.org/56352
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Specifies the y-axis anchoring of the text area in a shape according to:
t(top), mid(middle, default), b(bottom).

Change-Id: I98927f687334fd989ae43385de7dd91f8e2929b1
Reviewed-on: https://gerrit.libreoffice.org/56939Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

regression from
    commit d0f44d8b
    tdf#84323 - sal - add sane sleep interface: cleanup osl_waitThread

Change-Id: I55c2fa6c8993cc6268b1c5d9331c665c401e8efe
Reviewed-on: https://gerrit.libreoffice.org/57228
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This actually breaks the OpenGL glyph cache, which forced a full
redraw all the time working around the original problem, which
is now fixed with commit fad862e2.

This reverts commit c5f8a296.

Change-Id: Ibfc5a24dfc157c42b4cf796b35101191e88a6d15
Reviewed-on: https://gerrit.libreoffice.org/57221
Tested-by: Jenkins
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

modified Unit test for Line algorithm.

It checks the position of the childs and
compare it with position of that child in MSO.
It also checks whether the childs are in the
same horizontal level or not.

Change-Id: I8e6dcaaf2923fe9d0d24e945486ba2f2954927d3
Reviewed-on: https://gerrit.libreoffice.org/55891
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Added unit tests for snake algorithm which tests the position of the
child nodes in normal from left to right layout and from right to left
layout.

Change-Id: I25eeb5f8a98e06e748c95b72ffdf9e1a63a4d251
Reviewed-on: https://gerrit.libreoffice.org/56795
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

* Update helpcontent2 from branch 'master'
  - Also add that here…
    
    Change-Id: Ia31ace1a2f844dbd707839a44ec131f424513924
    

Change-Id: Ic11e481688401559c2e26cffd625d3b6e3bf2f03
Reviewed-on: https://gerrit.libreoffice.org/57219
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

* Update helpcontent2 from branch 'master'
  - Helponline: Fix alignment of TOC in sidebar
    
    It was too close to the window border in Edge, Chrome and Firefox Nightly.
    
    Change-Id: I29a7b17c6abc240baa1f75cba879942810ebee07
    

this improves load time by 20%.
We switch from shared_ptr to tools::SvRef to manage the objects

I noticed some double inheritance like this:
  DomainMapper
    LoggedProperties
      Properties
        SvRefBase
    LoggedTable
      Table
        SvRefBase
so to be safe I made all the ref-count-base-class inheritance
virtual.

Change-Id: Ia3de9733f5c6966e8171f43d083dcc087040b8cd
Reviewed-on: https://gerrit.libreoffice.org/57022Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fix leak in SwFieldPage::InsertField, where it interacts badly with
SwFieldMgr::UpdateCurField

The awkward
   return std::unique_ptr<SwField>(pTmp.release());
code is because clang 3.8.0 doesn't seem able to do auto-upcast of
std::unique_ptr.

Change-Id: I05b748e9cda145fd972a01bfa343239df32368b9
Reviewed-on: https://gerrit.libreoffice.org/57197
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - tdf#118430 Three column layout with 1440px width
    
    Contents will now stay collapsed until 1440px width, when
    it will move to the right side of the screen.
    Removed useless and harmful float:left from .index-label.
    
    Change-Id: I504e8c4be3a5e777dc7bafbd6a6105b163e4a5f3
    Reviewed-on: https://gerrit.libreoffice.org/57129
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I2588688ee11825088d2509d4f5908c29e93d0b1b

The function actually fails with sc/qa/.../xirr.fods if OpenCL is forced
(and mnOpenCLMinimumFormulaGroupSize is disabled). As far as I can tell
the OpenCL function gets the proper data and returns incorect data,
so it's the function itself that is buggy. No idea how to debug it,
feel free to.

Change-Id: I8879c6fdcfe8ecd2bc40fd3e0d1c13cddb1c2051
Reviewed-on: https://gerrit.libreoffice.org/57002
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I4b0d95faa7e6986f268f5faf1d26bdfa6a84e550
Reviewed-on: https://gerrit.libreoffice.org/57215
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I7b19938246ca8498fa300f781589bf17b3d486aa
Reviewed-on: https://gerrit.libreoffice.org/56723
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Id1c386fab92a2e21e7b2f07f08daf08d5886d027
Reviewed-on: https://gerrit.libreoffice.org/56774
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

The system has generic spell dictionaries for languages spoken in many
countries, but LibreOffice wants them to correspond to specific
language-country combinations. So do it like that then.

Change-Id: I9ec4bb4302b2f1eec3ce7b1c1ef8f2be867bad52
Reviewed-on: https://gerrit.libreoffice.org/57220
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

There are 3 sw document services: TextDocument, WebDocument and
GlobalDocument.

The current logic in SwView::InsertDoc() and
SwView_Impl::StartDocumentInserter() is to request a filter with the
same document service as the existing target document, so you can insert
only a GlobalDocument into a GlobalDocument, which doesn't make much
sense.

As it happens there are 2 different HTML import filters: "HTML" and
"HTML (StarWriter)", the latter using the TextDocument service.

So just hard-code to allow TextDocument regardless of the target
document.

(regression from 805fd1ca)

Change-Id: I7dc0dd4789fba8b61625ca8eae74a864aea383b0
Reviewed-on: https://gerrit.libreoffice.org/57193
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Center was already tested, lcov says.

Change-Id: I10707a7a6318f3a8268db365f703485418ce7d51
Reviewed-on: https://gerrit.libreoffice.org/57204
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Function isn't available any more. codebase has to be cleanded up

Change-Id: I42597cde5b5d2472f670552f49776775d5bf391e
Reviewed-on: https://gerrit.libreoffice.org/57183Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I5551b65d4c7fea7e38d7c5b40af7c1803218b960
Reviewed-on: https://gerrit.libreoffice.org/57203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I75c58682539c7f2dd69c8d46f795411aa9fdb52c
Reviewed-on: https://gerrit.libreoffice.org/57202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I95c248755200ab1651faa82f00d49f1ca8e04191
Reviewed-on: https://gerrit.libreoffice.org/57201
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I42381af772d545206fc7facb0b893f7a1c8625bf
Reviewed-on: https://gerrit.libreoffice.org/57200
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6d0687f2dbfc1b3d168440c7192ddaf7869ef58d
Reviewed-on: https://gerrit.libreoffice.org/57199
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If70990222a6a59cede90bb52413f22540dd06a75
Reviewed-on: https://gerrit.libreoffice.org/57198
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and give utl::OStreamWrapper a new constructor so that it knows it is
taking ownership of  the SvStream, which appears to fix several leaks

Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b
Reviewed-on: https://gerrit.libreoffice.org/57187
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fixing a memory leak

Change-Id: Ic7754bb88a11855a308d39c6c4c66b89652422a0
Reviewed-on: https://gerrit.libreoffice.org/57186
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

so the next poor sod who doesn't understand the instructions doesn't
waste time with the wrong way of specifying the tests

Change-Id: I9759c7f792ec80d660f70f79dc6e2589d44e360f
Reviewed-on: https://gerrit.libreoffice.org/57177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

If RTL is defined in the default (Normal) paragraph style,
then the footnote separator should be right-aligned.
In MSWORD, the alignment is not a property that is stored
with the footnote separator definition, and it is not a
page property like it is in LO.
The reverse needs to happen for LTR default paragraph style.

Based on my MSWORD observations, the only place where you can
indirectly set RightToLeft is in the "Normal" paragraph style.
That option is disabled in all of the other styles.

In LibreOffice, this is typically handled by the locale properties.
The default PAGE style's Footnotes - Position is RIGHT for
RTL locales, but LEFT for LTR locales.

It is kinda interesting that no one from a RTL locale complained
about wrongly-right-aligned footnote separator
from imported LTR .docx's.

None of this belongs in export code, since MSO doesn't support
specifying the location - it is just a consequence of the
RTL/LTR settings.

Change-Id: I07d26640116cb12cb9157cd1d902b4c774dbba26
Reviewed-on: https://gerrit.libreoffice.org/56532
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ic78e28080e9f2d77582fa3114646d860847b8960
Reviewed-on: https://gerrit.libreoffice.org/57207
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie5838d4b36dc95ff234724ec924b78740a15b664
Reviewed-on: https://gerrit.libreoffice.org/57205
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This cleanup should help simplify and clarify immensely.

An empty followStyle is treated the same as not
defining it at all, and if a style specifies a follow, why
not accept any style with that ID, regardless of whether
a UI name was attached?
HOWEVER, both this unit test and
tdf104713_undefinedStyles.docx ignore the w:next
IN MSO. I tested with 2013, 2010, and 2003 and they all
revert back to w:next being the same style
in these broken documents.

Perhaps the existing test of whether sStyleName.isEmpty()
is not the best test, but that is what it was, so keeping
it until some proof document comes along.

Change-Id: I28b1a5d67e6feea6b4d1ffdb77ec27bf6c824251
Reviewed-on: https://gerrit.libreoffice.org/57075
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>