This is a cleanup to https://gerrit.libreoffice.org/#/c/21230/

Change-Id: I3999c8af1b906105a448e61353a839237aec7098
Reviewed-on: https://gerrit.libreoffice.org/21276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Freetype is definitely not "generic" code. It is only used for Unix
platforms, but is not used for OS X which has it's own font/glyph/text
system called CoreText and that is implemented elsewhere in our
codebase.

Change-Id: I30b2756d2cd9a81b6f746988685295d25ba1de44
Reviewed-on: https://gerrit.libreoffice.org/21286Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

ImplFTSFontData derives from PhysicalFontFace, and implements the
mechanisms specified therein. It's not actually a "data" class, but
also implements a factory function that creates a
LogicalFontInstance object via Freetype. I believe the "S" in "FTS"
stands for "Server", which is a misnomer as Freetype is a font
renderer, not a font server.

Change-Id: Ibacc4bf3f850ddfb37016ea2e3e088279b1b1ba1
Reviewed-on: https://gerrit.libreoffice.org/21285Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

I want to keep this class in line with the naming of the base class.
ImplServerFontEntry derives from LogicalFontInstance, so the name
ServerFontInstance is a better fit.

Change-Id: I2d2e3919634c2aaa8e5d6d63b0bf718dec18c336
Reviewed-on: https://gerrit.libreoffice.org/21284Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Also revert "tdf#96257: Silly work-around to produce same result ..."
    from commit ec8bc265.

XOR rendering (it turns out) behaves oddly, and not for all operations.

Change-Id: Ie07d988bbf7fed10fb5625ac547a01a306b05319
Reviewed-on: https://gerrit.libreoffice.org/21282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Iecd8d1d1fafc9d80b40ab2069248678697dddb6c
Reviewed-on: https://gerrit.libreoffice.org/21274Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

A ctor of FontSelectPatternAttributes was moved twice, so an error
introduced under Windows

Change-Id: Id7cc8d01d643b27987f31d6c181d81ac440b6b1e
Reviewed-on: https://gerrit.libreoffice.org/21283Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I901a1acebf9e3fada56e2328f0acd95fba2b7ffb

Change-Id: Ib897e5fa5e80f75f501694dbf874aabd92253b25
Reviewed-on: https://gerrit.libreoffice.org/21247Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Martin Hosken <martin_hosken@sil.org>

This is the only variable in LogicalFontInstance with m_ as the
prefix, so changing to mpFontCache for consistency.

Also small tab cleanup in fontmanager.hxx

Change-Id: Id79392337795259568fbe71efb5200f1e31219a8

Change-Id: I49041e086c1da6d9cc23781e10b00997f227da8e

On second thoughts, FindFontFamilyByName is not a good name at all. I'm
changing it back to FindFontFamily. The parameter tells you how it's
being found.

Change-Id: Ie8278e1727075a49331135a149361a484aba91e5

There is a TODO in the code that suggests to do this, when I looked at the
collaboration diagram on Doxygen things made a LOT more sense.

Change-Id: If335498bb70872ffa5738cc5c17660faec84c35e
Reviewed-on: https://gerrit.libreoffice.org/21257Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Did a small change to ImplSVEvent * Window::PostUserEvent( const Link<void*,void>& rLink, ... ) in event.cxx file. Patch No. 5

Change-Id: I9e7fd099aec6d5d2060bdf4761f4cff4fbe31544
Reviewed-on: https://gerrit.libreoffice.org/21219Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

7c3c3006 is apparently worse than it
appeared at first glance since there are numerous assumptions about
bookmarks, such as that if they were inserted successfully they may be
copied successfully, which isn't the case for duplicate cross reference
bookmarks.

So fix this differently, by eliminating the duplicates and mapping all
reference fields to refer to the surviving bookmark.

It was not possible to do this in SwXBookmark by checking the makeMark()
return as that would raise interesting problems such as it's currently
guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just
connect 2 SwXBookmarks to the same core Mark, and we also can't leave
the SwXBookmark unconnected after attach.

Another alternative would be to temporarily allow inserting the
duplicate bookmarks and then eliminate them after the import, but what
is implemented now is to check from xmloff for duplicates, which is
reasonably simple.

Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9

Change-Id: Idce7f28d642f6dc23f16e3c963d0ed42782ed14a

so we can drop one more DockingWindow from .src files leaving
just one left

Change-Id: I2e12398ce7682193aace966ebb8d153ec9acea2e

Change-Id: I22ddb6416c48ab72bf3ee4a7e7d664bfd0dd51f1

Change-Id: I1a031facad52afbc84b06610f9bdd0a9f118ebeb

Current behavior:
The direction of the sheet is set to default from left to right

Expected behavior:
The action of changing the direction from left to right to become from right to left

Solution:
Added export for text writting direction.

Now <alignment readingorder="2"> export properly

Change-Id: I0a49ba0e458cbd6a7feae8e205ae583b7da30d0b

Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2
Reviewed-on: https://gerrit.libreoffice.org/21245Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I91003540f994eeaab78bc66ed6e0df9e9f59ee4b

Change-Id: I79f4581ee5d371f22f94043f1e5fa62a2ad430ff

Mainly to match Word's hide whitespace behavior.

Change-Id: Ica09bca5004adbfa14d1c9aca04079129f8a1a68

The size of the last page will change in a bit in Hide Whitespace mode,
the intention of the test is to check the behavior of the normal
(non-last) pages.

Change-Id: I69b9072c59b6ca4dc5d93062c21726a0f5c03c05

Did a small change to to void Window::RemoveUserEvent( ImplSVEvent * nUserEvent ) and to void Window::ImplNotifyKeyMouseCommandEventListeners( NotifyEvent& rNEvt ) in event.cxx file. Patch No. 6

Change-Id: I75bc321d2a257df00f51d7e71aed2bc26500e58e
Reviewed-on: https://gerrit.libreoffice.org/21220Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Did some changes to syswin.cxx file. Patch No. 18

Change-Id: I79d3ea2110ae72762681ae494ee44ba7fc61e112
Reviewed-on: https://gerrit.libreoffice.org/21235Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Did a small change in winproc.cxx file. Patch No. 9

Change-Id: I71e3876c0512e2696d61962f2427384354130bb3
Reviewed-on: https://gerrit.libreoffice.org/21224Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

...the implicitly-private derivation was presumably introduced by accident in
23fd991f "separate the sane from the less sane
in SwClient"

Change-Id: I30ec84b6a30c029cfbeb848ad37c9a532fec0a96

Did a small change to void Window::CallEventListeners( sal_uLong nEvent, void* pData ) in event.cxx file. Patch No. 4

Change-Id: I6dff8f0611833d1514552afad163cdb55f693980
Reviewed-on: https://gerrit.libreoffice.org/21216Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

The wget download apparently uses the time stamp of the file on the
server by default, which breaks incremental builds.

If wget downloads the file and it does not get the current timestamp at
the time of download but the one the file happens to have on the server,
then if you built from the previous version of the tarball at a later
time than the timestamp of the new tarball, make won't detect that it
has to unpack the new tarball.

The curl download should not be affected since curl requires an explicit
-R to use the server side time stamp.

Change-Id: I6bab51d20b8ab5e485fe68d3f27c31aaddc99f68

The 15.x.y.z.d number is not the real version number that our code
sees.

Change-Id: I8e434c0c3e3c4ff6ea8a6810f0b09f9b2befc438

Change-Id: I63d72b2d8f0b4835ab0ead51b518deab635ff3b0
Reviewed-on: https://gerrit.libreoffice.org/21222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Did a small change to dndevis.cxx file. Patch No. 1

Change-Id: I9240d97a9b0dd76a2df43e01f0d1e71de9015c48
Reviewed-on: https://gerrit.libreoffice.org/21211Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Did a small change to bool Dialog::Close() in dialog.cxx file. Patch No. 2

Change-Id: I5268e77bef2225308e9d01831c7b09de19c3ded9
Reviewed-on: https://gerrit.libreoffice.org/21212Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I79610ab5c9eb3812035d9d2c5f8ce1508451cd60
Reviewed-on: https://gerrit.libreoffice.org/21251Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Discussed on IRC - overwhelming consensus is to keep the headers
where they were before. The main reason to keep them in the same
directory is to keep headers as local as possible to the source
files, unless something else needs to access it.

The only thing that uses the headers is vc/workben/fftester.cxx

I will work out how to get Doxygen to pick up these headers another way.

This reverts commit 5d7772fc.

Change-Id: I45ee970722e27748ab8af8909ac49579dc47ef56
Reviewed-on: https://gerrit.libreoffice.org/21250Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Use binary search to find ImpBitmap BitCount in constant time.

Change-Id: Ica13d41d1473e01c9198c985d34206267d7910d1
Reviewed-on: https://gerrit.libreoffice.org/19759Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

...because they are asked for and stored in a successive user
interaction.

Change-Id: I09a3a1e59fe3819a28d7565e83b0db968dfee74b
Reviewed-on: https://gerrit.libreoffice.org/21040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Change-Id: I57a70f7f6833af5e2cf94f526e99d1353247afb9
Reviewed-on: https://gerrit.libreoffice.org/21249Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>