Change-Id: I88d0fb0e7c20d4b1414516e3bd2f961811b2eb8c

Change-Id: I394d164c4d3f26d906204e2ed89efeef597ba810

SdrObject is quite large and we can't pimplize it in one go.  Let's do
it bit by bit.

Change-Id: I40abe71799f6dcae90854dcc6979acc1d6ed7462

Change-Id: I5f4ccad5077427afd09668c93f56c0ecce5f6f5d

This is going to be very helpful troubleshooting problems with metafiles
that just won't display.

Change-Id: I661dd40e04434a9c64a0f59d9310d36444601989

This addresses some cppcheck warnings.

Change-Id: Ib35eb591534c3f23adc3cb7b7fa9696dc5cbeabf
Reviewed-on: https://gerrit.libreoffice.org/13383Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This addresses some cppcheck warnings.

Change-Id: I8931ff46394923d672e08b3a5c9ab75bb6ffb0a9
Reviewed-on: https://gerrit.libreoffice.org/13385Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I5fd2c7635f204bda982f1df58b4c19fe9b12464a

It could happen that during a SetDirty/Notify cycle a formula cell is
appended to the formula track but not tracked yet so doesn't end up in
the formula tree. If it was deleted then without removing it from the
track the cell pointer shortly after was moved into the tree, possibly
setting pFormulaTree (and/or pEOFormulaTree) to that cell if it was the
last cell, and if immediately after that a new ScFormulaCell was
allocated at exactly the same memory location it virtually ended up as a
successor of itself in the formula tree ... leading to a crash if pCode
was accessed in a subsequent RemoveFromFormulaTree because the cell was
assumed to be already in the tree.

Change-Id: I9d1885a26b85c2331a084b5f89a2d7373cf2df0f

Change-Id: I61b6912da303b9d71eed142535f3aa0cac1681eb

Not only are multiple boolean parameters ugly, but prepare also for the
new broadcasters-only mode yet to be implemented.

Change-Id: Ie6383826e76a771b88e7b4b29e5de9a58c598ad5

And remove #include <vector> which wasn't really used.

Change-Id: I05bbc7848c753795f859f80725be6332d8e5ce46

on the somewhat dubious logic of matching the otherwise
near-identical duplicate logic later on

Change-Id: Ic029cafbf2fa2a1fd3cf78464d58977f90bbc418

To make sure they use range-based area listeners (when applicable) and
make sure that they still pass.

Change-Id: I75b73b6feb34057268277212733476ddede2b757

Change-Id: I74ccd6c8a3cfd45929973f21418458f3a83243af

This causes problems for renamed copies of std. styles, as they have
special handling in SdStyleSheet::SetHelpId, which would set the API
name to std. value too. That means that there would be two (or more)
stylesheets with the same API name. On export, only one of them would be
exported.

Change-Id: I19d243bd3f73995e8de2d251e3d8b7f93219c3a9

Change-Id: I5f6b2136f4eb5cdb4825a3df3fc7d2015d8a3d85

Change-Id: I0c247a0f316b6700017ae0668b41497811924577

Change-Id: I7607ecd8c0e5d67a6e38e1930b416fa834906dd3

and

coverity#1186125 Big parameter passed by value

Change-Id: I6cb6863645647edf4fba114059195582679c30c4

Change-Id: I4a41a2975f670b06159de5c94ab9a66ab204c725

e.g. fdo63164-1.docx and loads more like that, and the .docx genuinely has
multiple bookmarks at the same place, so just allow the first one and discard
the following ones

Change-Id: Ida2f5d79fdef4ed3e2d8c1e96ca6a086004f6c7d

on the basis that it doesn't look obviously wrong to the original author after
a once-over

Change-Id: If333a17a2a9954d33ebefc6846e40e0e1e29c857

Change-Id: I420fa77d52ca72a4c4609b4610572b8735911b4b

and

coverity#1257108 Unchecked dynamic_cast

Change-Id: Ib0d42b7fcd3b2b87a95301b111cebe80f54dd13f

Change-Id: Ib52cfc8ba45361277ef8e0b6021a03c3ff8ae668

Change-Id: Ib131c480b53665fc9e9a38388e3cc179eac249c2

Change-Id: I2e405a8a02ef81b82b4762bd826769c2491b3aec

Graphic shapes are those images which are created not in
Writer (but e.g. Impress, Calc) and moved to Writer later
(e.g. copy&paste).

Embedded image is ok, but MS filters broke the linked
graphic shape.

Change-Id: I0c86a5d09afb3e40f7d9e5986c05801457d4c13f

IsLinkedGraphic() is better to use here.

Reproducer steps:
-Insert an image to Impress as a link.
-Copy this image (CTRL+C & CTRL+V) to Writer.
Result: Image is not displayed.

Change-Id: Iaf9b686b5c87caf5a0cc15425f8c5988f857bfe6

Change-Id: I6c47c4b78a1dcd76287cdca16265d3170d2794f5

Change-Id: If040bb32bb5289a282f315cd6ca90cbed76f9b8f

Change-Id: I17bc641373eafc49367d5605072270db6f7fe77b

Remove RefreshView (redraw) from some components, as it's supposedly little
used. Components which would have this shortcut are DrawingDocument,
GlobalDocument, PresentationDocument, WebDocument, FormDesign,
TextReportDesign, TextDocument, XMLFormDocument.

Change-Id: Ic730d390b4e4a1e6bcc76b18888932b198e5b82c

Change-Id: I5f432eea235bdca05132cf553d9bc15e2b825509

Change-Id: I223c85999a0ed1a62aece67f0d730b8e2e097ac9

Change-Id: I2eda267b56bc1548930add9c5ef83ad268f881a4

Change-Id: Ibc36dcde1778ee02b9ac173d9da8419b69854af6

Change-Id: Ie1a958b3f3fb5797ec2eb49f6a5fc72da23ca553

Change-Id: Ibc1d2deae5b0c7841ec83de880380170eadbd509